From 9d629855a0f4d7fdeda501bdf3c5cea0720aaf35 Mon Sep 17 00:00:00 2001 From: Leo Chen Date: Thu, 21 Mar 2019 07:23:27 +0000 Subject: [PATCH] [cleanup] remove unused wallet library Signed-off-by: Leo Chen --- cmd/client/wallet/main.go | 20 +++++++- internal/wallet/wallet/lib.go | 82 ------------------------------ internal/wallet/wallet/lib_test.go | 47 ----------------- 3 files changed, 18 insertions(+), 131 deletions(-) delete mode 100644 internal/wallet/wallet/lib.go delete mode 100644 internal/wallet/wallet/lib_test.go diff --git a/cmd/client/wallet/main.go b/cmd/client/wallet/main.go index 0877ce851..961a1290b 100644 --- a/cmd/client/wallet/main.go +++ b/cmd/client/wallet/main.go @@ -23,12 +23,13 @@ import ( "github.com/ethereum/go-ethereum/params" "github.com/harmony-one/harmony/api/client" clientService "github.com/harmony-one/harmony/api/client/service" + proto_node "github.com/harmony-one/harmony/api/proto/node" "github.com/harmony-one/harmony/core/types" nodeconfig "github.com/harmony-one/harmony/internal/configs/node" "github.com/harmony-one/harmony/internal/utils" - "github.com/harmony-one/harmony/internal/wallet/wallet" "github.com/harmony-one/harmony/node" "github.com/harmony-one/harmony/p2p" + p2p_host "github.com/harmony-one/harmony/p2p/host" "github.com/harmony-one/harmony/p2p/p2pimpl" ) @@ -346,7 +347,7 @@ func processTransferCommand() { amountBigInt := big.NewInt(int64(amount * params.GWei)) amountBigInt = amountBigInt.Mul(amountBigInt, big.NewInt(params.GWei)) tx, _ := types.SignTx(types.NewTransaction(state.nonce, receiverAddress, uint32(shardID), amountBigInt, params.TxGas, nil, inputData), types.HomesteadSigner{}, senderPriKey) - wallet.SubmitTransaction(tx, walletNode, uint32(shardID)) + submitTransaction(tx, walletNode, uint32(shardID)) } func convertBalanceIntoReadableFormat(balance *big.Int) string { @@ -499,3 +500,18 @@ func readPrivateKeys() []*ecdsa.PrivateKey { } return priKeys } + +// submitTransaction submits the transaction to the Harmony network +func submitTransaction(tx *types.Transaction, walletNode *node.Node, shardID uint32) error { + msg := proto_node.ConstructTransactionListMessageAccount(types.Transactions{tx}) + err := walletNode.GetHost().SendMessageToGroups([]p2p.GroupID{p2p.GroupIDBeaconClient}, p2p_host.ConstructP2pMessage(byte(0), msg)) + if err != nil { + fmt.Printf("Error in SubmitTransaction: %v\n", err) + return err + } + fmt.Printf("Transaction Id for shard %d: %s\n", int(shardID), tx.Hash().Hex()) + // FIXME (leo): how to we know the tx was successful sent to the network + // this is a hacky way to wait for sometime + time.Sleep(2 * time.Second) + return nil +} diff --git a/internal/wallet/wallet/lib.go b/internal/wallet/wallet/lib.go deleted file mode 100644 index 9e1655c3a..000000000 --- a/internal/wallet/wallet/lib.go +++ /dev/null @@ -1,82 +0,0 @@ -package wallet - -import ( - "fmt" - "time" - - "github.com/harmony-one/harmony/api/client" - proto_node "github.com/harmony-one/harmony/api/proto/node" - "github.com/harmony-one/harmony/core/types" - nodeconfig "github.com/harmony-one/harmony/internal/configs/node" - "github.com/harmony-one/harmony/internal/utils" - "github.com/harmony-one/harmony/node" - "github.com/harmony-one/harmony/p2p" - p2p_host "github.com/harmony-one/harmony/p2p/host" - "github.com/harmony-one/harmony/p2p/p2pimpl" - ma "github.com/multiformats/go-multiaddr" -) - -// CreateWalletNode creates wallet server node. -func CreateWalletNode() *node.Node { - utils.BootNodes = getBootNodes() - shardIDs := []uint32{0} - - // dummy host for wallet - self := p2p.Peer{IP: "127.0.0.1", Port: "6999"} - priKey, _, _ := utils.GenKeyP2P("127.0.0.1", "6999") - host, err := p2pimpl.NewHost(&self, priKey) - if err != nil { - panic(err) - } - walletNode := node.New(host, nil, nil) - walletNode.Client = client.NewClient(walletNode.GetHost(), shardIDs) - - walletNode.NodeConfig.SetRole(nodeconfig.ClientNode) - walletNode.ServiceManagerSetup() - walletNode.RunServices() - // wait for networkinfo/discovery service to start fully - // FIXME (leo): use async mode or channel to communicate - time.Sleep(2 * time.Second) - return walletNode -} - -// GetPeersFromBeaconChain get peers from beacon chain -// TODO: add support for normal shards -func GetPeersFromBeaconChain(walletNode *node.Node) []p2p.Peer { - peers := []p2p.Peer{} - - // wait until we got beacon peer - // FIXME (chao): use async channel for communiation - time.Sleep(4 * time.Second) - walletNode.BeaconNeighbors.Range(func(k, v interface{}) bool { - peers = append(peers, v.(p2p.Peer)) - return true - }) - utils.GetLogInstance().Debug("GetPeersFromBeaconChain", "peers:", peers) - return peers -} - -// SubmitTransaction submits the transaction to the Harmony network -func SubmitTransaction(tx *types.Transaction, walletNode *node.Node, shardID uint32) error { - msg := proto_node.ConstructTransactionListMessageAccount(types.Transactions{tx}) - err := walletNode.GetHost().SendMessageToGroups([]p2p.GroupID{p2p.GroupIDBeaconClient}, p2p_host.ConstructP2pMessage(byte(0), msg)) - if err != nil { - fmt.Printf("Error in SubmitTransaction: %v\n", err) - return err - } - fmt.Printf("Transaction Id for shard %d: %s\n", int(shardID), tx.Hash().Hex()) - // FIXME (leo): how to we know the tx was successful sent to the network - // this is a hacky way to wait for sometime - time.Sleep(2 * time.Second) - return nil -} - -func getBootNodes() []ma.Multiaddr { - // These are the bootnodes of banjo testnet - addrStrings := []string{"/ip4/100.26.90.187/tcp/9876/p2p/QmZJJx6AdaoEkGLrYG4JeLCKeCKDjnFz2wfHNHxAqFSGA9", "/ip4/54.213.43.194/tcp/9876/p2p/QmQayinFSgMMw5cSpDUiD9pQ2WeP6WNmGxpZ6ou3mdVFJX"} - bootNodeAddrs, err := utils.StringsToAddrs(addrStrings) - if err != nil { - panic(err) - } - return bootNodeAddrs -} diff --git a/internal/wallet/wallet/lib_test.go b/internal/wallet/wallet/lib_test.go deleted file mode 100644 index 923b9da24..000000000 --- a/internal/wallet/wallet/lib_test.go +++ /dev/null @@ -1,47 +0,0 @@ -package wallet - -import ( - "testing" - "time" - - "github.com/golang/mock/gomock" - "github.com/harmony-one/harmony/api/client" - proto_node "github.com/harmony-one/harmony/api/proto/node" - "github.com/harmony-one/harmony/api/service/networkinfo" - "github.com/harmony-one/harmony/core/types" - "github.com/harmony-one/harmony/node" - "github.com/harmony-one/harmony/p2p" - p2p_host "github.com/harmony-one/harmony/p2p/host" - mock_host "github.com/harmony-one/harmony/p2p/host/mock" -) - -func TestCreateWalletNode(test *testing.T) { - // shorten the retry time - networkinfo.ConnectionRetry = 3 - - walletNode := CreateWalletNode() - - if walletNode.Client == nil { - test.Errorf("Wallet node's client is not initialized") - } -} - -func TestSubmitTransaction(test *testing.T) { - ctrl := gomock.NewController(test) - defer ctrl.Finish() - - m := mock_host.NewMockHost(ctrl) - - m.EXPECT().GetSelfPeer().AnyTimes() - - walletNode := node.New(m, nil, nil) - walletNode.Client = client.NewClient(walletNode.GetHost(), []uint32{0}) - - tx := &types.Transaction{} - msg := proto_node.ConstructTransactionListMessageAccount(types.Transactions{tx}) - m.EXPECT().SendMessageToGroups([]p2p.GroupID{p2p.GroupIDBeaconClient}, p2p_host.ConstructP2pMessage(byte(0), msg)) - - SubmitTransaction(tx, walletNode, 0, nil) - - time.Sleep(1 * time.Second) -}