[rpc] fix transaction receipt fetch bug (#3327)

rpc/transaction.go

@@ -591,6 +591,10 @@ func (s *PublicTransactionService) GetTransactionReceipt(
 		if stx == nil {
 			return nil, nil
 		}
+		// if there both normal and staking transactions, add to index
+		if block, _ := s.hmy.GetBlock(ctx, blockHash); block != nil {
+			index = index + uint64(block.Transactions().Len())
+		}
 	}
 	receipts, err := s.hmy.GetReceipts(ctx, blockHash)
 	if err != nil {

rpc/v1/types.go

@@ -301,11 +301,11 @@ func NewReceipt(
 ) (interface{}, error) {
 	plainTx, ok := tx.(*types.Transaction)
 	if ok {
-		return NewTxReceipt(plainTx, blockHash, blockIndex, blockNumber, receipt)
+		return NewTxReceipt(plainTx, blockHash, blockNumber, blockIndex, receipt)
 	}
 	stakingTx, ok := tx.(*staking.StakingTransaction)
 	if ok {
-		return NewStakingTxReceipt(stakingTx, blockHash, blockIndex, blockNumber, receipt)
+		return NewStakingTxReceipt(stakingTx, blockHash, blockNumber, blockIndex, receipt)
 	}
 	return nil, fmt.Errorf("unknown transaction type for RPC receipt")
 }

rpc/v2/types.go

@@ -299,11 +299,11 @@ func NewReceipt(
 ) (interface{}, error) {
 	plainTx, ok := tx.(*types.Transaction)
 	if ok {
-		return NewTxReceipt(plainTx, blockHash, blockIndex, blockNumber, receipt)
+		return NewTxReceipt(plainTx, blockHash, blockNumber, blockIndex, receipt)
 	}
 	stakingTx, ok := tx.(*staking.StakingTransaction)
 	if ok {
-		return NewStakingTxReceipt(stakingTx, blockHash, blockIndex, blockNumber, receipt)
+		return NewStakingTxReceipt(stakingTx, blockHash, blockNumber, blockIndex, receipt)
 	}
 	return nil, fmt.Errorf("unknown transaction type for RPC receipt")
 }