[lint] fix ineffassign #708

api/proto/discovery/pingpong_test.go

@@ -89,6 +89,9 @@ func TestSerialize(test *testing.T) {
 	buf2 = pong1.ConstructPongMessage()
 
 	msg2, err := proto.GetMessagePayload(buf2)
+	if err != nil {
+		test.Error("GetMessagePayload Failed!")
+	}
 	pong, err := GetPongMessage(msg2)
 	if err != nil {
 		test.Error("Pong failed!")

api/service/explorer/service.go

@@ -146,12 +146,19 @@ func (s *Service) GetExplorerBlocks(w http.ResponseWriter, r *http.Request) {
 	}
 	db := s.storage.GetDB()
 	fromInt, err := strconv.Atoi(from)
+	if err != nil {
+		json.NewEncoder(w).Encode(data.Blocks)
+		return
+	}
 	var toInt int
 	if to == "" {
-		bytes, err := db.Get([]byte(BlockHeightKey))
+		toInt, err = func() (int, error) {
-		if err == nil {
+			bytes, err := db.Get([]byte(BlockHeightKey))
-			toInt, err = strconv.Atoi(string(bytes))
+			if err == nil {
-		}
+				return strconv.Atoi(string(bytes))
+			}
+			return toInt, err
+		}()
 	} else {
 		toInt, err = strconv.Atoi(to)
 	}

consensus/consensus_validator_test.go

@@ -79,8 +79,14 @@ func TestProcessMessageValidatorAnnounce(test *testing.T) {
 		test.Fatalf("Cannot craeate consensus: %v", err)
 	}
 	blockBytes, err := hex.DecodeString("f902a5f902a0a00000000000000000000000000000000000000000000000000000000000000000940000000000000000000000000000000000000000a02b418211410ee3e75b32abd925bbeba215172afa509d65c1953d4b4e505a4a2aa056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421b901000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000083020000808502540be400808080a000000000000000000000000000000000000000000000000000000000000000008800000000000000008400000001b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080a00000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000000c0c0")
+	if err != nil {
+		test.Fatalf("Cannot decode blockByte: %v", err)
+	}
 	consensusLeader.block = blockBytes
 	hashBytes, err := hex.DecodeString("bdd66a8211ffcbf0ad431b506c854b49264951fd9f690928e9cf44910c381053")
+	if err != nil {
+		test.Fatalf("Cannot decode hashByte: %v", err)
+	}
 
 	copy(consensusLeader.blockHash[:], hashBytes[:])
 
@@ -140,8 +146,14 @@ func TestProcessMessageValidatorPrepared(test *testing.T) {
 		test.Fatalf("Cannot craeate consensus: %v", err)
 	}
 	blockBytes, err := hex.DecodeString("f902a5f902a0a00000000000000000000000000000000000000000000000000000000000000000940000000000000000000000000000000000000000a02b418211410ee3e75b32abd925bbeba215172afa509d65c1953d4b4e505a4a2aa056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421b901000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000083020000808502540be400808080a000000000000000000000000000000000000000000000000000000000000000008800000000000000008400000001b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080a00000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000000c0c0")
+	if err != nil {
+		test.Fatalf("Cannot decode blockByte: %v", err)
+	}
 	consensusLeader.block = blockBytes
 	hashBytes, err := hex.DecodeString("bdd66a8211ffcbf0ad431b506c854b49264951fd9f690928e9cf44910c381053")
+	if err != nil {
+		test.Fatalf("Cannot decode hashByte: %v", err)
+	}
 
 	copy(consensusLeader.blockHash[:], hashBytes[:])
 
@@ -216,8 +228,14 @@ func TestProcessMessageValidatorCommitted(test *testing.T) {
 		test.Fatalf("Cannot craeate consensus: %v", err)
 	}
 	blockBytes, err := hex.DecodeString("f902a5f902a0a00000000000000000000000000000000000000000000000000000000000000000940000000000000000000000000000000000000000a02b418211410ee3e75b32abd925bbeba215172afa509d65c1953d4b4e505a4a2aa056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421b901000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000083020000808502540be400808080a000000000000000000000000000000000000000000000000000000000000000008800000000000000008400000001b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080a00000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000000c0c0")
+	if err != nil {
+		test.Fatalf("Cannot decode blockByte: %v", err)
+	}
 	consensusLeader.block = blockBytes
 	hashBytes, err := hex.DecodeString("bdd66a8211ffcbf0ad431b506c854b49264951fd9f690928e9cf44910c381053")
+	if err != nil {
+		test.Fatalf("Cannot decode hashByte: %v", err)
+	}
 
 	copy(consensusLeader.blockHash[:], hashBytes[:])
 

node/contract.go

@@ -75,6 +75,11 @@ func (node *Node) QueryStakeInfo() *structs.StakeInfoReturnValue {
 
 	state, err := node.blockchain.State()
 
+	if err != nil {
+		utils.GetLogInstance().Error("Failed to get blockchain state", "error", err)
+		return nil
+	}
+
 	stakingContractAddress := crypto.CreateAddress(deployerAddress, uint64(0))
 	tx := types.NewTransaction(
 		state.GetNonce(deployerAddress),

node/demo_contract.go

@@ -130,6 +130,10 @@ func (node *Node) GetResult(priKey string) (players []string, balances []*big.In
 
 	demoContractAddress := node.DemoContractAddress
 	key, err := crypto.HexToECDSA(priKey)
+	if err != nil {
+		utils.GetLogInstance().Error("Failed to parse private key", "error", err)
+	}
+
 	nonce := node.GetNonceOfAddress(crypto.PubkeyToAddress(key.PublicKey))
 
 	tx := types.NewTransaction(

test/p2pchat/chat.go

@@ -136,12 +136,17 @@ func main() {
 	}
 
 	if err != nil {
-		fmt.Printf("pubsub error: %v", err)
+		fmt.Printf("pub error: %v", err)
 		panic(err)
 	}
 
 	sub, err := ps.Subscribe("pubsubtestchannel")
 
+	if err != nil {
+		fmt.Printf("sub error: %v", err)
+		panic(err)
+	}
+
 	go writePubsub(ps)
 	go readPubsub(sub)