From b6471212554059cf35535065d0b6640dcf50e811 Mon Sep 17 00:00:00 2001 From: Eugene Kim Date: Tue, 12 Nov 2019 10:38:07 +0530 Subject: [PATCH] Add operational checklist to PR template --- PULL_REQUEST_TEMPLATE.md | 47 +++++++++++++++++++++++++++++++++++----- 1 file changed, 42 insertions(+), 5 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 8f5fa8afa..a232274ef 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -4,16 +4,53 @@ ## Test -#### Test Coverage Data +### Unit Test Coverage - +Before: -* Before -* After +``` + +``` -#### Test/Run Logs +After: + +``` + +``` + +### Test/Run Logs +## Operational Checklist + +1. **Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?**. (If no, skip to question 8.) + + **YES|NO** + +2. **Describe the migration plan.**. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration. + +3. **Describe how the plan was tested.** + +4. **How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?** + +5. **What are the planned flag epoch numbers and their ETAs on Pangaea?** + +6. **What are the planned flag epoch numbers and their ETAs on mainnet?** + + Note that this must be enough to cover baking period on Pangaea. + +7. **What should node operators know about this planned change?** + +8. **Does this PR introduce backward-incompatible changes *NOT* related to on-disk data structure and/or over-the-wire protocol?** (If no, continue to question 11.) + + **YES|NO** + +9. **Does the existing `node.sh` continue to work with this change?** + +10. **What should node operators know about this change?** + +11. **Describe this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?** + ## TODO