From e5728d1e1464c77a6e9a12bbe6fddd60e20c5221 Mon Sep 17 00:00:00 2001
From: xiaohuo <xiaohuo200@gmail.com>
Date: Fri, 2 Apr 2021 23:22:13 +0800
Subject: [PATCH] refactor: optimize long function
 getSideEffectOperationsFromUndelegateMap

---
 rosetta/services/tx_operation.go | 73 ++++++++++++++++++++------------
 1 file changed, 45 insertions(+), 28 deletions(-)

diff --git a/rosetta/services/tx_operation.go b/rosetta/services/tx_operation.go
index 143a10b0d..db72c26d4 100644
--- a/rosetta/services/tx_operation.go
+++ b/rosetta/services/tx_operation.go
@@ -464,7 +464,6 @@ func getSideEffectOperationsFromUndelegateMap(
 
 	for delegator, undelegationMap := range valueMap {
 
-		totalAmount := new(big.Int).SetUint64(0)
 		accID, rosettaError := newAccountIdentifier(delegator)
 		if rosettaError != nil {
 			return nil, rosettaError
@@ -478,47 +477,65 @@ func getSideEffectOperationsFromUndelegateMap(
 			Status:  common.SuccessOperationStatus.Status,
 			Account: accID,
 		}
-		opIndex++
 
+		opIndex++
 		operations = append(operations, receiverOp)
 		receiverIndex := len(operations) - 1
-		for validator, amount := range undelegationMap {
-			totalAmount = new(big.Int).Add(totalAmount, amount)
-			subAccId, rosettaError := newAccountIdentifierWithSubAccount(delegator, validator, map[string]interface{}{
-				SubAccountMetadataKey: UnDelegation,
-			})
-			if rosettaError != nil {
-				return nil, rosettaError
-			}
-			payoutOp := &types.Operation{
-				OperationIdentifier: &types.OperationIdentifier{
-					Index: opIndex,
-				},
-				RelatedOperations: []*types.OperationIdentifier{
-					receiverOp.OperationIdentifier,
-				},
-				Type:    opType,
-				Status:  common.SuccessOperationStatus.Status,
-				Account: subAccId,
-				Amount: &types.Amount{
-					Value:    negativeBigValue(amount),
-					Currency: &common.NativeCurrency,
-				},
-			}
-			operations = append(operations, payoutOp)
-			opIndex++
+
+		totalAmount, ops, err := getOperationAndTotalAmountFromUndelegationMap(delegator, &opIndex,
+			receiverOp.OperationIdentifier, opType, undelegationMap)
+		if err != nil {
+			return nil, err
 		}
+		operations = append(operations, ops...)
 
 		operations[receiverIndex].Amount = &types.Amount{
 			Value:    totalAmount.String(),
 			Currency: &common.NativeCurrency,
 		}
-
 	}
 
 	return operations, nil
 }
 
+// getOperationAndTotalAmountFromUndelegationMap is a helper for getSideEffectOperationsFromUndelegateMap which actually
+// has some side effect(opIndex will be increased by this function) so be careful while using for other purpose
+func getOperationAndTotalAmountFromUndelegationMap(
+	delegator ethcommon.Address, opIndex *int64, relatedOpIdentifier *types.OperationIdentifier, opType string,
+	undelegationMap map[ethcommon.Address]*big.Int,
+) (*big.Int, []*types.Operation, *types.Error) {
+	totalAmount := new(big.Int).SetUint64(0)
+	var operations []*types.Operation
+	for validator, amount := range undelegationMap {
+		totalAmount = new(big.Int).Add(totalAmount, amount)
+		subAccId, rosettaError := newAccountIdentifierWithSubAccount(delegator, validator, map[string]interface{}{
+			SubAccountMetadataKey: UnDelegation,
+		})
+		if rosettaError != nil {
+			return nil, nil, rosettaError
+		}
+		payoutOp := &types.Operation{
+			OperationIdentifier: &types.OperationIdentifier{
+				Index: *opIndex,
+			},
+			RelatedOperations: []*types.OperationIdentifier{
+				relatedOpIdentifier,
+			},
+			Type:    opType,
+			Status:  common.SuccessOperationStatus.Status,
+			Account: subAccId,
+			Amount: &types.Amount{
+				Value:    negativeBigValue(amount),
+				Currency: &common.NativeCurrency,
+			},
+		}
+		operations = append(operations, payoutOp)
+		*opIndex++
+	}
+	return totalAmount, operations, nil
+
+}
+
 // getSideEffectOperationsFromValueMap is a helper for side effect operation construction from a address to value map.
 func getSideEffectOperationsFromValueMap(
 	valueMap map[ethcommon.Address]*big.Int, opType string, startingOperationIndex *int64,