Tag:
Branch:
Tree:
01691fd3ea
cleanup/streamsync
delete/old_pending_crosslinks
dependabot/go_modules/github.com/quic-go/quic-go-0.37.7
dependabot/go_modules/google.golang.org/protobuf-1.33.0
dev
dev1secfin
feature/address-to-bls
feature/clear-stale-staking-data
feature/clear-stale-staking-data-31024
feature/dev-clear-stake-031024
feature/dev-engine_test
feature/elk
feature/go1.20
feature/go1.21
feature/groth16
feature/log_tx
feature/proposal
feature/refactor-consensus-view
feature/state_pruning_codes
feature/updated-libp2p-version
feature/updated-protobuf
fix/backup-initialization
fix/crosslink_processing
fix/data-race1
fix/delegation
fix/dev-go-mod
fix/dumpdb_memory_usage
fix/import
fix/is-backup
fix/legacysync_existed_block
fix/list-mile-block
fix/only-valid-blocks
fix/removed-outdated-check
fix/rollback2
fix/rotation-with-revert
fix/shard-id-from-key
fix/snapshot_disabled
fix/stakedVoteWeight
fix/streamsync_context
fix/vw_prefix
improvement/stream_sync_single_tx
log/pending_crosslinks
main
mergify/sophoah/config-update
revert-4628-fix/only-valid-blocks
update/ethdb2024
1.3.1
banjo_tag
before_sc
cello_tag
deployed-20190514T205159-puzzle
deployed-20190611T020930-drum
devnet+utxo
drum_20190612
drum_20190612a
drum_20190613
drum_20190614
drum_20190615
drum_20190616
drum_20190616a
drum_20190616b
drum_20190616c
drum_20190618
drum_tag
mainrc2_20190619b
mainrc2_20190619c
master-20191029.0
master-20191205.0
master-20191205.1
master-20191205.2
master-20191205.3
master-20191207.0
master-20191207.1
master-20191207.2
master-20191208.0
pangaea-20190820.0
pangaea-20190822.0
pangaea-20190903.0
pangaea-20190909.0
pangaea-20190909.1
pangaea-20190910.0
pangaea-20190912.0
pangaea-20190919.0
pangaea-20190919.1
pangaea-20190920.0
pangaea-20190924.0
r3-20190730
r3-20190730.1
r3-20190731
r3-20190801
r3-20190807
r3-20190810.0
r3-20190812.0
r3-20190814.0
r3-20190816.0
r3-20190822.0
r3-20190827.0
r3_20190623
r3_20190623.1
r3_20190626
r3_20190628
r3_20190726
s3-20190830.0
s3-20190830.1
s3-20190903.0
testnet-20191011.0
testnet-20191013.0
v1-20190910.0
v1-20190911.0
v1-20190911.1
v1-20190914.0
v1-20190914.1
v1-20190917.0
v1-20190924.0
v1-20191001.0
v1-20191001.1
v1-20191008.0
v1-20191019.0
v1-20191019.1
v1-20191207.0
v1.0-020200317.0
v1.0-1901
v1.0-1902
v1.0-20200316.0
v1.0-20200405.0
v1.0-20200405.2
v1.0-20200405.3
v1.0-20200405.4
v1.0-20200405.5
v1.0-20200405.6
v1.0-20200406.1
v1.0-20200414.0
v1.1.0
v1.1.1
v1.10.0
v1.10.1
v1.10.2
v1.2.0
v1.2.1
v1.2.2
v1.2.3
v1.2.4
v1.2.5
v1.2.6
v1.2.7
v1.3.0
v1.3.1
v1.3.10
v1.3.11
v1.3.12
v1.3.2
v1.3.3
v1.3.4
v1.3.5
v1.3.6
v1.3.7
v1.3.8
v1.3.9
v1.9.0
v2.0.0
v2.1.0
v2.1.1
v2.1.2
v2.1.3
v2.1.4
v2.1.5
v2.1.6
v2.1.7
v2.1.8
v2.1.9
v2.2.0
v2.3.0
v2.3.1
v2.3.2
v2.3.3
v2.3.4
v2.3.5
v2.3.6
v2.3.6-2
v2.3.7
v2.3.8
v2.4.0
v2013.1.3
v2023.1.0
v2023.1.1
v2023.2.0
v2023.2.1
v2023.2.2
v2023.2.4
v2023.2.5
v2023.2.6
v2023.2.7
v2023.3.0
v2023.4.0
v2023.4.1
v2023.4.2
v2024.0.0
v3.0.0
v3.1.0
v3.1.1
v3.1.15
v3.1.2
v3.1.3
v3.1.4
v4.0.0
v4.0.0-d
v4.0.1
v4.1.0
v4.1.1
v4.1.10
v4.1.2
v4.1.3
v4.1.4
v4.1.5
v4.1.6
v4.1.7
v4.1.8
v4.1.9
v4.2.0
v4.2.1
v4.3.0
v4.3.1
v4.3.10
v4.3.11
v4.3.12
v4.3.13
v4.3.14-rc
v4.3.14-rc2
v4.3.14.rc3
v4.3.2
v4.3.3
v4.3.4
v4.3.5
v4.3.6
v4.3.7
v4.3.8
v4.3.9
${ noResults }
181 Commits (01691fd3ea0840b25de58160cec1308829e2c209)
| Author | SHA1 | Message | Date |
|---|---|---|---|
Casey Gardiner
|
01691fd3ea
|
Release Candidate 2023.2.0 ( dev -> main ) (#4399)
* check leader for N blocks * fix * fix * Cleanup and fix update pub keys. * Rotate leader. * fix fix fix fix fix * Cleaned. * Cache for `GetLeaderPubKeyFromCoinbase`, removed `NthNextHmyExt`. * activate epoch * comment activation * 295 epoch * Fix failed tests. * Fixed code review. * Fix review "--port flag". * Fix review comments. * Returned locks in rotateLeader. * Rebased onto dev. * Commented golangci. * staged stream sync v1.0 * fix protocol tests * fix spell * remove unused struct * fix rosetta test * add comments and refactor verify sig * add comments, remove extra function * add comment * refactor errors, rename metrics * refactor p2p host creation * fix initsync and host creation * fix short range hash chain * fix beacon node detection for p2p protocol * refactor stream peer cooldown and fix protocol beacon node field * refactor p2p host and routing * fix p2p discovery test issue * add MaxAdvertiseWaitTime to handle advertisements interval and address stream connection issue * terminal print the peer id and proto id * fix boot complete message when node is shut down * add new config option ( ForceReachabilityPublic ) to fix local-net consensus issue * fix self query issue * fix test NewDNSSyncingPeerProvider * [testnet] disable leader rotation * fix discovery issue for legacy sync * add watermark low/high options for p2p connection manager * add test for new conn manager flags * fix dedent * add comment to inform about p2p connection manager options * fix max height issue * add a separate log for get max height error * fix log * feat: triesInMemory flag * fix: panic if TriesInMemory is 1 to 2 * in progress. * consensus check is forked * fix * Cleanup and fix update pub keys. * fix fix fix fix fix * activate epoch * EpochTBD for leader rotation epoch. * 295 epoch * Decider no longer requires public keys as a dependency. (#4289) * Consensus doesn't require anymore `Node` as a circular dependency. * Proper blockchain initialization. * Rwlock consensus. * Removed channels. * Removed view change locks. * Removed timers locks. * Removed fbft locks. * Removed multiSigMutex locks. * Removed leader locks. * Removed additional locks and isViewChange. * Added locks detected by race. * Added locks detected by race. * Locks for start. * Removed additional logs. * Removed additional locks. * Removed additional locks. * Make func private. * Make VerifyBlock private. * Make IsLeader private. * Make ParseFBFTMessage private. * Fix remove locks. * Added additional locks. * Added additional locks. * Added readSignatureBitmapPayload locks. * Added HandleMessageUpdate locks. * Added LastMile locks. * Locks for IsValidatorInCommittee. * Fixed locks. * Fixed tests. * Fixed tests. * Fixed lock. * Rebased over leader rotation. * Fix formatting. * Rebased onto dev. * in progress. * consensus check is forked * update master * fix leader * check leader for N blocks * fix * fix * Cleanup and fix update pub keys. * Rotate leader. * fix fix fix fix fix * Cleaned. * Cache for `GetLeaderPubKeyFromCoinbase`, removed `NthNextHmyExt`. * comment activation * 295 epoch * Fix failed tests. * Fixed code review. * Fix review comments. * Merged leader rotation. * Rebased on dev. * Rebased on dev. * Fix usage of private methods. * Fix usage of private methods. * Fix usage of private methods. * Removed deadcode, LockedFBFTPhase. * Fix review comment. * Fix review comment. * Go mod tidy. * Set to EpochTBD. * Fix tests. * [core] fix state handling of self destruct If a contract self destructs to self and then receives funds within the same transaction, it is possible for its stale state to be saved. This change removes that possibility by checking for deleted state objects before returning them. * Fixed race error. * rpc: add configurable http and `eth_call` timeout * remove default timeouts * store the evm call timeout in rosetta object * [cmd] actually apply ToRPCServerConfig * Removed unused method. * Rotate external leaders on non-beacon chains. * Fix nil panic. * in progress. * in progress. * in progress. * consensus check is forked * update master * fix leader * check leader for N blocks * fix * fix * Cleanup and fix update pub keys. * Rotate leader. * fix fix fix fix fix * Cleaned. * Cache for `GetLeaderPubKeyFromCoinbase`, removed `NthNextHmyExt`. * Fixed code review. * Fix review comments. * Returned locks in rotateLeader. * Rebased onto dev. * staged stream sync v1.0 * refactor errors, rename metrics * fix p2p discovery test issue * add watermark low/high options for p2p connection manager * fix dedent * in progress. * consensus check is forked * fix * Cleanup and fix update pub keys. * fix fix fix fix fix * activate epoch * EpochTBD for leader rotation epoch. * 295 epoch * Decider no longer requires public keys as a dependency. (#4289) * Consensus doesn't require anymore `Node` as a circular dependency. * Proper blockchain initialization. * Rwlock consensus. * Removed channels. * Removed view change locks. * Removed multiSigMutex locks. * Removed leader locks. * Removed additional locks and isViewChange. * Added locks detected by race. * Added locks detected by race. * Locks for start. * Removed additional locks. * Removed additional locks. * Make func private. * Make VerifyBlock private. * Make IsLeader private. * Make ParseFBFTMessage private. * Fix remove locks. * Added additional locks. * Added additional locks. * Added readSignatureBitmapPayload locks. * Added HandleMessageUpdate locks. * Added LastMile locks. * Locks for IsValidatorInCommittee. * Fixed locks. * Fixed tests. * Fixed lock. * Rebased over leader rotation. * in progress. * consensus check is forked * update master * fix leader * check leader for N blocks * fix * fix * Cleanup and fix update pub keys. * Rotate leader. * fix fix fix fix fix * Cleaned. * Cache for `GetLeaderPubKeyFromCoinbase`, removed `NthNextHmyExt`. * Fix failed tests. * Fixed code review. * Fix review comments. * Merged leader rotation. * Rebased on dev. * Rebased on dev. * Fix usage of private methods. * Fix usage of private methods. * Fix usage of private methods. * Removed deadcode, LockedFBFTPhase. * Fix review comment. * Go mod tidy. * remove default timeouts * Rotate external leaders on non-beacon chains. * Fix nil panic. * Fixes. * Update singleton.go * evm: don't return extcode for validators Due to technical debt, validator information is stored in the code field of the address. The code field can be accessed in Solidity for an arbitrary address using `extcodesize`, `extcodehash`, and `extcodecopy` or helper commands (such as `address.code.Length`). The presence of this field is used by contract developers to (erroneously) deny smart contract access to other smart contracts (and therefore, validators). This PR fixes that oversight by returning the same values as other EOAs for known validator addresses. Obviously, it needs a hard fork that will be scheduled separately. * Fix context passing. * Clean up code. * Removed engine dependency. * Fix possible panic. * Clean up code. * Network type. * Fix tests. * Revert "Removed engine dependency." (#4392) * Revert "Fix tests." This reverts commit |
2 years ago |
|
Casey Gardiner
|
eaf5d9c701
|
Rebase dev branch to current main branch (#4318)
|
2 years ago |
Konstantin
|
1c443aee45
|
Remove blockchain dependency from engine. (#4310)
* Consensus doesn't require anymore `Node` as a circular dependency. * Rebased upon main. * Removed engine beacon chain dependency. * Fixed nil error. * Fixed error. |
2 years ago |
PeekPI
|
0b342d769e
|
Testnet shard reduction (#4301)
* reduce shard of testnet to 2 * remove harmony inner nodes in shard2 and shard3 * check shardID in VerifyCrossLink * get NumShards by epoch instead of hardcodeed shards * add Localnet in NewGenesisSpec * do mayTestnetShardReduction in the block before the last block * fix localnet epoch calculation * not use old committee if shard reduction happens * fix preLastBlock calculation * do testnet shard reduction when propose new blocks * enable 2s block period at epoch 0 * call IntermediateRoot once in the end * skip inactive&baned validators when testnet shard reduction happens * update ShardReductionEpoch to epoch 486 |
2 years ago |
|
Konstantin
|
c5a35d2859
|
Removed shouldPreserve dead code. (#4264)
|
2 years ago |
lutty
|
720f9a6a02 |
tested tikv code
|
2 years ago |
Konstantin
|
1445223b5a
|
Increase suggested gas and reduce block gas limit (#4222)
* lower gas limit to 30M * increase suggested gas to 70 percentile and increase max suggested gas to 1000 * Fix race error. * Increase price limit to 100e9. * Set 95 percentile. * Fix rpc response. * [test] adjust funds for new higher gas price * [rosetta] use new gas price Co-authored-by: Rongjian Lan <rongjian.lan@gmail.com> Co-authored-by: Konstantin <k.potapov@softpro.com> Co-authored-by: MaxMustermann2 <82761650+MaxMustermann2@users.noreply.github.com> |
2 years ago |
|
Konstantin
|
4eabc120b1
|
Blockchain interface. (#4214)
* Blockchain interface. * Fix comments, remove unused. Co-authored-by: Konstantin <k.potapov@softpro.com> |
2 years ago |
Rongjian Lan
|
86cbcf106e |
increase block gas limit to 50m
|
3 years ago |
|
Rongjian Lan
|
e24559194d |
temp reduce gas limit to 20m
|
3 years ago |
Max
|
d500c4ede6
|
Resolve harmony-one/bounties#77: Staking precompiles (#3906)
* Resolve harmony-one/bounties#77: Staking precompiles Create write capable precompiles that can perform staking transactions Add hard fork logic (EpochTBD) for these precompiles Tests for new code with at least 80% unit test coverage Staking library + tests in MaxMustermann2/harmony-staking-precompiles * Fix small typo in comment * Run goimports on files to fix Travis * Do not activate staking precompile on shard 0 * Cascade readOnly to WriteCapableContract * No overlap in readOnly + writeCapable precompiles * Use function selector instead of directive From Solidity, use abi.encodeWithSelector and match it against the exact ABI of the functions. This allows us to remove the need for a directive (32) being encoded, and thus saves 28 bytes of data. * Do not allow contracts to become validators As discussed with Jacky on #3906 * Merge harmony-one/harmony/main properly this time * Run goimports * Update gas calculation for staking precompile Please see comment in core/vm/contracts_write.go RequiredGas * Do not allow contract to become validator (2/2) * Cache StakeMsgs from precompiled transactions Add the StakeMsgs to ProcessorResult and cascade them in insertChain * Remove ContractCode fields from validators Since smart contracts can no longer beecome validators, this field is superfluous. Remove it from the Wrapper structure, and do not assign it a value when creating a validator. Build and goimports checked * Update comments in response to feedback (1) Comments to start with function names (2) Comments for public variables (3) Comment to match function name RunPrecompiledContract (4) Clarify that CreateValidatorFunc + EditValidatorFunc are still used * Fix Travis build by reverting rosetta change * Add revert capability to 3 staking tx types - Delegate - Undelegate - CollectRewards * Fix build: Update evm_test for ValidatorWrapper * Merge main into harmony-staking-precompiles * Add gas for precompile calls and allow EOA usage - Each time the precompile is called, charge the base gas fee plus data cost (if data can be parsed successfully). A gas fee is added to prevent benevolent contract deployers from subsidizing the staking transactions for EOAs through repeated assembly `delegatecall`. - Allow EOAs to use the staking precompile directly. Some changes to the Solidity library are associated with this change. - Remove bytes from parsing address, since the ABI unpacks it into an address format correctly. - Add or update tests. Test coverage report to be attached to the PR shortly. * Run goimports * Check read only and write capable for overlap * Handle precompile stakeMsgs for block proposer The staking precompile generates staking messages which are cascaded to the block via the EVM in `state_processor.go`. This change cascades them in `worker.go` to allow block proposers and block verifiers to keep the same state. * Run goimports for cf2dfac4081444e36a120c9432f4e.. * Update staking precompile epoch to 2 for localnet Bring it in line with staking epoch. Change effects all configurations except mainnet and testnet. `goimports` included. * Add read only precompile to fetch the epoch num * Move epoch precompile to 250 * precompiles: left pad the returned epoch number * chainConfig: check epochs for precompiles panic if staking precompile epoch < pre staking epoch * Add staking migration precompile - Lives at address 251 - Migrates delegations + pending undelegations from address A to B - Useful if address A is hacked - Charges gas of 21k + cost of bytes for two addresses - Does not remove existing delegations, just sets them to zero. Replicates current undelegate setup - Unit tests and `goimports` included. Integration test following shortly in MaxMustermann2/harmony-staking-precompiles * Migration precompile: merge into staking Merge the two precompiles into one, add gas calculation for migration precompile. Move epoch precompile to 251 as a result. When migrating, add undelegations to `To`'s existing undelegations, if any match the epoch. * Add migration gas test, remove panic, add check In response to review comments, add tests for migration gas wherein there are 0/1/2 delegations to migrate. Add the index out of bound check to migration gas calculator and remove panics. Lastly, re-sort migrated undelegations if no existing undelegation in the same epoch was found on `To`. * Move undelegations sorting to end of loop |
3 years ago |
|
Rongjian Lan
|
d442ba9efc
|
Cache block processing results and reuse during block commitment to db (#3905)
* Cache block processing results and reuse during block commitment to db * fix comments |
3 years ago |
|
Rongjian Lan
|
404394a48d
|
a few spam protections (#3769)
* various spam protections * remove temporary block txn limit * remove dup code * update _gasPrice rpc to have 10gwei |
3 years ago |
|
Rongjian Lan
|
556e62da13
|
add limit on block size (#3760)
|
4 years ago |
Jacky Wang
|
2d70b2adab
|
[engine] added additional cache epochCtxCache for engineImpl, also removed shardID in engineImpl (since it's redundant with chainReader.ShardID())
|
4 years ago |
|
Jacky Wang
|
cd50682097
|
[engine][stream] updated engine VerifyHeaderWithSignature and fix downloader test
|
4 years ago |
|
Rongjian Lan
|
d1f1103b02
|
Resolves issues on eth comaptible txns (#3500)
* make eth txn works * Add forking logic for ethereum compatible txn support |
4 years ago |
|
Rongjian Lan
|
d6e98436f4
|
Add EthChainID and update signers accordingly for processing eth txns. (#3497)
* allow eth hmy txn conversion * Add EthChainID and update signers for it * resolve comments about hash() |
4 years ago |
|
Rongjian Lan
|
9381b95cdc
|
Remove special eth txn in block and block proposal logic. (#3496)
* Add ethereum transaction support * fix fmt * fix lint * add new block body fork logic * add back deleted code * lower case block version const * add eth txn into new version of block * refactor back * refactor more * fix test code * Fix build * Fix build * revert eth txn in block and block proposal * fix build * fix build * fix build |
4 years ago |
|
Rongjian Lan
|
666033c3eb
|
Add InternalTransaction and CoreTransaction interface to abstract txns (#3494)
* Add ethereum transaction support * fix fmt * fix lint * add new block body fork logic * add back deleted code * lower case block version const * add eth txn into new version of block * refactor back * refactor more * fix test code * Fix build * Fix build |
4 years ago |
|
Rongjian Lan
|
8d878e575d |
Fix viewID in block proposal
|
4 years ago |
|
Rongjian Lan
|
46bf183d1f |
fix typo
|
4 years ago |
|
Rongjian Lan
|
0029ced6b2 |
Add constant for timeouts
|
4 years ago |
|
Rongjian Lan
|
af8fe283db |
Add more comments and shorten timeout
|
4 years ago |
Daniel Van Der Maden
|
b088d6dc77
|
Rosetta Implementation Cleanup (Stage 3 of Node API Overhaul) (#3390)
* [core] Add FindLogsWithTopic & unit test Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Add GetDetailedBlockSignerInfo Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Add IsCommitteeSelectionBlock Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [test] Add test transaction creation helpers Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Refactor account.go & add tests * Move TestNewAccountIdentifier & TestGetAddress to account_test.go Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Move Operation & Tx formatting to own files * Move Respective unit tests to own files * Expose GetOperations & GetStakingOperations * Expose FormatTransaction, FormatCrossShardReceiverTransaction, FormatGenesisTransaction, FormatPreStakingRewardTransaction & FormatUndelegationPayoutTransaction Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Move TransactionMetadata to transaction_construction.go Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Update construction to use new helpers & formatters * Make docs consistent for mempool.go Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Move all special tx & blk handling to own file Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Remove all moved fns, methods & tests from block.go Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * Fix lint & imports Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Rename all tx related files for clarity Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Rename DefaultSenderAddress to FormatDefaultSenderAddress Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Rename Currency to NativeCurrency * This is in anticipation of HRC20 token support with rosetta * Rename various native operation functions accordingly * Add documentation to explain what a native token is Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix pre-staking block reward calculation * Move getPreStakingRewardTransactionIdentifiers to block_special.go * Add epoch to block metadata * Update unit tests Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * Add IsLastBlockInEpoch method to Block & Header * Refactor all uses of length check `ShardState` * [hmy] Refactor IsCommitteeSelectionBlock to use chain.IsCommitteeSelectionBlock * Address PR comments Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Update var names in preStakingRewardBlockTransaction Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> |
4 years ago |
|
Rongjian Lan
|
4452b36ee4
|
Rollup evm to geth v1.9.9 Muir Glacier (#3356)
* Rollup evm to geth v1.9.9 Muir Glacier * fix go gen * update intrinsic gas for istanbul * Update statedb.Commit * revert go gen result * revert protobuf version * update protobuf * update go gen files * set testnet epoch for evm upgrade |
4 years ago |
|
Rongjian Lan
|
6845775078 |
Make block proposal async and receiving last commit sig through channel
|
4 years ago |
|
Rongjian Lan
|
7ed4f22dcf
|
cleanup and fixes during audit (#2931)
|
5 years ago |
|
Rongjian Lan
|
6ec6b6378a
|
remove unused code; continue on failed slash record; Fix delete slash func on SetDifference (#2923)
* remove unused code and continue on failed slash record * Fix delete slash func |
5 years ago |
|
Rongjian Lan
|
2ccc20be2b
|
Fix slash verify to avoid potential duplicate slashes exploit (#2914)
* Remove timestamp in slash record * Fix potential exploits of reporting duplicate slashes * fix import * dedup swapped votes |
5 years ago |
|
Rongjian Lan
|
8fde77d88f
|
Revert merge normal and staking txns (#2895)
* Revert merge normal and staking txns * fix lint * fix build |
5 years ago |
|
Rongjian Lan
|
918dec8cbe
|
Make TxPool ordering deterministic (#2892)
* Roll back validator list when block is reverted * fix error check * Make TxPool ordering deterministic |
5 years ago |
|
Rongjian Lan
|
3808f5317b
|
Make commit sig committed along with the block (#2875)
* Make commit sig committed along with the block * Fix type len check |
5 years ago |
Ganesha Upadhyaya
|
21327e697e
|
[core][node/worker] processing staking and normal transactions together (#2869)
* processing staking and normal transactions together * bug fix and removing unwanted method * made sense to rename and move the TransactionsByPriceAndNonce to pool type * accounting for prestaking blocks, need to keep the previous order for processing txs |
5 years ago |
|
Rongjian Lan
|
614f528f2c
|
Add cache to state validator modification; refactor snapshot read/write (#2844)
* Add cache to state validator access; refactor snapshot read/write * make validator update happen at commit * fix lint * make sure slashing applies on validator wrapper in state * Revert live update of validtor wrapper in staking txn * add init population of validator cache logic * Fix validator cache commit logic * Separate validatorWrapper func * fix build * Fix lint |
5 years ago |
Edgar Aroutiounian
|
2836f0f620
|
[project] Remove over complicated packages, useless tests, dead functions (#2780)
* [project] Dead test * [node] If fields always same, then just use the constant * [project] Remove overcomplicated ctxerror * [project] Remove more dead tests, adjust error replacing ctxerror * [project] More dead tests, fix travis complaint on Errorf * [node.sh] Remove is-genesis |
5 years ago |
|
Edgar Aroutiounian
|
9fa85b586b
|
[project] Remove dead Lottery app code, optimize node/... on what staticcheck showed (#2688)
|
5 years ago |
|
Rongjian Lan
|
71361da6bd
|
more audit todos and fixes (#2489)
|
5 years ago |
|
Rongjian Lan
|
84ffbcfb7a
|
[audit] Various fixes and todos for auditing; add log for collect rewards (#2448)
* More logs and checks before processing staking txns * fix import * Refactor block proposal * Various fixes and todos for auditing; add log for collect rewards * Fix lint * fix comment |
5 years ago |
|
Edgar Aroutiounian
|
2baab4864c
|
[staking][validation][protocol] (#2396)
* [staking][validation][protocol] Limit max bls keys * [staking-era] Fold banned and active into single field * [slash][effective] Remove LRU cache for slash, change .Active to enumeration * [slash] Remove leftover wrong usage of Logger * [slash][offchain] Only Decode if len > 0 * [offchain] cosmetic * [slash] Remove some logs in proposal * [webhook] Move webhook with call for when cannot commit block * [shard] Finally make finding subcommittee by shardID an explicit error * [node] Whitespace, prefer literal * [webhook] Report bad block to webhook * [slash] Expand verify, remove bad log usage, explicit error handle * [slash] Check on key size * [slash] Explicit upper bound of pending slashes * [slash] Use right epoch snapshot, fail to verify if epoch wrong on beaconchain * [multibls] Make max count allowed be 1/3 of external slots * [quorum] Remove bad API of ShardIDProvider, factor out committee key as method of committee * [verify] Begin factor out of common verification approach * [project] Further remove RawJSON log, use proper epoch for snapshot * [slash] Implement verification * [slash] Implement BLS key verification of ballots * [rpc] Keep validator information as meaningful as possible * [staking] Never can stop being banned * [slash] Comments and default Unknown case of eligibility * [slash] Be explicit on what input values allowed when want to change EPOSStatus * [consensus] Remove unneeded TODO * [verify] Add proper error message * [rpc] Give back to caller their wrong chain id * [chain] Add extra map dump of delegation sizing for downstream analysis * [engine] Less code, more methods * [offchain] More leniency in handling slash bytes and delete from pending * [validator] Remove errors on bad input for edit |
5 years ago |
|
Edgar Aroutiounian
|
cf3b5053ba
|
[webhook][rpc][availability] Hooks, current signing, remove median-stake cached values (#2423)
* [webhook] Loop over all self address * [rpc] Remove accidential recursion * [rpc] Never ignore errors, fix RPC with current snap info, no div by zero * [rpc] Expose BadBlock for downstream * [availability] Thread through missing signers for offchain usage in WriteBlockWithState * [project] Merge with master, accept master conflicts * [offchain] Remove inactive signers from offchain data, should fix median-stake issues * [rpc] Test idea that returning error cause jenkins failure * [staking] Put editvalidator back into validator list cache * [rpc] Add network voting-power to validator information * [votepower] Extend roster with raw percentage * [rpc] If have validator but not snapshot, give back validator * [rpc] Expose effective-stake as well * [project] Remove missedSignThreshold map, use instance for stakedslots count * [staking] Remove edit-validator idea from previous filter idea |
5 years ago |
|
Rongjian Lan
|
9b8cd1bb2a
|
[auditing] Add more logs; checks before processing staking txns (#2391)
* More logs and checks before processing staking txns * fix import * Refactor block proposal |
5 years ago |
flicker-harmony
|
aadeae045c |
Refactor explorer service and add addresses fetch from db
|
5 years ago |
|
Edgar Aroutiounian
|
c4d744e376
|
[double-sign] Provide proof of double sign in slash record sent to beaconchain (#2253)
* [double-sign] Commit changes in consensus needed for double-sign
* [double-sign] Leader captures when valdator double signs, broadcasts to beaconchain
* [slash] Add quick iteration tool for testing double-signing
* [slash] Add webhook example
* [slash] Add http server for hook to trigger double sign behavior
* [double-sign] Use bin/trigger-double-sign to cause a double-sign
* [double-sign] Full feedback loop working
* [slash] Thread through the slash records in the block proposal step
* [slash] Compute the slashing rate
* [double-sign] Generalize yaml malicious for many keys
* [double-sign][slash] Modify data structures, verify via webhook handler
* [slash][double-sign] Find one address of bls public key signer, seemingly settle on data structures
* [slash] Apply to state slashing for double signing
* [slash][double-sign] Checkpoint for working code that slashes on beaconchain
* [slash] Keep track of the total slash and total reporters reward
* [slash] Dump account state before and after the slash
* [slash] Satisfy Travis
* [slash][state] Apply slash to the snapshot at beginning of epoch, now need to capture also the new delegates
* [slash] Capture the unique new delegations since snapshot as well
* [slash] Filter undelegation by epoch of double sign
* [slash] Add TODO of correctness needed in slash needs on off-chain data
* [rpc] Fix closure issue on shardID
* [slash] Add delegator to double-sign testing script
* [slash] Expand crt-validator.sh with commenting printfs and make delegation
* [slash] Finish track payment of leftover slash debt after undelegation runs out
* [slash] Now be explicit about error wrt delegatorSlashApply
* [slash] Capture specific sanity check on slash paidoff
* [slash] Track slash from undelegation piecemeal
* [slash][delegation] Named slice types, .String()
* [slash] Do no RLP encode twice, once is enough
* [slash] Remove special case of validators own delegation
* [slash] Refactor approach to slash state application
* [slash] Begin expanding out Verify
* [slash] Slash on snapshot delegations, not current
* [slash] Fix Epoch Cmp
* [slash] Third iteration on slash logic
* [slash] Use full slash amount
* [slash] More log, whitespace
* [slash] Remove Println, add log
* [slash] Remove debug Println
* [slash] Add record in unit test
* [slash] Build Validator snapshot, current. Fill out slash record
* [slash] Need to get RLP dump of a header to use in test
* [slash] Factor out double sign test constants
* [slash] Factor out common for validator, stub out slash application, finish out deserialization setup
* [slash] Factor out data structure creation because of var lexical scoping
* [slash] Seem to have pipeline of unit test e2e executing
* [slash] Add expected snitch, slash amounts
* [slash] Checkpoint
* [slash] Unit test correctly checks case of validator own stake which could drop below 1 ONE in slashing
* [config] add double-sign testnet config (#1)
Signed-off-by: Leo Chen <leo@harmony.one>
* [slash] Commit for as is code & data of current dump.json
* [slash] Order of state operation not correct in test, hence bad results, thank you dlv
* [slash] Add snapshot state dump
* [slash] Pay off slash of validator own delegation correctly
* [slash] Pay off slash debt with special case for min-self
* [slash] Pass first scenario conclusively
* [slash] 2% slash passes unit test for own delegation and external
* [slash] Parameterize unit test to easily test .02 vs .80 slash
* [slash] Handle own delegation correctly at 80% slash
* [slash] Have 80% slash working with external delegator
* [slash] Remove debug code from slash
* [slash] Adjust Apply signature, test again for 2% slash
* [slash] Factor out scenario in testing so can test 2% and 80% at same time
* [slash] Correct balance deduction on plan delegation
* [slash] Mock out ChainReader for TestVerify
* [slash] Small surface area interface, now feedback loop for verify
* [slash] Remove development json
* [slash] trigger-double-sign consumes yaml
* [slash] Remove dead code
* [slash][test] Factor ValidatorWrapper into scenario
* [slash][test] Add example from local-testing dump - caution might be off
* [slash] Factor out mutation of slashDebt
* [slash][test] Factor out tests so can easily load test-case from bytes
* [slash] Fix payment mistake in validator own delegation wrt min-self-delgation respected
* [slash] Satisfy Travis
* [slash] Begin cleanup of PR
* [slash] Apply slash from header to Finalize via state processor
* [slash] Productionize code, Println => logs; adjust slash picked in newblock
* [slash] Need pointer for rlp.Decode
* [slash] ValidatorInformation use full wrapper
* Fix median stake
* [staking] Adjust MarshalJSON for Validator, Wrapper
* Refactor offchain data commit; Make block onchain/offchain commit atomic (#2279)
* Refactor offchain data; Add epoch to ValidatorSnapshot
* Make block onchain/offchain data commit atomically
* [slash][committee] Set .Active to false on double sign, do not consider banned or inactive for committee assignment
* [effective] VC eligible.go
* [consensus] Redundant field in printf
* [docker] import-ks for a dev account
* [slash] Create BLS key for dockerfile and crt-validator.sh
* [slash][docker] Easy deployment of double-sign testing
* [docker] Have slash work as single docker command
* [rpc] Fix median-stake RPC
* [slash] Update webhook with default docker BLS key
* [docker][slash] Fresh yaml copy for docker build, remove dev code in main.go
* [slash] Remove helper binary, commented out code, change to local config
* [params] Factor out test genesis value
* Add shard checking to Tx-Pool & correct blacklist (#2301)
* [core] Fix blacklist & add shardID check
* [staking + node + cmd] Fix blacklist & add shardID check
* [slash] Adjust to PR comments part 1
* [docker] Use different throw away funded account
* [docker] Create easier testing for delegation with private keys
* [docker] Update yaml
* [slash] Remove special case for slashing validator own delegation wrt min-self-delegate
* [docker] Install nano as well
* [slash] Early error if banned
* [quorum] Expose earning account in decider marshal json
* Revert "Refactor offchain data commit; Make block onchain/offchain commit atomic (#2279)"
This reverts commit
|
5 years ago |
|
Daniel Van Der Maden
|
376178a91e
|
Abstract transactions in tx pool and add staking transaction to pool with error report (#2236)
* [core] Add tx-pool txn interface & update supporting components * Add txn interface (`PoolTransaction`) for tx-pool * Update tx_journal to handle pool's txn interface * Update tx_list to handle pool's txn interface * [staking] Satisfy `PoolTransaction` interface & move error sink types * Implement `Protected`, `ToShardID`, `To`, `Data`, `Value` and `Size` for `StakingTransaction` to satisfy `PoolTransaction` interface * Refactor `Price` to `GasPrice` for `StakingTransaction` to satisfy `PoolTransaction` interface * Move error sink related components to transaction.go * Expose `VerifyBLSKey` and `VerifyBLSKeys` * [core] Generalize tx pool & refactor error sink logic * Refactor txn logic to use `PoolTransaction` and `PoolTransactions` * Add `txPoolErrorReporter` to handle reporting to plainTx and stakingTx error sinks * Remove old & unpayable txs error reports (to error sink) since errs are already reported when adding the txs * Fix known transaction error report when adding txn batches * Add error sink reporting when failed to enqueue txs * [node] Fix error sink & update tx pool interaction * Integrate staking transaction in tx-pool * Remove staking transaction error sink * [hmy api] Integrate staking transactions from tx pool * Remove looking at tx pool for `GetTransactionByHash` * Add `PendingStakingTransactions` and update `PendingTransactions` to only return plainTx * [tests] Update all tests for tx pool txn interface & staking err sink * Update transactions to `PoolTransaction` interface * Remove `CommitTransactions` staking txn error sink * Add basic staking txn tests to tx pool tests * [node] Make all node broadcast staking tx and plain tx * [core + staking] Separate staking msg check and put in tx pool * Move `Validator` specific sanity check into its own method and call said method in `ValidatorWrapper` sanity check * Create staking msg verifiers and preprocessors in `staking_verifier.go` * Remove staking msg verification on all staking msg applications in `state_transition.go` and call new staking msg verifiers & preprocessors * Add staking msg verification to tx pool * Remove `ToShardID` from `PoolTransaction` interface and remove trivial implementation of `ToShardID` in `StakingTransaction` |
5 years ago |
|
Edgar Aroutiounian
|
801b4b83e2
|
[slash][consensus] Notice double sign & broadcast, factor out tech debt of consensus (#2152)
* [slash] Remove dead interface, associated piping * [slash] Expand out structs * [consensus] Write to a chan when find a case of double-signing, remove dead code * [slash] Broadcast the noticing of a double signing * [rawdb] CRUD for slashing candidates * [slashing][node][proto] Broadcast the slash record after receive from consensus, handle received proto message, persist in off-chain db while pending * [slash][node][propose-block] Add verified slashes proposed into the header in block proposal * [slash][shard] Factor out external validator as method on shard state, add double-signature field * [slash][engine] Apply slash, name boolean expression for sorts, use stable sort * [slash] Abstract Ballot results so keep track of both pre and post double sign event * [slash] Fix type errors on test code * [slash] Read from correct rawdb * [slash] Add epoch based guards in CRUD of slashing * [slash] Write to correct cache for slashing candidates * [shard] Use explicit named type of BLS Signature, use convention * [slash] Fix mistake done in refactor, improper header used. Factor out fromSlice to set * [slash][node] Restore newblock to master, try again minimial change * [cx-receipts] Break up one-liner, use SliceStable, not Slice * [network] Finish refactor that makes network message headers once * [network] Simplify creation further of headers write * [slash] Adjust data structure of slash after offline discussion with RJ, Chao * [slash] Still did need signature of the double signature * [consensus] Prepare message does not have block header * [consensus] Soft reset three files to 968517d~1 * [consensus] Begin factor consensus network intended message out with prepare first * [consensus] Factor out Prepared message * [consensus] Factor out announce message creation * [consensus] Committed Message, branch on verify sender key for clearer log * [consensus] Committed Message Factor out * [consensus] Do jenkins MVP of signatures adjustment * [main][slash] Provide YAML config as webhook config for double sign event * [consensus] Adjust signatures, whitespace, lessen GC pressure * [consensus] Remove dead code * [consensus] Factor out commit overloaded message, give commit payload override in construct * [consensus] Fix travis tests * [consensus] Provide block bytes in SubmitVote(quorum.Commit) * [consensus] Factor out noisy sanity checks in BFT, move existing commit check earlier as was before * [quorum] Adjust signatures in quorum * [staking] Adjust after merge from master * [consensus] Finish refactor of consensus * [node] Fix import * [consensus] Fix travis * [consensus] Use origin/master copy of block, fix mistake of pointer to empty byte * [consensus] Less verbose bools * [consensus] Remove unused trailing mutation hook in message construct * [consensus] Address some TODOs on err, comment out double sign |
5 years ago |
Daniel Van Der Maden
|
9fe8792c02 |
Report failed (non-staking) transactions (#2160)
* [node/worker] Remove regular txn error sink * [tests] Remove error sink fn field * [core/types] Add `NewRPCTransactionError` fn * [core] Report failed txs from tx_pool via error sink & wrap errs with useful msgs * [core/test] Update tests for tx_pool error sink * [node] Make all nodes record txs & add tx error sink RPC callback to `NewTxPool` Co-authored-by: Edgar Aroutiounian <edgar.factorial@gmail.com> |
5 years ago |
|
Edgar Aroutiounian
|
868c4c896c
|
Extend failure sink (#2045)
* [project] Rename specs to specifications b/c gcc thinks specs is a special file * [rpc][node] Refactor failed stking txn buffer as container/ring, track failed plain txn as well * [rpc] Expose RPC for staking, plain txn error sink |
5 years ago |
|
Edgar Aroutiounian
|
b995bb02f2
|
[rpc][staking] Quick way to add an staking transaction error sink for… (#1986)
* [rpc][staking] Quick way to add an staking transaction error sink for rpc consumption * [staking] Satisfy Travis * [rpc][staking] Expose staking transaction errors using slice, protect mutex * [staking][rpc] Use string name of Directive * [staking][rpc] Change func signature in tests * [staking][rpc] Protect read with lock |
5 years ago |
chao
|
44a8e2a376 |
add shardState verification
|
5 years ago |