const assert = require ( 'assert' )
const webdriver = require ( 'selenium-webdriver' )
const { By , Key , until } = webdriver
const {
delay ,
} = require ( './func' )
const {
assertElementNotPresent ,
checkBrowserForConsoleErrors ,
closeAllWindowHandlesExcept ,
findElement ,
findElements ,
openNewPage ,
switchToWindowWithTitle ,
verboseReportOnFailure ,
waitUntilXWindowHandles ,
setupFetchMocking ,
prepareExtensionForTesting ,
} = require ( './helpers' )
const enLocaleMessages = require ( '../../app/_locales/en/messages.json' )
describe ( 'MetaMask' , function ( ) {
let driver
let tokenAddress
const testSeedPhrase = 'phrase upgrade clock rough situate wedding elder clever doctor stamp excess tent'
const tinyDelayMs = 200
const regularDelayMs = tinyDelayMs * 2
const largeDelayMs = regularDelayMs * 2
this . timeout ( 0 )
this . bail ( true )
before ( async function ( ) {
const result = await prepareExtensionForTesting ( )
driver = result . driver
await setupFetchMocking ( driver )
} )
afterEach ( async function ( ) {
if ( process . env . SELENIUM _BROWSER === 'chrome' ) {
const errors = await checkBrowserForConsoleErrors ( driver )
if ( errors . length ) {
const errorReports = errors . map ( err => err . message )
const errorMessage = ` Errors found in browser console: \n ${ errorReports . join ( '\n' ) } `
console . error ( new Error ( errorMessage ) )
}
}
if ( this . currentTest . state === 'failed' ) {
await verboseReportOnFailure ( driver , this . currentTest )
}
} )
after ( async function ( ) {
await driver . quit ( )
} )
describe ( 'Going through the first time flow' , ( ) => {
it ( 'clicks the continue button on the welcome screen' , async ( ) => {
await findElement ( driver , By . css ( '.welcome-page__header' ) )
const welcomeScreenBtn = await findElement ( driver , By . xpath ( ` //button[contains(text(), ' ${ enLocaleMessages . getStarted . message } ')] ` ) )
welcomeScreenBtn . click ( )
await delay ( largeDelayMs )
} )
it ( 'clicks the "Create New Wallet" option' , async ( ) => {
const customRpcButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Create a Wallet')] ` ) )
customRpcButton . click ( )
await delay ( largeDelayMs )
} )
it ( 'clicks the "No thanks" option on the metametrics opt-in screen' , async ( ) => {
const optOutButton = await findElement ( driver , By . css ( '.btn-default' ) )
optOutButton . click ( )
await delay ( largeDelayMs )
} )
it ( 'accepts a secure password' , async ( ) => {
const passwordBox = await findElement ( driver , By . css ( '.first-time-flow__form #create-password' ) )
const passwordBoxConfirm = await findElement ( driver , By . css ( '.first-time-flow__form #confirm-password' ) )
const button = await findElement ( driver , By . css ( '.first-time-flow__form button' ) )
await passwordBox . sendKeys ( 'correct horse battery staple' )
await passwordBoxConfirm . sendKeys ( 'correct horse battery staple' )
const tosCheckBox = await findElement ( driver , By . css ( '.first-time-flow__checkbox' ) )
await tosCheckBox . click ( )
await button . click ( )
await delay ( regularDelayMs )
} )
let seedPhrase
it ( 'reveals the seed phrase' , async ( ) => {
const byRevealButton = By . css ( '.reveal-seed-phrase__secret-blocker .reveal-seed-phrase__reveal-button' )
await driver . wait ( until . elementLocated ( byRevealButton , 10000 ) )
const revealSeedPhraseButton = await findElement ( driver , byRevealButton , 10000 )
await revealSeedPhraseButton . click ( )
await delay ( regularDelayMs )
seedPhrase = await driver . findElement ( By . css ( '.reveal-seed-phrase__secret-words' ) ) . getText ( )
assert . equal ( seedPhrase . split ( ' ' ) . length , 12 )
await delay ( regularDelayMs )
const nextScreen = await findElement ( driver , By . xpath ( ` //button[contains(text(), ' ${ enLocaleMessages . next . message } ')] ` ) )
await nextScreen . click ( )
await delay ( regularDelayMs )
} )
async function clickWordAndWait ( word ) {
const xpath = ` //div[contains(@class, 'confirm-seed-phrase__seed-word--shuffled') and not(contains(@class, 'confirm-seed-phrase__seed-word--selected')) and contains(text(), ' ${ word } ')] `
const word0 = await findElement ( driver , By . xpath ( xpath ) , 10000 )
await word0 . click ( )
await delay ( tinyDelayMs )
}
it ( 'can retype the seed phrase' , async ( ) => {
const words = seedPhrase . split ( ' ' )
for ( const word of words ) {
await clickWordAndWait ( word )
}
const confirm = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirm . click ( )
await delay ( regularDelayMs )
} )
it ( 'clicks through the success screen' , async ( ) => {
await findElement ( driver , By . xpath ( ` //div[contains(text(), 'Congratulations')] ` ) )
const doneButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), ' ${ enLocaleMessages . endOfFlowMessage10 . message } ')] ` ) )
await doneButton . click ( )
await delay ( regularDelayMs )
} )
} )
describe ( 'Show account information' , ( ) => {
it ( 'shows the QR code for the account' , async ( ) => {
await driver . findElement ( By . css ( '.account-details__details-button' ) ) . click ( )
await driver . findElement ( By . css ( '.qr-wrapper' ) ) . isDisplayed ( )
await delay ( regularDelayMs )
const accountModal = await driver . findElement ( By . css ( 'span .modal' ) )
await driver . executeScript ( "document.querySelector('.account-modal-close').click()" )
await driver . wait ( until . stalenessOf ( accountModal ) )
await delay ( regularDelayMs )
} )
} )
describe ( 'Log out an log back in' , ( ) => {
it ( 'logs out of the account' , async ( ) => {
await driver . findElement ( By . css ( '.account-menu__icon' ) ) . click ( )
await delay ( regularDelayMs )
const logoutButton = await findElement ( driver , By . css ( '.account-menu__logout-button' ) )
assert . equal ( await logoutButton . getText ( ) , 'Log out' )
await logoutButton . click ( )
await delay ( regularDelayMs )
} )
it ( 'accepts the account password after lock' , async ( ) => {
await driver . findElement ( By . id ( 'password' ) ) . sendKeys ( 'correct horse battery staple' )
await driver . findElement ( By . id ( 'password' ) ) . sendKeys ( Key . ENTER )
await delay ( largeDelayMs * 4 )
} )
} )
describe ( 'Add account' , ( ) => {
it ( 'choose Create Account from the account menu' , async ( ) => {
await driver . findElement ( By . css ( '.account-menu__icon' ) ) . click ( )
await delay ( regularDelayMs )
const createAccount = await findElement ( driver , By . xpath ( ` //div[contains(text(), 'Create Account')] ` ) )
await createAccount . click ( )
await delay ( regularDelayMs )
} )
it ( 'set account name' , async ( ) => {
const accountName = await findElement ( driver , By . css ( '.new-account-create-form input' ) )
await accountName . sendKeys ( '2nd account' )
await delay ( regularDelayMs )
const create = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Create')] ` ) )
await create . click ( )
await delay ( largeDelayMs )
} )
it ( 'should display correct account name' , async ( ) => {
const accountName = await findElement ( driver , By . css ( '.account-details__account-name' ) )
assert . equal ( await accountName . getText ( ) , '2nd account' )
await delay ( regularDelayMs )
} )
} )
describe ( 'Import seed phrase' , ( ) => {
it ( 'logs out of the vault' , async ( ) => {
await driver . findElement ( By . css ( '.account-menu__icon' ) ) . click ( )
await delay ( regularDelayMs )
const logoutButton = await findElement ( driver , By . css ( '.account-menu__logout-button' ) )
assert . equal ( await logoutButton . getText ( ) , 'Log out' )
await logoutButton . click ( )
await delay ( regularDelayMs )
} )
it ( 'imports seed phrase' , async ( ) => {
const restoreSeedLink = await findElement ( driver , By . css ( '.unlock-page__link--import' ) )
assert . equal ( await restoreSeedLink . getText ( ) , 'Import using account seed phrase' )
await restoreSeedLink . click ( )
await delay ( regularDelayMs )
const seedTextArea = await findElement ( driver , By . css ( 'textarea' ) )
await seedTextArea . sendKeys ( testSeedPhrase )
await delay ( regularDelayMs )
const passwordInputs = await driver . findElements ( By . css ( 'input' ) )
await delay ( regularDelayMs )
await passwordInputs [ 0 ] . sendKeys ( 'correct horse battery staple' )
await passwordInputs [ 1 ] . sendKeys ( 'correct horse battery staple' )
await driver . findElement ( By . xpath ( ` //button[contains(text(), ' ${ enLocaleMessages . restore . message } ')] ` ) ) . click ( )
await delay ( regularDelayMs )
} )
it ( 'balance renders' , async ( ) => {
const balance = await findElement ( driver , By . css ( '.balance-display .token-amount' ) )
await driver . wait ( until . elementTextMatches ( balance , /100\s*ETH/ ) )
await delay ( regularDelayMs )
} )
} )
describe ( 'Send ETH from inside MetaMask using default gas' , ( ) => {
it ( 'starts a send transaction' , async function ( ) {
const sendButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Send')] ` ) )
await sendButton . click ( )
await delay ( regularDelayMs )
const inputAddress = await findElement ( driver , By . css ( 'input[placeholder="Search, public address (0x), or ENS"]' ) )
await inputAddress . sendKeys ( '0x2f318C334780961FB129D2a6c30D0763d9a5C970' )
const inputAmount = await findElement ( driver , By . css ( '.unit-input__input' ) )
await inputAmount . sendKeys ( '1000' )
const errorAmount = await findElement ( driver , By . css ( '.send-v2__error-amount' ) )
assert . equal ( await errorAmount . getText ( ) , 'Insufficient funds.' , 'send screen should render an insufficient fund error message' )
await inputAmount . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await inputAmount . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await inputAmount . sendKeys ( Key . BACK _SPACE )
await delay ( tinyDelayMs )
await assertElementNotPresent ( webdriver , driver , By . css ( '.send-v2__error-amount' ) )
const amountMax = await findElement ( driver , By . css ( '.send-v2__amount-max' ) )
await amountMax . click ( )
assert . equal ( await inputAmount . isEnabled ( ) , false )
let inputValue = await inputAmount . getAttribute ( 'value' )
assert ( Number ( inputValue ) > 99 )
await amountMax . click ( )
assert . equal ( await inputAmount . isEnabled ( ) , true )
await inputAmount . sendKeys ( '1' )
inputValue = await inputAmount . getAttribute ( 'value' )
assert . equal ( inputValue , '1' )
await delay ( regularDelayMs )
// Continue to next screen
const nextScreen = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Next')] ` ) )
await nextScreen . click ( )
await delay ( regularDelayMs )
} )
it ( 'confirms the transaction' , async function ( ) {
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( largeDelayMs * 2 )
} )
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 1
} , 10000 )
const txValues = await findElement ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues , /-1\s*ETH/ ) , 10000 )
} )
} )
describe ( 'Send ETH from inside MetaMask using fast gas option' , ( ) => {
it ( 'starts a send transaction' , async function ( ) {
const sendButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Send')] ` ) )
await sendButton . click ( )
await delay ( regularDelayMs )
const inputAddress = await findElement ( driver , By . css ( 'input[placeholder="Search, public address (0x), or ENS"]' ) )
await inputAddress . sendKeys ( '0x2f318C334780961FB129D2a6c30D0763d9a5C970' )
const inputAmount = await findElement ( driver , By . css ( '.unit-input__input' ) )
await inputAmount . sendKeys ( '1' )
const inputValue = await inputAmount . getAttribute ( 'value' )
assert . equal ( inputValue , '1' )
// Set the gas price
const fastGas = await findElement ( driver , By . xpath ( ` //button/div/div[contains(text(), "Fast")] ` ) )
await fastGas . click ( )
await delay ( regularDelayMs )
// Continue to next screen
const nextScreen = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Next')] ` ) )
await nextScreen . click ( )
await delay ( regularDelayMs )
} )
it ( 'confirms the transaction' , async function ( ) {
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( largeDelayMs )
} )
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 2
} , 10000 )
const txValues = await findElement ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues , /-1\s*ETH/ ) , 10000 )
} )
} )
describe ( 'Send ETH from inside MetaMask using advanced gas modal' , ( ) => {
it ( 'starts a send transaction' , async function ( ) {
const sendButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Send')] ` ) )
await sendButton . click ( )
await delay ( regularDelayMs )
const inputAddress = await findElement ( driver , By . css ( 'input[placeholder="Search, public address (0x), or ENS"]' ) )
await inputAddress . sendKeys ( '0x2f318C334780961FB129D2a6c30D0763d9a5C970' )
const inputAmount = await findElement ( driver , By . css ( '.unit-input__input' ) )
await inputAmount . sendKeys ( '1' )
const inputValue = await inputAmount . getAttribute ( 'value' )
assert . equal ( inputValue , '1' )
// Set the gas limit
const configureGas = await findElement ( driver , By . css ( '.advanced-gas-options-btn' ) )
await configureGas . click ( )
await delay ( regularDelayMs )
const gasModal = await driver . findElement ( By . css ( 'span .modal' ) )
const save = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Save')] ` ) )
await save . click ( )
await driver . wait ( until . stalenessOf ( gasModal ) )
await delay ( regularDelayMs )
// Continue to next screen
const nextScreen = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Next')] ` ) )
await nextScreen . click ( )
await delay ( regularDelayMs )
} )
it ( 'confirms the transaction' , async function ( ) {
const transactionAmounts = await findElements ( driver , By . css ( '.currency-display-component__text' ) )
const transactionAmount = transactionAmounts [ 0 ]
assert . equal ( await transactionAmount . getText ( ) , '1' )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( largeDelayMs )
} )
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 3
} , 10000 )
const txValues = await findElement ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues , /-1\s*ETH/ ) , 10000 )
} )
} )
describe ( 'Send ETH from dapp using advanced gas controls' , ( ) => {
let windowHandles
let extension
let popup
let dapp
it ( 'goes to the settings screen' , async ( ) => {
await driver . findElement ( By . css ( '.account-menu__icon' ) ) . click ( )
await delay ( regularDelayMs )
const settingsButton = await findElement ( driver , By . xpath ( ` //div[contains(text(), 'Settings')] ` ) )
settingsButton . click ( )
// await findElement(driver, By.css('.tab-bar'))
const advancedTab = await findElement ( driver , By . xpath ( ` //div[contains(text(), 'Advanced')] ` ) )
await advancedTab . click ( )
await delay ( regularDelayMs )
const showConversionToggle = await findElement ( driver , By . css ( '.settings-page__content-row:nth-of-type(6) .settings-page__content-item-col > div > div' ) )
await showConversionToggle . click ( )
const advancedGasTitle = await findElement ( driver , By . xpath ( ` //span[contains(text(), 'Advanced gas controls')] ` ) )
await driver . executeScript ( 'arguments[0].scrollIntoView(true)' , advancedGasTitle )
const advancedGasToggle = await findElement ( driver , By . css ( '.settings-page__content-row:nth-of-type(4) .settings-page__content-item-col > div > div' ) )
await advancedGasToggle . click ( )
windowHandles = await driver . getAllWindowHandles ( )
extension = windowHandles [ 0 ]
await closeAllWindowHandlesExcept ( driver , [ extension ] )
const metamaskHomeButton = await findElement ( driver , By . css ( '.app-header__logo-container' ) )
await metamaskHomeButton . click ( )
await delay ( largeDelayMs )
} )
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
it ( 'connects the dapp' , async ( ) => {
await openNewPage ( driver , 'http://127.0.0.1:8080/' )
await delay ( regularDelayMs )
const connectButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Connect')] ` ) )
await connectButton . click ( )
await delay ( regularDelayMs )
await waitUntilXWindowHandles ( driver , 3 )
windowHandles = await driver . getAllWindowHandles ( )
extension = windowHandles [ 0 ]
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
dapp = await switchToWindowWithTitle ( driver , 'E2E Test Dapp' , windowHandles )
popup = windowHandles . find ( handle => handle !== extension && handle !== dapp )
await driver . switchTo ( ) . window ( popup )
await delay ( regularDelayMs )
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
const accountButton = await findElement ( driver , By . css ( '.permissions-connect-choose-account__account' ) )
await accountButton . click ( )
const submitButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Submit')] ` ) )
await submitButton . click ( )
await waitUntilXWindowHandles ( driver , 2 )
await driver . switchTo ( ) . window ( dapp )
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
await delay ( regularDelayMs )
} )
it ( 'initiates a send from the dapp' , async ( ) => {
const send3eth = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Send')] ` ) , 10000 )
await send3eth . click ( )
await delay ( 2000 )
windowHandles = await driver . getAllWindowHandles ( )
await switchToWindowWithTitle ( driver , 'MetaMask Notification' , windowHandles )
await delay ( regularDelayMs )
await assertElementNotPresent ( webdriver , driver , By . xpath ( ` //li[contains(text(), 'Data')] ` ) )
const [ gasPriceInput , gasLimitInput ] = await findElements ( driver , By . css ( '.advanced-gas-inputs__gas-edit-row__input' ) )
await gasPriceInput . sendKeys ( Key . chord ( Key . CONTROL , 'a' ) )
await delay ( 50 )
await gasPriceInput . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await gasPriceInput . sendKeys ( '10' )
await delay ( 50 )
await delay ( tinyDelayMs )
await delay ( 50 )
await gasLimitInput . sendKeys ( Key . chord ( Key . CONTROL , 'a' ) )
await delay ( 50 )
await gasLimitInput . sendKeys ( '25000' )
Use `AdvancedGasInputs` in `AdvancedTabContent` (#7186)
* Use `AdvancedGasInputs` in `AdvancedTabContent`
The `AdvancedGasInputs` component was originally extracted from the
`AdvancedTabContent` component, duplicating much of the rendering
logic. They have since evolved separately, with bugs being fixed in one
place but not the other.
The inputs and outputs expected weren't exactly the same, as the
`AdvancedGasInputs` component converts the input custom gas price and
limit, and it converts them both in the setter methods as well.
The `GasModalPageContainer` had to be adjusted to avoid converting
these values multiple times.
Both components dealt with input debouncing separately, both in less
than ideal ways. `AdvancedTabContent` didn't debounce either field, but
it did debounce the check for whether the gas limit field was below the
minimum value. So if a less-than-minimum value was set, it would be
propogated upwards and could be saved if the user clicked 'Save'
quickly enough. After a second delay it would snap back to the minimum
value. The `AdvancedGasInputs` component debounced both fields, but
it would replace any gas limit below the minimum with the minimum
value. This led to a problem where a brief pause during typing would
reset the field to 21000.
The `AdvancedGasInputs` approach was chosen, except that it was
updated to no longer change the gas limit if it was below the minimum.
Instead it displays an error. Parent components were checked to ensure
they would detect the error case of the gas limit being set too low,
and prevent the form submission in those cases. Of the three parents,
one had already dealt with it correctly, one needed to convert the
gas limit from hex first, and another needed the gas limit check added.
Closes #6872
* Cleanup send components
Empty README files have been removed, and a mistake in the index file
for the send page has been corrected. The Gas Slider component class
name was updated as well; it looks like it was originally created from
`AdvancedTabContent`, so it still had that class name.
5 years ago
await delay ( 1000 )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) , 10000 )
await confirmButton . click ( )
await delay ( regularDelayMs )
await waitUntilXWindowHandles ( driver , 2 )
await driver . switchTo ( ) . window ( extension )
await delay ( regularDelayMs )
} )
let txValues
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 4
} , 10000 )
txValues = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues [ 0 ] , /-3\s*ETH/ ) , 10000 )
} )
it ( 'the transaction has the expected gas price' , async function ( ) {
await delay ( largeDelayMs )
let txGasPriceLabels
let txGasPrices
try {
await txValues [ 0 ] . click ( )
txGasPrices = await findElements ( driver , By . css ( '.transaction-breakdown__value' ) )
txGasPriceLabels = await findElements ( driver , By . css ( '.transaction-breakdown-row__title' ) )
txGasPrices = await findElements ( driver , By . css ( '.transaction-breakdown__value' ) )
await driver . wait ( until . elementTextMatches ( txGasPrices [ 3 ] , /^10$/ ) , 10000 )
} catch ( e ) {
console . log ( e . message )
txValues = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await txValues [ 0 ] . click ( )
txGasPriceLabels = await findElements ( driver , By . css ( '.transaction-breakdown-row__title' ) )
txGasPrices = await findElements ( driver , By . css ( '.transaction-breakdown__value' ) )
await driver . wait ( until . elementTextMatches ( txGasPrices [ 3 ] , /^10$/ ) , 10000 )
}
assert ( txGasPriceLabels [ 2 ] )
await txValues [ 0 ] . click ( )
} )
} )
describe ( 'Navigate transactions' , ( ) => {
it ( 'adds multiple transactions' , async ( ) => {
await delay ( regularDelayMs )
await waitUntilXWindowHandles ( driver , 2 )
const windowHandles = await driver . getAllWindowHandles ( )
const extension = windowHandles [ 0 ]
const dapp = windowHandles [ 1 ]
await driver . switchTo ( ) . window ( dapp )
await delay ( largeDelayMs )
const send3eth = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Send')] ` ) , 10000 )
await send3eth . click ( )
await delay ( largeDelayMs )
const contractDeployment = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Deploy Contract')] ` ) , 10000 )
await contractDeployment . click ( )
await delay ( largeDelayMs )
await send3eth . click ( )
await delay ( largeDelayMs )
await contractDeployment . click ( )
await delay ( largeDelayMs )
await driver . switchTo ( ) . window ( extension )
await delay ( regularDelayMs )
let transactions = await findElements ( driver , By . css ( '.transaction-list-item' ) )
await transactions [ 3 ] . click ( )
await delay ( regularDelayMs )
try {
transactions = await findElements ( driver , By . css ( '.transaction-list-item' ) , 1000 )
await transactions [ 3 ] . click ( )
} catch ( e ) {
console . log ( e )
}
await delay ( regularDelayMs )
} )
it ( 'navigates the transactions' , async ( ) => {
let navigateTxButtons = await findElements ( driver , By . css ( '.confirm-page-container-navigation__arrow' ) , 20000 )
assert . equal ( navigateTxButtons . length , 4 , 'navigation button present' )
await navigateTxButtons [ 2 ] . click ( )
let navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
let navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '2' ) , true , 'changed transaction right' )
navigateTxButtons = await findElements ( driver , By . css ( '.confirm-page-container-navigation__arrow' ) )
await navigateTxButtons [ 2 ] . click ( )
navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '3' ) , true , 'changed transaction right' )
navigateTxButtons = await findElements ( driver , By . css ( '.confirm-page-container-navigation__arrow' ) )
await navigateTxButtons [ 2 ] . click ( )
navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '4' ) , true , 'changed transaction right' )
navigateTxButtons = await findElements ( driver , By . css ( '.confirm-page-container-navigation__arrow' ) )
await navigateTxButtons [ 0 ] . click ( )
navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '1' ) , true , 'navigate to first transaction' )
navigateTxButtons = await findElements ( driver , By . css ( '.confirm-page-container-navigation__arrow' ) )
await navigateTxButtons [ 3 ] . click ( )
navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . split ( '4' ) . length , 3 , 'navigate to last transaction' )
navigateTxButtons = await findElements ( driver , By . css ( '.confirm-page-container-navigation__arrow' ) )
await navigateTxButtons [ 1 ] . click ( )
navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '3' ) , true , 'changed transaction left' )
navigateTxButtons = await findElements ( driver , By . css ( '.confirm-page-container-navigation__arrow' ) )
await navigateTxButtons [ 1 ] . click ( )
navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '2' ) , true , 'changed transaction left' )
} )
it ( 'adds a transaction while confirm screen is in focus' , async ( ) => {
let navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
let navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '2' ) , true , 'second transaction in focus' )
const windowHandles = await driver . getAllWindowHandles ( )
const extension = windowHandles [ 0 ]
const dapp = windowHandles [ 1 ]
await driver . switchTo ( ) . window ( dapp )
await delay ( regularDelayMs )
const send3eth = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Send')] ` ) , 10000 )
await send3eth . click ( )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( extension )
await delay ( regularDelayMs )
navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '3' ) , true , 'correct transaction in focus' )
} )
it ( 'confirms a transaction' , async ( ) => {
await delay ( tinyDelayMs )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) , 10000 )
await confirmButton . click ( )
await delay ( largeDelayMs * 2 )
const navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
await delay ( tinyDelayMs )
const navigationText = await navigationElement . getText ( )
assert . equal ( navigationText . includes ( '4' ) , true , 'transaction confirmed' )
} )
it ( 'rejects a transaction' , async ( ) => {
await delay ( tinyDelayMs / 2 )
const rejectButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Reject')] ` ) , 10000 )
await delay ( tinyDelayMs / 2 )
await rejectButton . click ( )
await delay ( regularDelayMs )
const navigationElement = await findElement ( driver , By . css ( '.confirm-page-container-navigation' ) )
await delay ( tinyDelayMs / 2 )
const navigationText = await navigationElement . getText ( )
await delay ( tinyDelayMs / 2 )
assert . equal ( navigationText . includes ( '3' ) , true , 'transaction rejected' )
} )
it ( 'rejects the rest of the transactions' , async ( ) => {
const rejectAllButton = await findElement ( driver , By . xpath ( ` //a[contains(text(), 'Reject 3')] ` ) , 10000 )
await rejectAllButton . click ( )
await delay ( regularDelayMs )
const rejectButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Reject All')] ` ) , 10000 )
await rejectButton . click ( )
await delay ( largeDelayMs * 2 )
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
assert . equal ( confirmedTxes . length , 5 , '5 transactions present' )
} )
} )
describe ( 'Deploy contract and call contract methods' , ( ) => {
let extension
let dapp
it ( 'creates a deploy contract transaction' , async ( ) => {
const windowHandles = await driver . getAllWindowHandles ( )
extension = windowHandles [ 0 ]
dapp = windowHandles [ 1 ]
await delay ( tinyDelayMs )
await driver . switchTo ( ) . window ( dapp )
await delay ( regularDelayMs )
const deployContractButton = await findElement ( driver , By . css ( '#deployButton' ) )
await deployContractButton . click ( )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( extension )
await delay ( regularDelayMs )
const txListItem = await findElement ( driver , By . xpath ( ` //div[contains(text(), 'Contract Deployment')] ` ) )
await txListItem . click ( )
await delay ( largeDelayMs )
} )
it ( 'displays the contract creation data' , async ( ) => {
const dataTab = await findElement ( driver , By . xpath ( ` //li[contains(text(), 'Data')] ` ) )
await dataTab . click ( )
await delay ( regularDelayMs )
await findElement ( driver , By . xpath ( ` //div[contains(text(), '127.0.0.1')] ` ) )
const confirmDataDiv = await findElement ( driver , By . css ( '.confirm-page-container-content__data-box' ) )
const confirmDataText = await confirmDataDiv . getText ( )
assert . equal ( confirmDataText . match ( /0x608060405234801561001057600080fd5b5033600160006101000a81548173ffffffffffffffffffffffffffffffffffffffff/ ) )
const detailsTab = await findElement ( driver , By . xpath ( ` //li[contains(text(), 'Details')] ` ) )
await detailsTab . click ( )
await delay ( regularDelayMs )
} )
it ( 'confirms a deploy contract transaction' , async ( ) => {
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( largeDelayMs )
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 6
} , 10000 )
const txAction = await findElements ( driver , By . css ( '.transaction-list-item__action' ) )
await driver . wait ( until . elementTextMatches ( txAction [ 0 ] , /Contract\sDeployment/ ) , 10000 )
await delay ( regularDelayMs )
} )
it ( 'calls and confirms a contract method where ETH is sent' , async ( ) => {
await driver . switchTo ( ) . window ( dapp )
await delay ( regularDelayMs )
let contractStatus = await findElement ( driver , By . css ( '#contractStatus' ) )
await driver . wait ( until . elementTextMatches ( contractStatus , /Deployed/ ) , 15000 )
const depositButton = await findElement ( driver , By . css ( '#depositButton' ) )
await depositButton . click ( )
await delay ( largeDelayMs )
contractStatus = await findElement ( driver , By . css ( '#contractStatus' ) )
await driver . wait ( until . elementTextMatches ( contractStatus , /Deposit\sinitiated/ ) , 10000 )
await driver . switchTo ( ) . window ( extension )
await delay ( largeDelayMs * 2 )
await findElements ( driver , By . css ( '.transaction-list-item' ) )
const [ txListValue ] = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txListValue , /-4\s*ETH/ ) , 10000 )
await txListValue . click ( )
await delay ( regularDelayMs )
// Set the gas limit
const configureGas = await findElement ( driver , By . css ( '.confirm-detail-row__header-text--edit' ) )
await configureGas . click ( )
await delay ( regularDelayMs )
const gasModal = await findElement ( driver , By . css ( 'span .modal' ) )
await delay ( regularDelayMs )
const modalTabs = await findElements ( driver , By . css ( '.page-container__tab' ) )
await modalTabs [ 1 ] . click ( )
await delay ( regularDelayMs )
Use `AdvancedGasInputs` in `AdvancedTabContent` (#7186)
* Use `AdvancedGasInputs` in `AdvancedTabContent`
The `AdvancedGasInputs` component was originally extracted from the
`AdvancedTabContent` component, duplicating much of the rendering
logic. They have since evolved separately, with bugs being fixed in one
place but not the other.
The inputs and outputs expected weren't exactly the same, as the
`AdvancedGasInputs` component converts the input custom gas price and
limit, and it converts them both in the setter methods as well.
The `GasModalPageContainer` had to be adjusted to avoid converting
these values multiple times.
Both components dealt with input debouncing separately, both in less
than ideal ways. `AdvancedTabContent` didn't debounce either field, but
it did debounce the check for whether the gas limit field was below the
minimum value. So if a less-than-minimum value was set, it would be
propogated upwards and could be saved if the user clicked 'Save'
quickly enough. After a second delay it would snap back to the minimum
value. The `AdvancedGasInputs` component debounced both fields, but
it would replace any gas limit below the minimum with the minimum
value. This led to a problem where a brief pause during typing would
reset the field to 21000.
The `AdvancedGasInputs` approach was chosen, except that it was
updated to no longer change the gas limit if it was below the minimum.
Instead it displays an error. Parent components were checked to ensure
they would detect the error case of the gas limit being set too low,
and prevent the form submission in those cases. Of the three parents,
one had already dealt with it correctly, one needed to convert the
gas limit from hex first, and another needed the gas limit check added.
Closes #6872
* Cleanup send components
Empty README files have been removed, and a mistake in the index file
for the send page has been corrected. The Gas Slider component class
name was updated as well; it looks like it was originally created from
`AdvancedTabContent`, so it still had that class name.
5 years ago
const [ gasPriceInput , gasLimitInput ] = await findElements ( driver , By . css ( '.advanced-gas-inputs__gas-edit-row__input' ) )
const gasLimitValue = await gasLimitInput . getAttribute ( 'value' )
assert ( Number ( gasLimitValue ) < 100000 , 'Gas Limit too high' )
await gasPriceInput . sendKeys ( Key . chord ( Key . CONTROL , 'a' ) )
await delay ( 50 )
await gasPriceInput . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await gasPriceInput . sendKeys ( '10' )
await delay ( 50 )
await gasLimitInput . sendKeys ( Key . chord ( Key . CONTROL , 'a' ) )
await delay ( 50 )
await gasLimitInput . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await gasLimitInput . sendKeys ( '60001' )
Use `AdvancedGasInputs` in `AdvancedTabContent` (#7186)
* Use `AdvancedGasInputs` in `AdvancedTabContent`
The `AdvancedGasInputs` component was originally extracted from the
`AdvancedTabContent` component, duplicating much of the rendering
logic. They have since evolved separately, with bugs being fixed in one
place but not the other.
The inputs and outputs expected weren't exactly the same, as the
`AdvancedGasInputs` component converts the input custom gas price and
limit, and it converts them both in the setter methods as well.
The `GasModalPageContainer` had to be adjusted to avoid converting
these values multiple times.
Both components dealt with input debouncing separately, both in less
than ideal ways. `AdvancedTabContent` didn't debounce either field, but
it did debounce the check for whether the gas limit field was below the
minimum value. So if a less-than-minimum value was set, it would be
propogated upwards and could be saved if the user clicked 'Save'
quickly enough. After a second delay it would snap back to the minimum
value. The `AdvancedGasInputs` component debounced both fields, but
it would replace any gas limit below the minimum with the minimum
value. This led to a problem where a brief pause during typing would
reset the field to 21000.
The `AdvancedGasInputs` approach was chosen, except that it was
updated to no longer change the gas limit if it was below the minimum.
Instead it displays an error. Parent components were checked to ensure
they would detect the error case of the gas limit being set too low,
and prevent the form submission in those cases. Of the three parents,
one had already dealt with it correctly, one needed to convert the
gas limit from hex first, and another needed the gas limit check added.
Closes #6872
* Cleanup send components
Empty README files have been removed, and a mistake in the index file
for the send page has been corrected. The Gas Slider component class
name was updated as well; it looks like it was originally created from
`AdvancedTabContent`, so it still had that class name.
5 years ago
await delay ( 1000 )
const save = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Save')] ` ) )
await save . click ( )
await delay ( regularDelayMs )
await driver . wait ( until . stalenessOf ( gasModal ) )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( regularDelayMs )
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 7
} , 10000 )
const txValues = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues [ 0 ] , /-4\s*ETH/ ) , 10000 )
// const txAccounts = await findElements(driver, By.css('.tx-list-account'))
// const firstTxAddress = await txAccounts[0].getText()
// assert(firstTxAddress.match(/^0x\w{8}\.{3}\w{4}$/))
} )
it ( 'calls and confirms a contract method where ETH is received' , async ( ) => {
await driver . switchTo ( ) . window ( dapp )
await delay ( regularDelayMs )
const withdrawButton = await findElement ( driver , By . css ( '#withdrawButton' ) )
await withdrawButton . click ( )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( extension )
await delay ( largeDelayMs * 2 )
const txListItem = await findElement ( driver , By . css ( '.transaction-list-item' ) )
await txListItem . click ( )
await delay ( regularDelayMs )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( regularDelayMs )
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 8
} , 10000 )
const txValues = await findElement ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues , /-0\s*ETH/ ) , 10000 )
await closeAllWindowHandlesExcept ( driver , [ extension , dapp ] )
await driver . switchTo ( ) . window ( extension )
} )
it ( 'renders the correct ETH balance' , async ( ) => {
const balance = await findElement ( driver , By . css ( '.transaction-view-balance__primary-balance' ) )
await delay ( regularDelayMs )
await driver . wait ( until . elementTextMatches ( balance , /^87.*\s*ETH.*$/ ) , 10000 )
const tokenAmount = await balance . getText ( )
assert . ok ( /^87.*\s*ETH.*$/ . test ( tokenAmount ) )
await delay ( regularDelayMs )
} )
} )
describe ( 'Add a custom token from a dapp' , ( ) => {
it ( 'creates a new token' , async ( ) => {
let windowHandles = await driver . getAllWindowHandles ( )
const extension = windowHandles [ 0 ]
const dapp = windowHandles [ 1 ]
await delay ( regularDelayMs * 2 )
await driver . switchTo ( ) . window ( dapp )
await delay ( regularDelayMs * 2 )
const createToken = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Create Token')] ` ) )
await createToken . click ( )
await delay ( largeDelayMs )
windowHandles = await driver . getAllWindowHandles ( )
const popup = windowHandles [ 2 ]
await driver . switchTo ( ) . window ( popup )
await delay ( regularDelayMs )
const configureGas = await driver . wait ( until . elementLocated ( By . css ( '.confirm-detail-row__header-text--edit' ) ) , 10000 )
await configureGas . click ( )
await delay ( regularDelayMs )
const advancedTabButton = await driver . wait ( until . elementLocated ( By . xpath ( ` //li[contains(text(), 'Advanced')] ` ) ) , 10000 )
await advancedTabButton . click ( )
await delay ( tinyDelayMs )
Use `AdvancedGasInputs` in `AdvancedTabContent` (#7186)
* Use `AdvancedGasInputs` in `AdvancedTabContent`
The `AdvancedGasInputs` component was originally extracted from the
`AdvancedTabContent` component, duplicating much of the rendering
logic. They have since evolved separately, with bugs being fixed in one
place but not the other.
The inputs and outputs expected weren't exactly the same, as the
`AdvancedGasInputs` component converts the input custom gas price and
limit, and it converts them both in the setter methods as well.
The `GasModalPageContainer` had to be adjusted to avoid converting
these values multiple times.
Both components dealt with input debouncing separately, both in less
than ideal ways. `AdvancedTabContent` didn't debounce either field, but
it did debounce the check for whether the gas limit field was below the
minimum value. So if a less-than-minimum value was set, it would be
propogated upwards and could be saved if the user clicked 'Save'
quickly enough. After a second delay it would snap back to the minimum
value. The `AdvancedGasInputs` component debounced both fields, but
it would replace any gas limit below the minimum with the minimum
value. This led to a problem where a brief pause during typing would
reset the field to 21000.
The `AdvancedGasInputs` approach was chosen, except that it was
updated to no longer change the gas limit if it was below the minimum.
Instead it displays an error. Parent components were checked to ensure
they would detect the error case of the gas limit being set too low,
and prevent the form submission in those cases. Of the three parents,
one had already dealt with it correctly, one needed to convert the
gas limit from hex first, and another needed the gas limit check added.
Closes #6872
* Cleanup send components
Empty README files have been removed, and a mistake in the index file
for the send page has been corrected. The Gas Slider component class
name was updated as well; it looks like it was originally created from
`AdvancedTabContent`, so it still had that class name.
5 years ago
const [ gasPriceInput , gasLimitInput ] = await findElements ( driver , By . css ( '.advanced-gas-inputs__gas-edit-row__input' ) )
assert ( gasPriceInput . getAttribute ( 'value' ) , 20 )
assert ( gasLimitInput . getAttribute ( 'value' ) , 4700000 )
const saveButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Save')] ` ) )
await saveButton . click ( )
await delay ( regularDelayMs )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( dapp )
await delay ( tinyDelayMs )
const tokenContractAddress = await driver . findElement ( By . css ( '#tokenAddress' ) )
await driver . wait ( until . elementTextMatches ( tokenContractAddress , /0x/ ) )
tokenAddress = await tokenContractAddress . getText ( )
await delay ( regularDelayMs )
await closeAllWindowHandlesExcept ( driver , [ extension , dapp ] )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( extension )
await delay ( largeDelayMs )
} )
it ( 'clicks on the Add Token button' , async ( ) => {
const addToken = await driver . findElement ( By . xpath ( ` //div[contains(text(), 'Add Token')] ` ) )
await addToken . click ( )
await delay ( regularDelayMs )
} )
it ( 'picks the newly created Test token' , async ( ) => {
const addCustomToken = await findElement ( driver , By . xpath ( "//li[contains(text(), 'Custom Token')]" ) )
await addCustomToken . click ( )
await delay ( regularDelayMs )
const newTokenAddress = await findElement ( driver , By . css ( '#custom-address' ) )
await newTokenAddress . sendKeys ( tokenAddress )
await delay ( regularDelayMs )
const nextScreen = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Next')] ` ) )
await nextScreen . click ( )
await delay ( regularDelayMs )
const addTokens = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Add Tokens')] ` ) )
await addTokens . click ( )
await delay ( regularDelayMs )
} )
it ( 'renders the balance for the new token' , async ( ) => {
const balance = await findElement ( driver , By . css ( '.transaction-view-balance .transaction-view-balance__primary-balance' ) )
await driver . wait ( until . elementTextMatches ( balance , /^10.000\s*TST\s*$/ ) )
const tokenAmount = await balance . getText ( )
assert . ok ( /^10.000\s*TST\s*$/ . test ( tokenAmount ) )
await delay ( regularDelayMs )
} )
} )
describe ( 'Send token from inside MetaMask' , ( ) => {
let gasModal
it ( 'starts to send a transaction' , async function ( ) {
const sendButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Send')] ` ) )
await sendButton . click ( )
await delay ( regularDelayMs )
const inputAddress = await findElement ( driver , By . css ( 'input[placeholder="Search, public address (0x), or ENS"]' ) )
await inputAddress . sendKeys ( '0x2f318C334780961FB129D2a6c30D0763d9a5C970' )
const inputAmount = await findElement ( driver , By . css ( '.unit-input__input' ) )
await inputAmount . sendKeys ( '1' )
// Set the gas limit
const configureGas = await findElement ( driver , By . css ( '.advanced-gas-options-btn' ) )
await configureGas . click ( )
await delay ( regularDelayMs )
gasModal = await driver . findElement ( By . css ( 'span .modal' ) )
await delay ( regularDelayMs )
} )
it ( 'opens customize gas modal' , async ( ) => {
await driver . wait ( until . elementLocated ( By . css ( '.page-container__title' ) ) )
const save = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Save')] ` ) )
await save . click ( )
await delay ( regularDelayMs )
} )
it ( 'transitions to the confirm screen' , async ( ) => {
await driver . wait ( until . stalenessOf ( gasModal ) )
// Continue to next screen
const nextScreen = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Next')] ` ) )
await nextScreen . click ( )
await delay ( regularDelayMs )
} )
it ( 'displays the token transfer data' , async ( ) => {
const dataTab = await findElement ( driver , By . xpath ( ` //li[contains(text(), 'Data')] ` ) )
dataTab . click ( )
await delay ( regularDelayMs )
const functionType = await findElement ( driver , By . css ( '.confirm-page-container-content__function-type' ) )
const functionTypeText = await functionType . getText ( )
assert . equal ( functionTypeText , 'Transfer' )
const tokenAmount = await findElement ( driver , By . css ( '.confirm-page-container-summary__title-text' ) )
const tokenAmountText = await tokenAmount . getText ( )
assert . equal ( tokenAmountText , '1 TST' )
const confirmDataDiv = await findElement ( driver , By . css ( '.confirm-page-container-content__data-box' ) )
const confirmDataText = await confirmDataDiv . getText ( )
await delay ( regularDelayMs )
assert ( confirmDataText . match ( /0xa9059cbb0000000000000000000000002f318c334780961fb129d2a6c30d0763d9a5c97/ ) )
const detailsTab = await findElement ( driver , By . xpath ( ` //li[contains(text(), 'Details')] ` ) )
detailsTab . click ( )
await delay ( regularDelayMs )
} )
it ( 'submits the transaction' , async function ( ) {
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( regularDelayMs )
} )
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 1
} , 10000 )
const txValues = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
assert . equal ( txValues . length , 1 )
await driver . wait ( until . elementTextMatches ( txValues [ 0 ] , /-1\s*TST/ ) , 10000 )
const txStatuses = await findElements ( driver , By . css ( '.transaction-list-item__action' ) )
await driver . wait ( until . elementTextMatches ( txStatuses [ 0 ] , /Sent\sToken/i ) , 10000 )
} )
} )
describe ( 'Send a custom token from dapp' , ( ) => {
let gasModal
it ( 'sends an already created token' , async ( ) => {
const windowHandles = await driver . getAllWindowHandles ( )
const extension = windowHandles [ 0 ]
const dapp = await switchToWindowWithTitle ( driver , 'E2E Test Dapp' , windowHandles )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( dapp )
await delay ( tinyDelayMs )
const transferTokens = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Transfer Tokens')] ` ) )
await transferTokens . click ( )
await driver . switchTo ( ) . window ( extension )
await delay ( largeDelayMs )
await findElements ( driver , By . css ( '.transaction-list__pending-transactions' ) )
const [ txListValue ] = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txListValue , /-1.5\s*TST/ ) , 10000 )
await txListValue . click ( )
await delay ( regularDelayMs )
const transactionAmounts = await findElements ( driver , By . css ( '.currency-display-component__text' ) )
const transactionAmount = transactionAmounts [ 0 ]
assert ( await transactionAmount . getText ( ) , '1.5 TST' )
// Set the gas limit
const configureGas = await driver . wait ( until . elementLocated ( By . css ( '.confirm-detail-row__header-text--edit' ) ) , 10000 )
await configureGas . click ( )
await delay ( regularDelayMs )
gasModal = await driver . findElement ( By . css ( 'span .modal' ) )
} )
it ( 'customizes gas' , async ( ) => {
const modalTabs = await findElements ( driver , By . css ( '.page-container__tab' ) )
await modalTabs [ 1 ] . click ( )
await delay ( regularDelayMs )
Use `AdvancedGasInputs` in `AdvancedTabContent` (#7186)
* Use `AdvancedGasInputs` in `AdvancedTabContent`
The `AdvancedGasInputs` component was originally extracted from the
`AdvancedTabContent` component, duplicating much of the rendering
logic. They have since evolved separately, with bugs being fixed in one
place but not the other.
The inputs and outputs expected weren't exactly the same, as the
`AdvancedGasInputs` component converts the input custom gas price and
limit, and it converts them both in the setter methods as well.
The `GasModalPageContainer` had to be adjusted to avoid converting
these values multiple times.
Both components dealt with input debouncing separately, both in less
than ideal ways. `AdvancedTabContent` didn't debounce either field, but
it did debounce the check for whether the gas limit field was below the
minimum value. So if a less-than-minimum value was set, it would be
propogated upwards and could be saved if the user clicked 'Save'
quickly enough. After a second delay it would snap back to the minimum
value. The `AdvancedGasInputs` component debounced both fields, but
it would replace any gas limit below the minimum with the minimum
value. This led to a problem where a brief pause during typing would
reset the field to 21000.
The `AdvancedGasInputs` approach was chosen, except that it was
updated to no longer change the gas limit if it was below the minimum.
Instead it displays an error. Parent components were checked to ensure
they would detect the error case of the gas limit being set too low,
and prevent the form submission in those cases. Of the three parents,
one had already dealt with it correctly, one needed to convert the
gas limit from hex first, and another needed the gas limit check added.
Closes #6872
* Cleanup send components
Empty README files have been removed, and a mistake in the index file
for the send page has been corrected. The Gas Slider component class
name was updated as well; it looks like it was originally created from
`AdvancedTabContent`, so it still had that class name.
5 years ago
const [ gasPriceInput , gasLimitInput ] = await findElements ( driver , By . css ( '.advanced-gas-inputs__gas-edit-row__input' ) )
await gasPriceInput . sendKeys ( Key . chord ( Key . CONTROL , 'a' ) )
await delay ( 50 )
await gasPriceInput . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await gasPriceInput . sendKeys ( '10' )
await delay ( 50 )
await gasLimitInput . sendKeys ( Key . chord ( Key . CONTROL , 'a' ) )
await delay ( 50 )
await gasLimitInput . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await gasLimitInput . sendKeys ( '60000' )
Use `AdvancedGasInputs` in `AdvancedTabContent` (#7186)
* Use `AdvancedGasInputs` in `AdvancedTabContent`
The `AdvancedGasInputs` component was originally extracted from the
`AdvancedTabContent` component, duplicating much of the rendering
logic. They have since evolved separately, with bugs being fixed in one
place but not the other.
The inputs and outputs expected weren't exactly the same, as the
`AdvancedGasInputs` component converts the input custom gas price and
limit, and it converts them both in the setter methods as well.
The `GasModalPageContainer` had to be adjusted to avoid converting
these values multiple times.
Both components dealt with input debouncing separately, both in less
than ideal ways. `AdvancedTabContent` didn't debounce either field, but
it did debounce the check for whether the gas limit field was below the
minimum value. So if a less-than-minimum value was set, it would be
propogated upwards and could be saved if the user clicked 'Save'
quickly enough. After a second delay it would snap back to the minimum
value. The `AdvancedGasInputs` component debounced both fields, but
it would replace any gas limit below the minimum with the minimum
value. This led to a problem where a brief pause during typing would
reset the field to 21000.
The `AdvancedGasInputs` approach was chosen, except that it was
updated to no longer change the gas limit if it was below the minimum.
Instead it displays an error. Parent components were checked to ensure
they would detect the error case of the gas limit being set too low,
and prevent the form submission in those cases. Of the three parents,
one had already dealt with it correctly, one needed to convert the
gas limit from hex first, and another needed the gas limit check added.
Closes #6872
* Cleanup send components
Empty README files have been removed, and a mistake in the index file
for the send page has been corrected. The Gas Slider component class
name was updated as well; it looks like it was originally created from
`AdvancedTabContent`, so it still had that class name.
5 years ago
await delay ( 1000 )
const save = await findElement ( driver , By . css ( '.page-container__footer-button' ) )
await save . click ( )
await driver . wait ( until . stalenessOf ( gasModal ) )
const gasFeeInputs = await findElements ( driver , By . css ( '.confirm-detail-row__primary' ) )
const renderedGasFee = await gasFeeInputs [ 0 ] . getText ( )
assert . equal ( renderedGasFee , '0.0006' )
} )
it ( 'submits the transaction' , async function ( ) {
const tokenAmount = await findElement ( driver , By . css ( '.confirm-page-container-summary__title-text' ) )
const tokenAmountText = await tokenAmount . getText ( )
assert . equal ( tokenAmountText , '1.5 TST' )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( regularDelayMs )
} )
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 2
} , 10000 )
const txValues = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues [ 0 ] , /-1.5\s*TST/ ) )
const txStatuses = await findElements ( driver , By . css ( '.transaction-list-item__action' ) )
await driver . wait ( until . elementTextMatches ( txStatuses [ 0 ] , /Sent\sToken/ ) , 10000 )
const walletBalance = await findElement ( driver , By . css ( '.wallet-balance' ) )
await walletBalance . click ( )
const tokenListItems = await findElements ( driver , By . css ( '.token-list-item' ) )
await tokenListItems [ 0 ] . click ( )
await delay ( 1000 )
const tokenBalanceAmount = await findElements ( driver , By . css ( '.transaction-view-balance__primary-balance' ) )
await driver . wait ( until . elementTextMatches ( tokenBalanceAmount [ 0 ] , /7.500\s*TST/ ) , 10000 )
} )
} )
describe ( 'Approves a custom token from dapp' , ( ) => {
let gasModal
it ( 'approves an already created token' , async ( ) => {
const windowHandles = await driver . getAllWindowHandles ( )
const extension = windowHandles [ 0 ]
const dapp = await switchToWindowWithTitle ( driver , 'E2E Test Dapp' , windowHandles )
await closeAllWindowHandlesExcept ( driver , [ extension , dapp ] )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( dapp )
await delay ( tinyDelayMs )
const approveTokens = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Approve Tokens')] ` ) )
await approveTokens . click ( )
await driver . switchTo ( ) . window ( extension )
await delay ( regularDelayMs )
await driver . wait ( async ( ) => {
const pendingTxes = await findElements ( driver , By . css ( '.transaction-list__pending-transactions .transaction-list-item' ) )
return pendingTxes . length === 1
} , 10000 )
const [ txListItem ] = await findElements ( driver , By . css ( '.transaction-list-item' ) )
const [ txListValue ] = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txListValue , /-7\s*TST/ ) )
await txListItem . click ( )
await delay ( regularDelayMs )
} )
it ( 'displays the token approval data' , async ( ) => {
const fullTxDataButton = await findElement ( driver , By . css ( '.confirm-approve-content__view-full-tx-button' ) )
await fullTxDataButton . click ( )
await delay ( regularDelayMs )
const functionType = await findElement ( driver , By . css ( '.confirm-approve-content__data .confirm-approve-content__small-text' ) )
const functionTypeText = await functionType . getText ( )
assert . equal ( functionTypeText , 'Function: Approve' )
const confirmDataDiv = await findElement ( driver , By . css ( '.confirm-approve-content__data__data-block' ) )
const confirmDataText = await confirmDataDiv . getText ( )
assert ( confirmDataText . match ( /0x095ea7b30000000000000000000000009bc5baf874d2da8d216ae9f137804184ee5afef4/ ) )
} )
it ( 'opens the gas edit modal' , async ( ) => {
const editButtons = await findElements ( driver , By . css ( '.confirm-approve-content__small-blue-text.cursor-pointer' ) )
await editButtons [ 0 ] . click ( )
await delay ( regularDelayMs )
gasModal = await driver . findElement ( By . css ( 'span .modal' ) )
} )
it ( 'customizes gas' , async ( ) => {
const modalTabs = await findElements ( driver , By . css ( '.page-container__tab' ) )
await modalTabs [ 1 ] . click ( )
await delay ( regularDelayMs )
Use `AdvancedGasInputs` in `AdvancedTabContent` (#7186)
* Use `AdvancedGasInputs` in `AdvancedTabContent`
The `AdvancedGasInputs` component was originally extracted from the
`AdvancedTabContent` component, duplicating much of the rendering
logic. They have since evolved separately, with bugs being fixed in one
place but not the other.
The inputs and outputs expected weren't exactly the same, as the
`AdvancedGasInputs` component converts the input custom gas price and
limit, and it converts them both in the setter methods as well.
The `GasModalPageContainer` had to be adjusted to avoid converting
these values multiple times.
Both components dealt with input debouncing separately, both in less
than ideal ways. `AdvancedTabContent` didn't debounce either field, but
it did debounce the check for whether the gas limit field was below the
minimum value. So if a less-than-minimum value was set, it would be
propogated upwards and could be saved if the user clicked 'Save'
quickly enough. After a second delay it would snap back to the minimum
value. The `AdvancedGasInputs` component debounced both fields, but
it would replace any gas limit below the minimum with the minimum
value. This led to a problem where a brief pause during typing would
reset the field to 21000.
The `AdvancedGasInputs` approach was chosen, except that it was
updated to no longer change the gas limit if it was below the minimum.
Instead it displays an error. Parent components were checked to ensure
they would detect the error case of the gas limit being set too low,
and prevent the form submission in those cases. Of the three parents,
one had already dealt with it correctly, one needed to convert the
gas limit from hex first, and another needed the gas limit check added.
Closes #6872
* Cleanup send components
Empty README files have been removed, and a mistake in the index file
for the send page has been corrected. The Gas Slider component class
name was updated as well; it looks like it was originally created from
`AdvancedTabContent`, so it still had that class name.
5 years ago
const [ gasPriceInput , gasLimitInput ] = await findElements ( driver , By . css ( '.advanced-gas-inputs__gas-edit-row__input' ) )
await gasPriceInput . sendKeys ( Key . chord ( Key . CONTROL , 'a' ) )
await delay ( 50 )
await gasPriceInput . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await gasPriceInput . sendKeys ( '10' )
await delay ( 50 )
await gasLimitInput . sendKeys ( Key . chord ( Key . CONTROL , 'a' ) )
await delay ( 50 )
await gasLimitInput . sendKeys ( Key . BACK _SPACE )
await delay ( 50 )
await gasLimitInput . sendKeys ( '60001' )
Use `AdvancedGasInputs` in `AdvancedTabContent` (#7186)
* Use `AdvancedGasInputs` in `AdvancedTabContent`
The `AdvancedGasInputs` component was originally extracted from the
`AdvancedTabContent` component, duplicating much of the rendering
logic. They have since evolved separately, with bugs being fixed in one
place but not the other.
The inputs and outputs expected weren't exactly the same, as the
`AdvancedGasInputs` component converts the input custom gas price and
limit, and it converts them both in the setter methods as well.
The `GasModalPageContainer` had to be adjusted to avoid converting
these values multiple times.
Both components dealt with input debouncing separately, both in less
than ideal ways. `AdvancedTabContent` didn't debounce either field, but
it did debounce the check for whether the gas limit field was below the
minimum value. So if a less-than-minimum value was set, it would be
propogated upwards and could be saved if the user clicked 'Save'
quickly enough. After a second delay it would snap back to the minimum
value. The `AdvancedGasInputs` component debounced both fields, but
it would replace any gas limit below the minimum with the minimum
value. This led to a problem where a brief pause during typing would
reset the field to 21000.
The `AdvancedGasInputs` approach was chosen, except that it was
updated to no longer change the gas limit if it was below the minimum.
Instead it displays an error. Parent components were checked to ensure
they would detect the error case of the gas limit being set too low,
and prevent the form submission in those cases. Of the three parents,
one had already dealt with it correctly, one needed to convert the
gas limit from hex first, and another needed the gas limit check added.
Closes #6872
* Cleanup send components
Empty README files have been removed, and a mistake in the index file
for the send page has been corrected. The Gas Slider component class
name was updated as well; it looks like it was originally created from
`AdvancedTabContent`, so it still had that class name.
5 years ago
await delay ( 1000 )
const save = await findElement ( driver , By . css ( '.page-container__footer-button' ) )
await save . click ( )
await driver . wait ( until . stalenessOf ( gasModal ) )
const gasFeeInEth = await findElement ( driver , By . css ( '.confirm-approve-content__transaction-details-content__secondary-fee' ) )
assert . equal ( await gasFeeInEth . getText ( ) , '0.0006 ETH' )
} )
it ( 'edits the permission' , async ( ) => {
const editButtons = await findElements ( driver , By . css ( '.confirm-approve-content__small-blue-text.cursor-pointer' ) )
await editButtons [ 1 ] . click ( )
await delay ( regularDelayMs )
const permissionModal = await driver . findElement ( By . css ( 'span .modal' ) )
const radioButtons = await findElements ( driver , By . css ( '.edit-approval-permission__edit-section__radio-button' ) )
await radioButtons [ 1 ] . click ( )
const customInput = await findElement ( driver , By . css ( 'input' ) )
await delay ( 50 )
await customInput . sendKeys ( '5' )
await delay ( regularDelayMs )
const saveButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Save')] ` ) )
await saveButton . click ( )
await delay ( regularDelayMs )
await driver . wait ( until . stalenessOf ( permissionModal ) )
const permissionInfo = await findElements ( driver , By . css ( '.confirm-approve-content__medium-text' ) )
const amountDiv = permissionInfo [ 0 ]
assert . equal ( await amountDiv . getText ( ) , '5 TST' )
} )
it ( 'submits the transaction' , async function ( ) {
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( regularDelayMs )
} )
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 3
} , 10000 )
const txValues = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues [ 0 ] , /-5\s*TST/ ) )
const txStatuses = await findElements ( driver , By . css ( '.transaction-list-item__action' ) )
await driver . wait ( until . elementTextMatches ( txStatuses [ 0 ] , /Approve/ ) )
} )
} )
describe ( 'Tranfers a custom token from dapp when no gas value is specified' , ( ) => {
it ( 'transfers an already created token, without specifying gas' , async ( ) => {
const windowHandles = await driver . getAllWindowHandles ( )
const extension = windowHandles [ 0 ]
const dapp = await switchToWindowWithTitle ( driver , 'E2E Test Dapp' , windowHandles )
await closeAllWindowHandlesExcept ( driver , [ extension , dapp ] )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( dapp )
const transferTokens = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Transfer Tokens Without Gas')] ` ) )
await transferTokens . click ( )
await driver . switchTo ( ) . window ( extension )
await delay ( regularDelayMs )
await driver . wait ( async ( ) => {
const pendingTxes = await findElements ( driver , By . css ( '.transaction-list__pending-transactions .transaction-list-item' ) )
return pendingTxes . length === 1
} , 10000 )
const [ txListItem ] = await findElements ( driver , By . css ( '.transaction-list-item' ) )
const [ txListValue ] = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txListValue , /-1.5\s*TST/ ) )
await txListItem . click ( )
await delay ( regularDelayMs )
} )
it ( 'submits the transaction' , async function ( ) {
await delay ( largeDelayMs * 2 )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( largeDelayMs * 2 )
} )
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 4
} , 10000 )
const txValues = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues [ 0 ] , /-1.5\s*TST/ ) )
const txStatuses = await findElements ( driver , By . css ( '.transaction-list-item__action' ) )
await driver . wait ( until . elementTextMatches ( txStatuses [ 0 ] , /Sent Tokens/ ) )
} )
} )
describe ( 'Approves a custom token from dapp when no gas value is specified' , ( ) => {
it ( 'approves an already created token' , async ( ) => {
const windowHandles = await driver . getAllWindowHandles ( )
const extension = windowHandles [ 0 ]
const dapp = await switchToWindowWithTitle ( driver , 'E2E Test Dapp' , windowHandles )
await closeAllWindowHandlesExcept ( driver , [ extension , dapp ] )
await delay ( regularDelayMs )
await driver . switchTo ( ) . window ( dapp )
await delay ( tinyDelayMs )
const transferTokens = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Approve Tokens Without Gas')] ` ) )
await transferTokens . click ( )
await driver . switchTo ( ) . window ( extension )
await delay ( regularDelayMs )
await driver . wait ( async ( ) => {
const pendingTxes = await findElements ( driver , By . css ( '.transaction-list__pending-transactions .transaction-list-item' ) )
return pendingTxes . length === 1
} , 10000 )
const [ txListItem ] = await findElements ( driver , By . css ( '.transaction-list-item' ) )
const [ txListValue ] = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txListValue , /-7\s*TST/ ) )
await txListItem . click ( )
await delay ( regularDelayMs )
} )
it ( 'shows the correct recipient' , async function ( ) {
const fullTxDataButton = await findElement ( driver , By . css ( '.confirm-approve-content__view-full-tx-button' ) )
await fullTxDataButton . click ( )
await delay ( regularDelayMs )
const permissionInfo = await findElements ( driver , By . css ( '.confirm-approve-content__medium-text' ) )
const recipientDiv = permissionInfo [ 1 ]
assert . equal ( await recipientDiv . getText ( ) , '0x2f318C33...C970' )
} )
it ( 'submits the transaction' , async function ( ) {
await delay ( 1000 )
const confirmButton = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Confirm')] ` ) )
await confirmButton . click ( )
await delay ( regularDelayMs )
} )
it ( 'finds the transaction in the transactions list' , async function ( ) {
await driver . wait ( async ( ) => {
const confirmedTxes = await findElements ( driver , By . css ( '.transaction-list__completed-transactions .transaction-list-item' ) )
return confirmedTxes . length === 5
} , 10000 )
const txValues = await findElements ( driver , By . css ( '.transaction-list-item__amount--primary' ) )
await driver . wait ( until . elementTextMatches ( txValues [ 0 ] , /-7\s*TST/ ) )
const txStatuses = await findElements ( driver , By . css ( '.transaction-list-item__action' ) )
await driver . wait ( until . elementTextMatches ( txStatuses [ 0 ] , /Approve/ ) )
} )
} )
describe ( 'Hide token' , ( ) => {
it ( 'hides the token when clicked' , async ( ) => {
const [ hideTokenEllipsis ] = await findElements ( driver , By . css ( '.token-list-item__ellipsis' ) )
await hideTokenEllipsis . click ( )
const byTokenMenuDropdownOption = By . css ( '.menu__item--clickable' )
const tokenMenuDropdownOption = await driver . wait ( until . elementLocated ( byTokenMenuDropdownOption ) )
await tokenMenuDropdownOption . click ( )
const confirmHideModal = await findElement ( driver , By . css ( 'span .modal' ) )
const byHideTokenConfirmationButton = By . css ( '.hide-token-confirmation__button' )
const hideTokenConfirmationButton = await driver . wait ( until . elementLocated ( byHideTokenConfirmationButton ) )
await hideTokenConfirmationButton . click ( )
await driver . wait ( until . stalenessOf ( confirmHideModal ) )
} )
} )
describe ( 'Add existing token using search' , ( ) => {
it ( 'clicks on the Add Token button' , async ( ) => {
const addToken = await findElement ( driver , By . xpath ( ` //div[contains(text(), 'Add Token')] ` ) )
await addToken . click ( )
await delay ( regularDelayMs )
} )
it ( 'can pick a token from the existing options' , async ( ) => {
const tokenSearch = await findElement ( driver , By . css ( '#search-tokens' ) )
await tokenSearch . sendKeys ( 'BAT' )
await delay ( regularDelayMs )
const token = await findElement ( driver , By . xpath ( "//span[contains(text(), 'BAT')]" ) )
await token . click ( )
await delay ( regularDelayMs )
const nextScreen = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Next')] ` ) )
await nextScreen . click ( )
await delay ( regularDelayMs )
const addTokens = await findElement ( driver , By . xpath ( ` //button[contains(text(), 'Add Tokens')] ` ) )
await addTokens . click ( )
await delay ( largeDelayMs )
} )
it ( 'renders the balance for the chosen token' , async ( ) => {
const balance = await findElement ( driver , By . css ( '.transaction-view-balance__primary-balance' ) )
await driver . wait ( until . elementTextMatches ( balance , /0\s*BAT/ ) )
await delay ( regularDelayMs )
} )
} )
describe ( 'Stores custom RPC history' , ( ) => {
const customRpcUrls = [
'http://127.0.0.1:8545/1' ,
'http://127.0.0.1:8545/2' ,
'http://127.0.0.1:8545/3' ,
'http://127.0.0.1:8545/4' ,
]
customRpcUrls . forEach ( customRpcUrl => {
it ( ` creates custom RPC: ${ customRpcUrl } ` , async ( ) => {
const networkDropdown = await findElement ( driver , By . css ( '.network-name' ) )
await networkDropdown . click ( )
await delay ( regularDelayMs )
const customRpcButton = await findElement ( driver , By . xpath ( ` //span[contains(text(), 'Custom RPC')] ` ) )
await customRpcButton . click ( )
await delay ( regularDelayMs )
await findElement ( driver , By . css ( '.settings-page__sub-header-text' ) )
const customRpcInputs = await findElements ( driver , By . css ( 'input[type="text"]' ) )
const customRpcInput = customRpcInputs [ 1 ]
await customRpcInput . clear ( )
await customRpcInput . sendKeys ( customRpcUrl )
const customRpcSave = await findElement ( driver , By . css ( '.network-form__footer .btn-secondary' ) )
await customRpcSave . click ( )
await delay ( largeDelayMs * 2 )
} )
} )
it ( 'selects another provider' , async ( ) => {
const networkDropdown = await findElement ( driver , By . css ( '.network-name' ) )
await networkDropdown . click ( )
await delay ( regularDelayMs )
const customRpcButton = await findElement ( driver , By . xpath ( ` //span[contains(text(), 'Main Ethereum Network')] ` ) )
await customRpcButton . click ( )
await delay ( largeDelayMs * 2 )
} )
it ( 'finds all recent RPCs in history' , async ( ) => {
const networkDropdown = await findElement ( driver , By . css ( '.network-name' ) )
await networkDropdown . click ( )
await delay ( regularDelayMs )
// only recent 3 are found and in correct order (most recent at the top)
const customRpcs = await findElements ( driver , By . xpath ( ` //span[contains(text(), 'http://127.0.0.1:8545/')] ` ) )
assert . equal ( customRpcs . length , customRpcUrls . length )
} )
it ( 'deletes a custom RPC' , async ( ) => {
const networkListItems = await findElements ( driver , By . css ( '.networks-tab__networks-list-name' ) )
const lastNetworkListItem = networkListItems [ networkListItems . length - 1 ]
await lastNetworkListItem . click ( )
await delay ( 100 )
const deleteButton = await findElement ( driver , By . css ( '.btn-danger' ) )
await deleteButton . click ( )
await delay ( regularDelayMs )
const confirmDeleteNetworkModal = await findElement ( driver , By . css ( 'span .modal' ) )
const byConfirmDeleteNetworkButton = By . css ( '.button.btn-danger.modal-container__footer-button' )
const confirmDeleteNetworkButton = await driver . wait ( until . elementLocated ( byConfirmDeleteNetworkButton ) )
await confirmDeleteNetworkButton . click ( )
await driver . wait ( until . stalenessOf ( confirmDeleteNetworkModal ) )
const newNetworkListItems = await findElements ( driver , By . css ( '.networks-tab__networks-list-name' ) )
assert . equal ( networkListItems . length - 1 , newNetworkListItems . length )
} )
} )
} )