import { strict as assert } from 'assert'
import EventEmitter from 'events'
import ethUtil from 'ethereumjs-util'
import EthTx from 'ethereumjs-tx'
import ObservableStore from 'obs-store'
import sinon from 'sinon'
import TransactionController from '../../../../../app/scripts/controllers/transactions'
import { TRANSACTION _TYPE _RETRY } from '../../../../../app/scripts/controllers/transactions/enums'
import {
TOKEN _METHOD _APPROVE ,
TOKEN _METHOD _TRANSFER ,
SEND _ETHER _ACTION _KEY ,
DEPLOY _CONTRACT _ACTION _KEY ,
CONTRACT _INTERACTION _KEY ,
} from '../../../../../ui/app/helpers/constants/transactions'
import { createTestProviderTools , getTestAccounts } from '../../../../stub/provider'
const noop = ( ) => true
const currentNetworkId = '42'
const currentChainId = '0x2a'
describe ( 'Transaction Controller' , function ( ) {
let txController , provider , providerResultStub , fromAccount
beforeEach ( function ( ) {
providerResultStub = {
// 1 gwei
eth _gasPrice : '0x0de0b6b3a7640000' ,
// by default, all accounts are external accounts (not contracts)
eth _getCode : '0x' ,
}
provider = createTestProviderTools ( { scaffold : providerResultStub } ) . provider
fromAccount = getTestAccounts ( ) [ 0 ]
const blockTrackerStub = new EventEmitter ( )
blockTrackerStub . getCurrentBlock = noop
blockTrackerStub . getLatestBlock = noop
txController = new TransactionController ( {
provider ,
getGasPrice ( ) {
return '0xee6b2800'
} ,
networkStore : new ObservableStore ( currentNetworkId ) ,
txHistoryLimit : 10 ,
blockTracker : blockTrackerStub ,
signTransaction : ( ethTx ) => new Promise ( ( resolve ) => {
ethTx . sign ( fromAccount . key )
resolve ( )
} ) ,
getPermittedAccounts : ( ) => undefined ,
getCurrentChainId : ( ) => currentChainId ,
getParticipateInMetrics : ( ) => false ,
} )
txController . nonceTracker . getNonceLock = ( ) => Promise . resolve ( { nextNonce : 0 , releaseLock : noop } )
} )
describe ( '#getState' , function ( ) {
it ( 'should return a state object with the right keys and data types' , function ( ) {
const exposedState = txController . getState ( )
assert . ok ( 'unapprovedTxs' in exposedState , 'state should have the key unapprovedTxs' )
assert . ok ( 'currentNetworkTxList' in exposedState , 'state should have the key currentNetworkTxList' )
assert . ok ( typeof exposedState ? . unapprovedTxs === 'object' , 'should be an object' )
assert . ok ( Array . isArray ( exposedState . currentNetworkTxList ) , 'should be an array' )
} )
} )
describe ( '#getUnapprovedTxCount' , function ( ) {
it ( 'should return the number of unapproved txs' , function ( ) {
txController . txStateManager . _saveTxList ( [
{ id : 1 , status : 'unapproved' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 2 , status : 'unapproved' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 3 , status : 'unapproved' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
] )
const unapprovedTxCount = txController . getUnapprovedTxCount ( )
assert . equal ( unapprovedTxCount , 3 , 'should be 3' )
} )
} )
describe ( '#getPendingTxCount' , function ( ) {
it ( 'should return the number of pending txs' , function ( ) {
txController . txStateManager . _saveTxList ( [
{ id : 1 , status : 'submitted' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 2 , status : 'submitted' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 3 , status : 'submitted' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
] )
const pendingTxCount = txController . getPendingTxCount ( )
assert . equal ( pendingTxCount , 3 , 'should be 3' )
} )
} )
describe ( '#getConfirmedTransactions' , function ( ) {
it ( 'should return the number of confirmed txs' , function ( ) {
const address = '0xc684832530fcbddae4b4230a47e991ddcec2831d'
const txParams = {
'from' : address ,
'to' : '0xc684832530fcbddae4b4230a47e991ddcec2831d' ,
}
txController . txStateManager . _saveTxList ( [
{ id : 0 , status : 'confirmed' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
{ id : 1 , status : 'confirmed' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
{ id : 2 , status : 'confirmed' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
{ id : 3 , status : 'unapproved' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
{ id : 4 , status : 'rejected' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
{ id : 5 , status : 'approved' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
{ id : 6 , status : 'signed' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
{ id : 7 , status : 'submitted' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
{ id : 8 , status : 'failed' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
] )
assert . equal ( txController . nonceTracker . getConfirmedTransactions ( address ) . length , 3 )
} )
} )
describe ( '#newUnapprovedTransaction' , function ( ) {
let stub , txMeta , txParams
beforeEach ( function ( ) {
txParams = {
'from' : '0xc684832530fcbddae4b4230a47e991ddcec2831d' ,
'to' : '0xc684832530fcbddae4b4230a47e991ddcec2831d' ,
}
txMeta = {
status : 'unapproved' ,
id : 1 ,
metamaskNetworkId : currentNetworkId ,
txParams ,
history : [ { } ] ,
}
txController . txStateManager . _saveTxList ( [ txMeta ] )
stub = sinon . stub ( txController , 'addUnapprovedTransaction' ) . callsFake ( ( ) => {
txController . emit ( 'newUnapprovedTx' , txMeta )
return Promise . resolve ( txController . txStateManager . addTx ( txMeta ) )
} )
} )
afterEach ( function ( ) {
txController . txStateManager . _saveTxList ( [ ] )
stub . restore ( )
} )
it ( 'should resolve when finished and status is submitted and resolve with the hash' , async function ( ) {
txController . once ( 'newUnapprovedTx' , ( txMetaFromEmit ) => {
setTimeout ( ( ) => {
txController . setTxHash ( txMetaFromEmit . id , '0x0' )
txController . txStateManager . setTxStatusSubmitted ( txMetaFromEmit . id )
} )
} )
const hash = await txController . newUnapprovedTransaction ( txParams )
assert . ok ( hash , 'newUnapprovedTransaction needs to return the hash' )
} )
it ( 'should reject when finished and status is rejected' , async function ( ) {
txController . once ( 'newUnapprovedTx' , ( txMetaFromEmit ) => {
setTimeout ( ( ) => {
txController . txStateManager . setTxStatusRejected ( txMetaFromEmit . id )
} )
} )
await assert . rejects (
( ) => txController . newUnapprovedTransaction ( txParams ) ,
{ message : 'MetaMask Tx Signature: User denied transaction signature.' } ,
)
} )
} )
describe ( '#addUnapprovedTransaction' , function ( ) {
const selectedAddress = '0x1678a085c290ebd122dc42cba69373b5953b831d'
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
let getSelectedAddress , getPermittedAccounts
beforeEach ( function ( ) {
getSelectedAddress = sinon . stub ( txController , 'getSelectedAddress' ) . returns ( selectedAddress )
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
getPermittedAccounts = sinon . stub ( txController , 'getPermittedAccounts' ) . returns ( [ selectedAddress ] )
} )
afterEach ( function ( ) {
getSelectedAddress . restore ( )
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
getPermittedAccounts . restore ( )
} )
it ( 'should add an unapproved transaction and return a valid txMeta' , async function ( ) {
const txMeta = await txController . addUnapprovedTransaction ( { from : selectedAddress } )
assert . ok ( 'id' in txMeta , 'should have a id' )
assert . ok ( 'time' in txMeta , 'should have a time stamp' )
assert . ok ( 'metamaskNetworkId' in txMeta , 'should have a metamaskNetworkId' )
assert . ok ( 'txParams' in txMeta , 'should have a txParams' )
assert . ok ( 'history' in txMeta , 'should have a history' )
assert . equal ( txMeta . txParams . value , '0x0' , 'should have added 0x0 as the value' )
const memTxMeta = txController . txStateManager . getTx ( txMeta . id )
assert . deepEqual ( txMeta , memTxMeta )
} )
it ( 'should emit newUnapprovedTx event and pass txMeta as the first argument' , function ( done ) {
providerResultStub . eth _gasPrice = '4a817c800'
txController . once ( 'newUnapprovedTx' , ( txMetaFromEmit ) => {
assert . ok ( txMetaFromEmit , 'txMeta is falsy' )
done ( )
} )
txController . addUnapprovedTransaction ( { from : selectedAddress } )
. catch ( done )
} )
it ( "should fail if the from address isn't the selected address" , async function ( ) {
await assert . rejects ( ( ) => txController . addUnapprovedTransaction ( { from : '0x0d1d4e623D10F9FBA5Db95830F7d3839406C6AF2' } ) )
} )
it ( 'should fail if netId is loading' , async function ( ) {
txController . networkStore = new ObservableStore ( 'loading' )
await assert . rejects (
( ) => txController . addUnapprovedTransaction ( { from : selectedAddress , to : '0x0d1d4e623D10F9FBA5Db95830F7d3839406C6AF2' } ) ,
{ message : 'MetaMask is having trouble connecting to the network' } ,
)
} )
} )
describe ( '#addTxGasDefaults' , function ( ) {
it ( 'should add the tx defaults if their are none' , async function ( ) {
txController . txStateManager . _saveTxList ( [
{ id : 1 , status : 'unapproved' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
] )
const txMeta = {
id : 1 ,
txParams : {
from : '0xc684832530fcbddae4b4230a47e991ddcec2831d' ,
to : '0xc684832530fcbddae4b4230a47e991ddcec2831d' ,
} ,
history : [ { } ] ,
}
providerResultStub . eth _gasPrice = '4a817c800'
providerResultStub . eth _getBlockByNumber = { gasLimit : '47b784' }
providerResultStub . eth _estimateGas = '5209'
const txMetaWithDefaults = await txController . addTxGasDefaults ( txMeta )
assert . ok ( txMetaWithDefaults . txParams . gasPrice , 'should have added the gas price' )
assert . ok ( txMetaWithDefaults . txParams . gas , 'should have added the gas field' )
} )
} )
describe ( '#addTx' , function ( ) {
it ( 'should emit updates' , function ( done ) {
const txMeta = {
id : '1' ,
status : 'unapproved' ,
metamaskNetworkId : currentNetworkId ,
txParams : { } ,
}
const eventNames = [ 'update:badge' , '1:unapproved' ]
const listeners = [ ]
eventNames . forEach ( ( eventName ) => {
listeners . push ( new Promise ( ( resolve ) => {
txController . once ( eventName , ( arg ) => {
resolve ( arg )
} )
} ) )
} )
Promise . all ( listeners )
. then ( ( returnValues ) => {
assert . deepEqual ( returnValues . pop ( ) , txMeta , 'last event 1:unapproved should return txMeta' )
done ( )
} )
. catch ( done )
txController . addTx ( txMeta )
} )
} )
describe ( '#approveTransaction' , function ( ) {
it ( 'does not overwrite set values' , async function ( ) {
const originalValue = '0x01'
const txMeta = {
id : '1' ,
status : 'unapproved' ,
metamaskNetworkId : currentNetworkId ,
txParams : {
nonce : originalValue ,
gas : originalValue ,
gasPrice : originalValue ,
} ,
}
this . timeout ( 15000 )
const wrongValue = '0x05'
txController . addTx ( txMeta )
providerResultStub . eth _gasPrice = wrongValue
providerResultStub . eth _estimateGas = '0x5209'
const signStub = sinon . stub ( txController , 'signTransaction' ) . callsFake ( ( ) => Promise . resolve ( ) )
const pubStub = sinon . stub ( txController , 'publishTransaction' ) . callsFake ( ( ) => {
txController . setTxHash ( '1' , originalValue )
txController . txStateManager . setTxStatusSubmitted ( '1' )
} )
await txController . approveTransaction ( txMeta . id )
const result = txController . txStateManager . getTx ( txMeta . id )
const params = result . txParams
assert . equal ( params . gas , originalValue , 'gas unmodified' )
assert . equal ( params . gasPrice , originalValue , 'gas price unmodified' )
assert . equal ( result . hash , originalValue )
assert . equal ( result . status , 'submitted' , 'should have reached the submitted status.' )
signStub . restore ( )
pubStub . restore ( )
} )
} )
describe ( '#sign replay-protected tx' , function ( ) {
it ( 'prepares a tx with the chainId set' , async function ( ) {
txController . addTx ( { id : '1' , status : 'unapproved' , metamaskNetworkId : currentNetworkId , txParams : { } } , noop )
const rawTx = await txController . signTransaction ( '1' )
const ethTx = new EthTx ( ethUtil . toBuffer ( rawTx ) )
assert . equal ( ethTx . getChainId ( ) , 42 )
} )
} )
describe ( '#updateAndApproveTransaction' , function ( ) {
it ( 'should update and approve transactions' , async function ( ) {
const txMeta = {
id : 1 ,
status : 'unapproved' ,
txParams : {
from : fromAccount . address ,
to : '0x1678a085c290ebd122dc42cba69373b5953b831d' ,
gasPrice : '0x77359400' ,
gas : '0x7b0d' ,
nonce : '0x4b' ,
} ,
metamaskNetworkId : currentNetworkId ,
}
txController . txStateManager . addTx ( txMeta )
const approvalPromise = txController . updateAndApproveTransaction ( txMeta )
const tx = txController . txStateManager . getTx ( 1 )
assert . equal ( tx . status , 'approved' )
await approvalPromise
} )
} )
describe ( '#getChainId' , function ( ) {
it ( 'returns 0 when the chainId is NaN' , function ( ) {
txController . networkStore = new ObservableStore ( 'loading' )
assert . equal ( txController . getChainId ( ) , 0 )
} )
} )
describe ( '#cancelTransaction' , function ( ) {
it ( 'should emit a status change to rejected' , function ( done ) {
txController . txStateManager . _saveTxList ( [
{ id : 0 , status : 'unapproved' , txParams : { } , metamaskNetworkId : currentNetworkId , history : [ { } ] } ,
{ id : 1 , status : 'rejected' , txParams : { } , metamaskNetworkId : currentNetworkId , history : [ { } ] } ,
{ id : 2 , status : 'approved' , txParams : { } , metamaskNetworkId : currentNetworkId , history : [ { } ] } ,
{ id : 3 , status : 'signed' , txParams : { } , metamaskNetworkId : currentNetworkId , history : [ { } ] } ,
{ id : 4 , status : 'submitted' , txParams : { } , metamaskNetworkId : currentNetworkId , history : [ { } ] } ,
{ id : 5 , status : 'confirmed' , txParams : { } , metamaskNetworkId : currentNetworkId , history : [ { } ] } ,
{ id : 6 , status : 'failed' , txParams : { } , metamaskNetworkId : currentNetworkId , history : [ { } ] } ,
] )
txController . once ( 'tx:status-update' , ( txId , status ) => {
try {
assert . equal ( status , 'rejected' , 'status should e rejected' )
assert . equal ( txId , 0 , 'id should e 0' )
done ( )
} catch ( e ) {
done ( e )
}
} )
txController . cancelTransaction ( 0 )
} )
} )
describe ( '#createSpeedUpTransaction' , function ( ) {
let addTxSpy
let approveTransactionSpy
let txParams
let expectedTxParams
beforeEach ( function ( ) {
addTxSpy = sinon . spy ( txController , 'addTx' )
approveTransactionSpy = sinon . spy ( txController , 'approveTransaction' )
txParams = {
nonce : '0x00' ,
from : '0xB09d8505E1F4EF1CeA089D47094f5DD3464083d4' ,
to : '0xB09d8505E1F4EF1CeA089D47094f5DD3464083d4' ,
gas : '0x5209' ,
gasPrice : '0xa' ,
}
txController . txStateManager . _saveTxList ( [
{ id : 1 , status : 'submitted' , metamaskNetworkId : currentNetworkId , txParams , history : [ { } ] } ,
] )
expectedTxParams = { ... txParams , gasPrice : '0xb' }
} )
afterEach ( function ( ) {
addTxSpy . restore ( )
approveTransactionSpy . restore ( )
} )
it ( 'should call this.addTx and this.approveTransaction with the expected args' , async function ( ) {
await txController . createSpeedUpTransaction ( 1 )
assert . equal ( addTxSpy . callCount , 1 )
const addTxArgs = addTxSpy . getCall ( 0 ) . args [ 0 ]
assert . deepEqual ( addTxArgs . txParams , expectedTxParams )
const { lastGasPrice , type } = addTxArgs
assert . deepEqual ( { lastGasPrice , type } , {
lastGasPrice : '0xa' ,
type : TRANSACTION _TYPE _RETRY ,
} )
} )
it ( 'should call this.approveTransaction with the id of the returned tx' , async function ( ) {
const result = await txController . createSpeedUpTransaction ( 1 )
assert . equal ( approveTransactionSpy . callCount , 1 )
const approveTransactionArg = approveTransactionSpy . getCall ( 0 ) . args [ 0 ]
assert . equal ( result . id , approveTransactionArg )
} )
it ( 'should return the expected txMeta' , async function ( ) {
const result = await txController . createSpeedUpTransaction ( 1 )
assert . deepEqual ( result . txParams , expectedTxParams )
const { lastGasPrice , type } = result
assert . deepEqual ( { lastGasPrice , type } , {
lastGasPrice : '0xa' ,
type : TRANSACTION _TYPE _RETRY ,
} )
} )
} )
describe ( '#publishTransaction' , function ( ) {
let hash , txMeta
beforeEach ( function ( ) {
hash = '0x2a5523c6fa98b47b7d9b6c8320179785150b42a16bcff36b398c5062b65657e8'
txMeta = {
id : 1 ,
status : 'unapproved' ,
txParams : { } ,
metamaskNetworkId : currentNetworkId ,
}
providerResultStub . eth _sendRawTransaction = hash
} )
it ( 'should publish a tx, updates the rawTx when provided a one' , async function ( ) {
const rawTx = '0x477b2e6553c917af0db0388ae3da62965ff1a184558f61b749d1266b2e6d024c'
txController . txStateManager . addTx ( txMeta )
await txController . publishTransaction ( txMeta . id , rawTx )
const publishedTx = txController . txStateManager . getTx ( 1 )
assert . equal ( publishedTx . hash , hash )
assert . equal ( publishedTx . status , 'submitted' )
} )
it ( 'should ignore the error "Transaction Failed: known transaction" and be as usual' , async function ( ) {
providerResultStub . eth _sendRawTransaction = async ( _ , _ _ , _ _ _ , end ) => {
end ( 'Transaction Failed: known transaction' )
}
const rawTx = '0xf86204831e848082520894f231d46dd78806e1dd93442cf33c7671f853874880802ca05f973e540f2d3c2f06d3725a626b75247593cb36477187ae07ecfe0a4db3cf57a00259b52ee8c58baaa385fb05c3f96116e58de89bcc165cb3bfdfc708672fed8a'
txController . txStateManager . addTx ( txMeta )
await txController . publishTransaction ( txMeta . id , rawTx )
const publishedTx = txController . txStateManager . getTx ( 1 )
assert . equal ( publishedTx . hash , '0x2cc5a25744486f7383edebbf32003e5a66e18135799593d6b5cdd2bb43674f09' )
assert . equal ( publishedTx . status , 'submitted' )
} )
} )
describe ( '#_markNonceDuplicatesDropped' , function ( ) {
it ( 'should mark all nonce duplicates as dropped without marking the confirmed transaction as dropped' , function ( ) {
txController . txStateManager . _saveTxList ( [
{ id : 1 , status : 'confirmed' , metamaskNetworkId : currentNetworkId , history : [ { } ] , txParams : { nonce : '0x01' } } ,
{ id : 2 , status : 'submitted' , metamaskNetworkId : currentNetworkId , history : [ { } ] , txParams : { nonce : '0x01' } } ,
{ id : 3 , status : 'submitted' , metamaskNetworkId : currentNetworkId , history : [ { } ] , txParams : { nonce : '0x01' } } ,
{ id : 4 , status : 'submitted' , metamaskNetworkId : currentNetworkId , history : [ { } ] , txParams : { nonce : '0x01' } } ,
{ id : 5 , status : 'submitted' , metamaskNetworkId : currentNetworkId , history : [ { } ] , txParams : { nonce : '0x01' } } ,
{ id : 6 , status : 'submitted' , metamaskNetworkId : currentNetworkId , history : [ { } ] , txParams : { nonce : '0x01' } } ,
{ id : 7 , status : 'submitted' , metamaskNetworkId : currentNetworkId , history : [ { } ] , txParams : { nonce : '0x01' } } ,
] )
txController . _markNonceDuplicatesDropped ( 1 )
const confirmedTx = txController . txStateManager . getTx ( 1 )
const droppedTxs = txController . txStateManager . getFilteredTxList ( { nonce : '0x01' , status : 'dropped' } )
assert . equal ( confirmedTx . status , 'confirmed' , 'the confirmedTx should remain confirmed' )
assert . equal ( droppedTxs . length , 6 , 'their should be 6 dropped txs' )
} )
} )
describe ( '#_determineTransactionCategory' , function ( ) {
it ( 'should return a simple send transactionCategory when to is truthy but data is falsy' , async function ( ) {
const result = await txController . _determineTransactionCategory ( {
to : '0xabc' ,
data : '' ,
} )
assert . deepEqual ( result , { transactionCategory : SEND _ETHER _ACTION _KEY , getCodeResponse : null } )
} )
it ( 'should return a token transfer transactionCategory when data is for the respective method call' , async function ( ) {
const result = await txController . _determineTransactionCategory ( {
to : '0xabc' ,
data : '0xa9059cbb0000000000000000000000002f318C334780961FB129D2a6c30D0763d9a5C970000000000000000000000000000000000000000000000000000000000000000a' ,
} )
assert . deepEqual ( result , { transactionCategory : TOKEN _METHOD _TRANSFER , getCodeResponse : undefined } )
} )
it ( 'should return a token approve transactionCategory when data is for the respective method call' , async function ( ) {
const result = await txController . _determineTransactionCategory ( {
to : '0xabc' ,
data : '0x095ea7b30000000000000000000000002f318C334780961FB129D2a6c30D0763d9a5C9700000000000000000000000000000000000000000000000000000000000000005' ,
} )
assert . deepEqual ( result , { transactionCategory : TOKEN _METHOD _APPROVE , getCodeResponse : undefined } )
} )
it ( 'should return a contract deployment transactionCategory when to is falsy and there is data' , async function ( ) {
const result = await txController . _determineTransactionCategory ( {
to : '' ,
data : '0xabd' ,
} )
assert . deepEqual ( result , { transactionCategory : DEPLOY _CONTRACT _ACTION _KEY , getCodeResponse : undefined } )
} )
it ( 'should return a simple send transactionCategory with a 0x getCodeResponse when there is data and but the to address is not a contract address' , async function ( ) {
const result = await txController . _determineTransactionCategory ( {
to : '0x9e673399f795D01116e9A8B2dD2F156705131ee9' ,
data : '0xabd' ,
} )
assert . deepEqual ( result , { transactionCategory : SEND _ETHER _ACTION _KEY , getCodeResponse : '0x' } )
} )
it ( 'should return a simple send transactionCategory with a null getCodeResponse when to is truthy and there is data and but getCode returns an error' , async function ( ) {
const result = await txController . _determineTransactionCategory ( {
to : '0xabc' ,
data : '0xabd' ,
} )
assert . deepEqual ( result , { transactionCategory : SEND _ETHER _ACTION _KEY , getCodeResponse : null } )
} )
it ( 'should return a contract interaction transactionCategory with the correct getCodeResponse when to is truthy and there is data and it is not a token transaction' , async function ( ) {
const _providerResultStub = {
// 1 gwei
eth _gasPrice : '0x0de0b6b3a7640000' ,
// by default, all accounts are external accounts (not contracts)
eth _getCode : '0xa' ,
}
const _provider = createTestProviderTools ( { scaffold : _providerResultStub } ) . provider
const _fromAccount = getTestAccounts ( ) [ 0 ]
const _blockTrackerStub = new EventEmitter ( )
_blockTrackerStub . getCurrentBlock = noop
_blockTrackerStub . getLatestBlock = noop
const _txController = new TransactionController ( {
provider : _provider ,
getGasPrice ( ) {
return '0xee6b2800'
} ,
networkStore : new ObservableStore ( currentNetworkId ) ,
txHistoryLimit : 10 ,
blockTracker : _blockTrackerStub ,
signTransaction : ( ethTx ) => new Promise ( ( resolve ) => {
ethTx . sign ( _fromAccount . key )
resolve ( )
} ) ,
getParticipateInMetrics : ( ) => false ,
} )
const result = await _txController . _determineTransactionCategory ( {
to : '0x9e673399f795D01116e9A8B2dD2F156705131ee9' ,
data : 'abd' ,
} )
assert . deepEqual ( result , { transactionCategory : CONTRACT _INTERACTION _KEY , getCodeResponse : '0x0a' } )
} )
it ( 'should return a contract interaction transactionCategory with the correct getCodeResponse when to is a contract address and data is falsy' , async function ( ) {
const _providerResultStub = {
// 1 gwei
eth _gasPrice : '0x0de0b6b3a7640000' ,
// by default, all accounts are external accounts (not contracts)
eth _getCode : '0xa' ,
}
const _provider = createTestProviderTools ( { scaffold : _providerResultStub } ) . provider
const _fromAccount = getTestAccounts ( ) [ 0 ]
const _blockTrackerStub = new EventEmitter ( )
_blockTrackerStub . getCurrentBlock = noop
_blockTrackerStub . getLatestBlock = noop
const _txController = new TransactionController ( {
provider : _provider ,
getGasPrice ( ) {
return '0xee6b2800'
} ,
networkStore : new ObservableStore ( currentNetworkId ) ,
txHistoryLimit : 10 ,
blockTracker : _blockTrackerStub ,
signTransaction : ( ethTx ) => new Promise ( ( resolve ) => {
ethTx . sign ( _fromAccount . key )
resolve ( )
} ) ,
getParticipateInMetrics : ( ) => false ,
} )
const result = await _txController . _determineTransactionCategory ( {
to : '0x9e673399f795D01116e9A8B2dD2F156705131ee9' ,
data : '' ,
} )
assert . deepEqual ( result , { transactionCategory : CONTRACT _INTERACTION _KEY , getCodeResponse : '0x0a' } )
} )
} )
describe ( '#getPendingTransactions' , function ( ) {
it ( 'should show only submitted and approved transactions as pending transaction' , function ( ) {
txController . txStateManager . _saveTxList ( [
{ id : 1 , status : 'unapproved' , metamaskNetworkId : currentNetworkId , txParams : { } } ,
{ id : 2 , status : 'rejected' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 3 , status : 'approved' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 4 , status : 'signed' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 5 , status : 'submitted' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 6 , status : 'confirmed' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
{ id : 7 , status : 'failed' , metamaskNetworkId : currentNetworkId , txParams : { } , history : [ { } ] } ,
] )
assert . equal ( txController . pendingTxTracker . getPendingTransactions ( ) . length , 2 )
const states = txController . pendingTxTracker . getPendingTransactions ( ) . map ( ( tx ) => tx . status )
assert . ok ( states . includes ( 'approved' ) , 'includes approved' )
assert . ok ( states . includes ( 'submitted' ) , 'includes submitted' )
} )
} )
} )