Fix BigNumber conversion error (#7088)

In the case where the block gas limit in the MetaMask state is blank,
an exception is sometimes thrown when that blank value is passed to
`multiplyCurrencies` to be parsed as a hex number.

Instead the minimum gas limit is now used instead whenever the block
gas limit is falsy. This was already being done in one case anyway.
feature/default_network_editable
Mark Stacey 5 years ago committed by GitHub
parent 87cf0ced13
commit 0f1edce403
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 5
      ui/app/pages/send/send.utils.js

@ -13,6 +13,7 @@ const {
BASE_TOKEN_GAS_COST,
INSUFFICIENT_FUNDS_ERROR,
INSUFFICIENT_TOKENS_ERROR,
MIN_GAS_LIMIT_HEX,
NEGATIVE_ETH_ERROR,
ONE_GWEI_IN_WEI_HEX,
SIMPLE_GAS_COST,
@ -202,7 +203,7 @@ function doesAmountErrorRequireUpdate ({
async function estimateGas ({
selectedAddress,
selectedToken,
blockGasLimit,
blockGasLimit = MIN_GAS_LIMIT_HEX,
to,
value,
data,
@ -242,7 +243,7 @@ async function estimateGas ({
}
// if not, fall back to block gasLimit
paramsForGasEstimate.gas = ethUtil.addHexPrefix(multiplyCurrencies(blockGasLimit || '0x5208', 0.95, {
paramsForGasEstimate.gas = ethUtil.addHexPrefix(multiplyCurrencies(blockGasLimit, 0.95, {
multiplicandBase: 16,
multiplierBase: 10,
roundDown: '0',

Loading…
Cancel
Save