From 12918e18942a72223d7d97334934c31442e51caf Mon Sep 17 00:00:00 2001 From: kumavis Date: Thu, 30 Mar 2017 16:06:27 -0700 Subject: [PATCH] tests - tx-manager - fix assert and clean formatting --- package.json | 2 +- test/unit/tx-manager-test.js | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 9e04bc6f7..ba6a81da9 100644 --- a/package.json +++ b/package.json @@ -56,7 +56,7 @@ "eth-query": "^1.0.3", "eth-sig-util": "^1.1.1", "eth-simple-keyring": "^1.1.1", - "ethereumjs-tx": "^1.0.0", + "ethereumjs-tx": "^1.2.5", "ethereumjs-util": "ethereumjs/ethereumjs-util#ac5d0908536b447083ea422b435da27f26615de9", "ethereumjs-wallet": "^0.6.0", "ethjs-ens": "^1.0.2", diff --git a/test/unit/tx-manager-test.js b/test/unit/tx-manager-test.js index 20f89a226..21e94357b 100644 --- a/test/unit/tx-manager-test.js +++ b/test/unit/tx-manager-test.js @@ -1,5 +1,4 @@ -// const assert = require('assert') -const assert = require('chai').assert +const assert = require('assert') const extend = require('xtend') const EventEmitter = require('events') const ethUtil = require('ethereumjs-util') @@ -22,7 +21,6 @@ describe('Transaction Manager', function() { blockTracker: new EventEmitter(), signTransaction: (ethTx) => new Promise((resolve) => { ethTx.sign(privKey) - const result = ethTx.serialize() resolve() }) }) @@ -229,21 +227,15 @@ describe('Transaction Manager', function() { }) }) - describe('#sign replay-protected tx', function() { it('prepares a tx with the chainId set', function() { txManager.addTx({ id: '1', status: 'unapproved', metamaskNetworkId: currentNetworkId, txParams: {} }, noop) txManager.signTransaction('1', (err, rawTx) => { if (err) return assert.fail('it should not fail') const ethTx = new EthTx(ethUtil.toBuffer(rawTx)) - console.log('------------------------------------------') - console.log('ethTx.getChainId(), currentNetworkId') - console.log(ethTx.getChainId(), currentNetworkId) assert.equal(ethTx.getChainId(), currentNetworkId) }) }) }) - - })