fix marking of confirmed transaction as dropped

7 years ago · 5572345b78
parent 4a3288fec9
commit 5572345b78
1 changed files with 1 additions and 1 deletions
--- a/app/scripts/controllers/transactions.js
+++ b/app/scripts/controllers/transactions.js
@ -317,7 +317,7 @@ module.exports = class TransactionController extends EventEmitter {
    if (!sameNonceTxs.length) return
    // mark all same nonce transactions as dropped and give i a replacedBy hash
    sameNonceTxs.forEach((otherTxMeta) => {
-      if (otherTxMeta === txId) return
+      if (otherTxMeta.id === txId) return
      otherTxMeta.replacedBy = txMeta.hash
      this.txStateManager.updateTx(txMeta, 'transactions/pending-tx-tracker#event: tx:confirmed reference to confirmed txHash with same nonce')
      this.txStateManager.setTxStatusDropped(otherTxMeta.id)