Merge pull request #348 from MetaMask/i341

Clear notifications on extension open + guard against negative sends
8 years ago · 7026eca222
parent 204cb7f1ed 16566ee7db
commit 7026eca222
4 changed files with 17 additions and 4 deletions
--- a/app/scripts/lib/notifications.js
+++ b/app/scripts/lib/notifications.js
@ -176,7 +176,7 @@ function renderNotificationSVG(content, cb){
 }

 function svgWrapper(content){
-  var wrapperSource = `    
+  var wrapperSource = `
  <svg xmlns="http://www.w3.org/2000/svg" width="450" height="300">
     <foreignObject x="0" y="0" width="100%" height="100%">
        <body xmlns="http://www.w3.org/1999/xhtml" height="100%">{{content}}</body>
@ -188,4 +188,4 @@ function svgWrapper(content){

 function toSvgUri(content){
  return 'data:image/svg+xml;utf8,' + encodeURIComponent(content)
-}
+}
--- a/app/scripts/popup.js
+++ b/app/scripts/popup.js
@ -65,11 +65,21 @@ function getCurrentDomain (cb) {
  })
 }

+function clearNotifications(){
+  chrome.notifications.getAll(function (object) {
+    for (let notification in object){
+      chrome.notifications.clear(notification)
+    }
+  })
+}
+
 function setupApp (err, opts) {
  if (err) {
    alert(err.stack)
    throw err
  }
+  
+  clearNotifications()

  var container = document.getElementById('app-content')

--- a/ui/app/app.js
+++ b/ui/app/app.js
@ -355,4 +355,3 @@ App.prototype.toggleMetamaskActive = function () {
    this.props.dispatch(actions.lockMetamask(false))
  }
 }
-
--- a/ui/app/send.js
+++ b/ui/app/send.js
@ -216,6 +216,11 @@ SendTransactionScreen.prototype.onSubmit = function () {
    return this.props.dispatch(actions.displayWarning(message))
  }

+  if (input < 0) {
+    message = 'Can not send negative amounts of ETH.'
+    return this.props.dispatch(actions.displayWarning(message))
+  }
+
  if ((!util.isValidAddress(recipient) && !txData) || (!recipient && !txData)) {
    message = 'Recipient address is invalid.'
    return this.props.dispatch(actions.displayWarning(message))
@ -234,4 +239,3 @@ SendTransactionScreen.prototype.onSubmit = function () {

  this.props.dispatch(actions.signTx(txParams))
 }
-