From 98bedfabf932ff75445769898f8f97cf9f6e7f75 Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Thu, 17 Aug 2017 15:35:17 -0700 Subject: [PATCH 1/2] Fix eth sign formatting --- ui/app/components/pending-msg-details.js | 2 +- ui/app/components/pending-msg.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ui/app/components/pending-msg-details.js b/ui/app/components/pending-msg-details.js index 16308d121..718a22de0 100644 --- a/ui/app/components/pending-msg-details.js +++ b/ui/app/components/pending-msg-details.js @@ -38,7 +38,7 @@ PendingMsgDetails.prototype.render = function () { // message data h('.tx-data.flex-column.flex-justify-center.flex-grow.select-none', [ - h('.flex-row.flex-space-between', [ + h('.flex-column.flex-space-between', [ h('label.font-small', 'MESSAGE'), h('span.font-small', msgParams.data), ]), diff --git a/ui/app/components/pending-msg.js b/ui/app/components/pending-msg.js index b2cac164a..b7133cda8 100644 --- a/ui/app/components/pending-msg.js +++ b/ui/app/components/pending-msg.js @@ -18,6 +18,9 @@ PendingMsg.prototype.render = function () { h('div', { key: msgData.id, + style: { + maxWidth: '350px', + }, }, [ // header @@ -35,7 +38,7 @@ PendingMsg.prototype.render = function () { }, `Signing this message can have dangerous side effects. Only sign messages from sites you fully trust with your entire account. - This will be fixed in a future version.`), + This dangerous method will be removed in a future version.`), // message details h(PendingTxDetails, state), From c90ff2847f119103c58ab713dad8859cce0e92e6 Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Thu, 17 Aug 2017 15:35:52 -0700 Subject: [PATCH 2/2] Bump changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 88c794652..64af1a98c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,8 @@ ## Current Master - Fix bug where some transaction submission errors would show an empty screen. +- Fix formatting of eth_sign "Sign Message" view. +- Add deprecation warning to eth_sign "Sign Message" view. ## 3.9.8 2017-8-16