From 701bc1cbd1337eee87cc524f12a105548ab096ac Mon Sep 17 00:00:00 2001 From: Bruno Barbieri Date: Fri, 28 Dec 2018 17:34:26 -0500 Subject: [PATCH 01/16] Fix etherscan links on notifications --- app/scripts/platforms/extension.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/scripts/platforms/extension.js b/app/scripts/platforms/extension.js index 3f1cb0f27..55240ef1a 100644 --- a/app/scripts/platforms/extension.js +++ b/app/scripts/platforms/extension.js @@ -111,7 +111,7 @@ class ExtensionPlatform { _viewOnEtherScan (txId) { if (txId.startsWith('http://')) { - global.metamaskController.platform.openWindow({ url: txId }) + this.openWindow({ url: txId }) } } } From 58b0a4c8f4c28bfe57b276e37b81607289032c30 Mon Sep 17 00:00:00 2001 From: Bruno Barbieri Date: Mon, 31 Dec 2018 16:16:34 -0500 Subject: [PATCH 02/16] Dont use sudo to install truffle --- test/e2e/beta/run-drizzle.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/beta/run-drizzle.sh b/test/e2e/beta/run-drizzle.sh index 609f2765e..6e4602d00 100755 --- a/test/e2e/beta/run-drizzle.sh +++ b/test/e2e/beta/run-drizzle.sh @@ -7,7 +7,7 @@ sleep 5 cd test/e2e/beta/ rm -rf drizzle-test mkdir drizzle-test && cd drizzle-test -sudo npm install -g truffle +npm install -g truffle truffle unbox drizzle echo "Deploying contracts for Drizzle test..." truffle compile && truffle migrate From 3a75571da2ed8d8623c35a346179264e5232bb0b Mon Sep 17 00:00:00 2001 From: Bruno Barbieri Date: Wed, 2 Jan 2019 16:18:24 -0500 Subject: [PATCH 03/16] --unsafe-perm ? --- test/e2e/beta/run-drizzle.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/beta/run-drizzle.sh b/test/e2e/beta/run-drizzle.sh index 6e4602d00..7f474b418 100755 --- a/test/e2e/beta/run-drizzle.sh +++ b/test/e2e/beta/run-drizzle.sh @@ -7,7 +7,7 @@ sleep 5 cd test/e2e/beta/ rm -rf drizzle-test mkdir drizzle-test && cd drizzle-test -npm install -g truffle +sudo npm install --unsafe-perm -g truffle truffle unbox drizzle echo "Deploying contracts for Drizzle test..." truffle compile && truffle migrate From d504c075d55fa8d1009b1f5622294fcdd7514c38 Mon Sep 17 00:00:00 2001 From: Bruno Barbieri Date: Wed, 2 Jan 2019 16:29:33 -0500 Subject: [PATCH 04/16] Use sudo consistently --- test/e2e/beta/run-drizzle.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/beta/run-drizzle.sh b/test/e2e/beta/run-drizzle.sh index 7f474b418..bac57a098 100755 --- a/test/e2e/beta/run-drizzle.sh +++ b/test/e2e/beta/run-drizzle.sh @@ -8,9 +8,9 @@ cd test/e2e/beta/ rm -rf drizzle-test mkdir drizzle-test && cd drizzle-test sudo npm install --unsafe-perm -g truffle -truffle unbox drizzle +sudo truffle unbox drizzle echo "Deploying contracts for Drizzle test..." -truffle compile && truffle migrate +sudo truffle compile && sudo truffle migrate BROWSER=none npm start >> /dev/null 2>&1 & cd ../../../../ mocha test/e2e/beta/drizzle.spec From 3112d5b5c0e305ef02cf78d40ade2a1f650ad569 Mon Sep 17 00:00:00 2001 From: Bruno Barbieri Date: Wed, 2 Jan 2019 17:17:44 -0500 Subject: [PATCH 05/16] no globals --- test/e2e/beta/run-drizzle.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/e2e/beta/run-drizzle.sh b/test/e2e/beta/run-drizzle.sh index bac57a098..a16c795a6 100755 --- a/test/e2e/beta/run-drizzle.sh +++ b/test/e2e/beta/run-drizzle.sh @@ -7,10 +7,10 @@ sleep 5 cd test/e2e/beta/ rm -rf drizzle-test mkdir drizzle-test && cd drizzle-test -sudo npm install --unsafe-perm -g truffle -sudo truffle unbox drizzle +npm install --unsafe-perm truffle +../../../../node_modules/.bin/truffle unbox drizzle echo "Deploying contracts for Drizzle test..." -sudo truffle compile && sudo truffle migrate +../../../../node_modules/.bin/truffle compile && ../../../../node_modules/.bin/truffle migrate BROWSER=none npm start >> /dev/null 2>&1 & cd ../../../../ mocha test/e2e/beta/drizzle.spec From c349bbdece7138cda2329271b1fd254c51963117 Mon Sep 17 00:00:00 2001 From: Bruno Barbieri Date: Wed, 2 Jan 2019 17:28:26 -0500 Subject: [PATCH 06/16] remove --unsafe-perm --- test/e2e/beta/run-drizzle.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/beta/run-drizzle.sh b/test/e2e/beta/run-drizzle.sh index a16c795a6..09b903afb 100755 --- a/test/e2e/beta/run-drizzle.sh +++ b/test/e2e/beta/run-drizzle.sh @@ -7,7 +7,7 @@ sleep 5 cd test/e2e/beta/ rm -rf drizzle-test mkdir drizzle-test && cd drizzle-test -npm install --unsafe-perm truffle +npm install truffle ../../../../node_modules/.bin/truffle unbox drizzle echo "Deploying contracts for Drizzle test..." ../../../../node_modules/.bin/truffle compile && ../../../../node_modules/.bin/truffle migrate From c49d975687fbcbb8f1c7e2832acab45aca80cbfb Mon Sep 17 00:00:00 2001 From: brunobar79 Date: Wed, 2 Jan 2019 19:03:35 -0500 Subject: [PATCH 07/16] fix extension link --- app/scripts/platforms/extension.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/scripts/platforms/extension.js b/app/scripts/platforms/extension.js index 55240ef1a..e8779739c 100644 --- a/app/scripts/platforms/extension.js +++ b/app/scripts/platforms/extension.js @@ -111,7 +111,7 @@ class ExtensionPlatform { _viewOnEtherScan (txId) { if (txId.startsWith('http://')) { - this.openWindow({ url: txId }) + extension.tabs.create({ url: txId }) } } } From da7208c16d8df30030a1b531f8feabd23528d161 Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Wed, 2 Jan 2019 16:44:59 -0800 Subject: [PATCH 08/16] Version 5.3.0 RC1 --- CHANGELOG.md | 9 +++++++++ app/manifest.json | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7fc182db0..becbae3e2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,15 @@ ## Current Develop Branch +## 5.3.0 Wed Jan 02 2019 + +- [#5978](https://github.com/MetaMask/metamask-extension/pull/5978): Fix etherscan links on notifications +- [#5980](https://github.com/MetaMask/metamask-extension/pull/5980): Fix drizzle tests +- [#5922](https://github.com/MetaMask/metamask-extension/pull/5922): Prevent users from changing the From field in the send screen +- [#5932](https://github.com/MetaMask/metamask-extension/pull/5932): Fix displayed time and date in the activity log. Remove vreme library, add luxon library. +- [#5924](https://github.com/MetaMask/metamask-extension/pull/5924): transactions - throw an error if a transaction is generated while the network is loading +- [#5893](https://github.com/MetaMask/metamask-extension/pull/5893): Add loading network screen + ## 5.2.2 Wed Dec 12 2018 - [#5925](https://github.com/MetaMask/metamask-extension/pull/5925): Fix speed up button not showing for transactions with the lowest nonce diff --git a/app/manifest.json b/app/manifest.json index 4f4598a18..6c35c6989 100644 --- a/app/manifest.json +++ b/app/manifest.json @@ -1,7 +1,7 @@ { "name": "__MSG_appName__", "short_name": "__MSG_appName__", - "version": "5.2.2", + "version": "5.3.0", "manifest_version": 2, "author": "https://metamask.io", "description": "__MSG_appDescription__", From 9de32722b80f2d6be996a1c1552f87ebc3ec7f3d Mon Sep 17 00:00:00 2001 From: Paul Chonpimai Date: Thu, 3 Jan 2019 14:31:53 +0700 Subject: [PATCH 09/16] fix typo in phishing.html title --- app/phishing.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/phishing.html b/app/phishing.html index 284d0fcac..207489a12 100644 --- a/app/phishing.html +++ b/app/phishing.html @@ -3,7 +3,7 @@ - Ethereum Phishing Detection - MetMask + Ethereum Phishing Detection - MetaMask