From 81ff04ec279c5642a5e0a8dbc45724d2b8774850 Mon Sep 17 00:00:00 2001 From: kumavis Date: Mon, 21 May 2018 18:00:22 -0700 Subject: [PATCH] test - e2e - ignore favicon 404s --- test/e2e/metamask.spec.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/e2e/metamask.spec.js b/test/e2e/metamask.spec.js index 72861adc4..4ce51a91a 100644 --- a/test/e2e/metamask.spec.js +++ b/test/e2e/metamask.spec.js @@ -310,7 +310,12 @@ describe('Metamask popup page', function () { async function checkBrowserForConsoleErrors() { const ignoredLogTypes = ['WARNING'] - const ignoredErrorMessages = ['Warning: Unknown prop `dataset` on '] + const ignoredErrorMessages = [ + // React throws error warnings on "dataset", but still sets the data-* properties correctly + 'Warning: Unknown prop `dataset` on ', + // Third-party Favicon 404s show up as errors + 'favicon.ico - Failed to load resource: the server responded with a status of 404 (Not Found)', + ] const browserLogs = await driver.manage().logs().get('browser') const errorEntries = browserLogs.filter(entry => !ignoredLogTypes.includes(entry.level.toString())) const errorObjects = errorEntries.map(entry => entry.toJSON())