From 2c47fb14e08fb4385148135892c9b2d429bc76fe Mon Sep 17 00:00:00 2001 From: kumavis Date: Mon, 11 Apr 2016 16:04:12 -0700 Subject: [PATCH 1/2] clean - inpage remove unused xhr mitm code --- app/scripts/inpage.js | 70 ------------------------------------------- 1 file changed, 70 deletions(-) diff --git a/app/scripts/inpage.js b/app/scripts/inpage.js index 065f69629..e15c08671 100644 --- a/app/scripts/inpage.js +++ b/app/scripts/inpage.js @@ -1,6 +1,4 @@ const XHR = window.XMLHttpRequest -// const fauxJax = require('faux-jax') -// fauxJax.install() // bring in web3 but rename on window const Web3 = require('web3') @@ -94,71 +92,3 @@ web3.setProvider = function(){ console.log('MetaMask - overrode web3.setProvider') } console.log('MetaMask - injected web3') - - -// -// intercept local node requests -// - - -// console.log('MetaMask - intercepting localhost:8545 requests') - -// fauxJax.on('request', function(req){ -// // check if local node request -// if (req.requestURL.indexOf('localhost:8545') !== -1) { -// var rpcReq = JSON.parse(req.requestBody) -// if (req.async) { -// remoteProvider.sendAsync(rpcReq, function(err, result){ -// // console.log('intercepted request (async):', rpcReq, result) -// handleResult(result) -// }) -// } else { -// var result = remoteProvider.send(rpcReq) -// // console.log('intercepted request (sync):', rpcReq, result) -// handleResult(result) -// } -// } else { -// // console.log('request continuing normally:', req.requestURL) -// continueRequestNormally(req) -// } - -// function handleResult(result){ -// var serializedResult = JSON.stringify(result) -// req.respond(200, { -// 'content-type': 'application/json', -// }, serializedResult) -// } -// }) - -// function continueRequestNormally(req){ -// var xhr = new XHR() -// // set target url and method -// xhr.open(req.requestMethod, req.requestURL, req.async) -// // set headers -// Object.keys(req.requestHeaders || {}).forEach(function(headerKey){ -// xhr.setRequestHeader(headerKey, req.requestHeaders[headerKey]) -// }) -// // send and call completion handler -// if (req.async) { -// xhr.onload = copyResult -// xhr.send(req.requestBody) -// } else { -// xhr.send(req.requestBody) -// copyResult() -// } - -// function copyResult() { -// var headers = extractResponseHeaders(xhr.getAllResponseHeaders()) -// req.respond(xhr.status, headers, xhr.response) -// } -// } - -// function extractResponseHeaders(rawHeaders){ -// var headers = {} -// var headerKeyValues = rawHeaders.split('\r\n').filter(Boolean) -// headerKeyValues.forEach(function(keyValue){ -// var data = keyValue.split(': ') -// headers[data[0]] = data[1] -// }) -// return headers -// } From 38582f6aae949fdbfd48d28e496fc3f217f9c585 Mon Sep 17 00:00:00 2001 From: kumavis Date: Thu, 14 Apr 2016 11:31:15 -0700 Subject: [PATCH 2/2] web3 - set defaultAccount --- app/scripts/inpage.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/scripts/inpage.js b/app/scripts/inpage.js index e15c08671..121246d6a 100644 --- a/app/scripts/inpage.js +++ b/app/scripts/inpage.js @@ -32,7 +32,9 @@ remoteProvider.on('error', console.error.bind(console)) // // handle accounts cache -var accountsCache = [] +var accountsCache = JSON.parse(localStorage['MetaMask-Accounts'] || '[]') +web3.eth.defaultAccount = accounts[0] + setInterval(populateAccountsCache, 4000) function populateAccountsCache(){ remoteProvider.sendAsync(createPayload({ @@ -44,6 +46,7 @@ function populateAccountsCache(){ // update localStorage var accounts = response.result if (accounts.toString() !== accountsCache.toString()) { + web3.eth.defaultAccount = accounts[0] accountsCache = accounts localStorage['MetaMask-Accounts'] = JSON.stringify(accounts) } @@ -58,13 +61,11 @@ remoteProvider.send = function(payload){ case 'eth_accounts': // read from localStorage - accountsCache = JSON.parse(localStorage['MetaMask-Accounts'] || '[]') result = accountsCache break case 'eth_coinbase': // read from localStorage - accountsCache = JSON.parse(localStorage['MetaMask-Accounts'] || '[]') result = accountsCache[0] || '0x0000000000000000000000000000000000000000' break