From e197e3808ff70058ccf3eca0d11255e61180373a Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Mon, 19 Sep 2016 10:15:19 +0800 Subject: [PATCH 1/3] Drop origin key from requests for Parity compatibility --- CHANGELOG.md | 1 + app/scripts/metamask-controller.js | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c1483b7cc..a66389213 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Add a link to the transaction in history that goes to https://metamask.github.io/eth-tx-viz too help visualize transactions and to where they are going. - Show "Buy Ether" button and warning on tx confirmation when sender balance is insufficient +- Change behavior that prevented Parity client compatibility, where we included a request site origin on rpc calls. ## 2.12.1 2016-09-14 diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index 06337be1c..2b10c8c35 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -75,6 +75,10 @@ module.exports = class MetamaskController { } onRpcRequest (stream, originDomain, request) { + + /* Commented out for Parity compliance + * Parity does not permit additional keys, like `origin`, + * and Infura is not currently filtering this key out. var payloads = Array.isArray(request) ? request : [request] payloads.forEach(function (payload) { // Append origin to rpc payload @@ -86,6 +90,7 @@ module.exports = class MetamaskController { payload.params.push({ origin: originDomain }) } }) + */ // handle rpc request this.provider.sendAsync(request, function onPayloadHandled (err, response) { From 57d9481d9d9276446fd33fbaf6422432e7041475 Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Mon, 19 Sep 2016 10:17:46 +0800 Subject: [PATCH 2/3] Bump web3 provider engine version for Parity compliance --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index fc88162ed..a05c01ba2 100644 --- a/package.json +++ b/package.json @@ -81,7 +81,7 @@ "through2": "^2.0.1", "vreme": "^3.0.2", "web3": "ethereum/web3.js#260ac6e78a8ce4b2e13f5bb0fdb65f4088585876", - "web3-provider-engine": "^8.0.5", + "web3-provider-engine": "^8.0.6", "web3-stream-provider": "^2.0.6", "xtend": "^4.0.1" }, From 9d5cdbcbe6d44ac3f26c5ae912531a8dd5d5c37d Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Mon, 19 Sep 2016 22:58:10 +0800 Subject: [PATCH 3/3] Version 2.13.0 --- CHANGELOG.md | 4 +++- app/manifest.json | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a66389213..6f72c83d1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,10 +2,12 @@ ## Current Master +## 2.13.0 2016-09-18 + +- Add Parity compatibility, fixing Geth dependency issues. - Add a link to the transaction in history that goes to https://metamask.github.io/eth-tx-viz too help visualize transactions and to where they are going. - Show "Buy Ether" button and warning on tx confirmation when sender balance is insufficient -- Change behavior that prevented Parity client compatibility, where we included a request site origin on rpc calls. ## 2.12.1 2016-09-14 diff --git a/app/manifest.json b/app/manifest.json index daf9ef94a..1af4d76d2 100644 --- a/app/manifest.json +++ b/app/manifest.json @@ -1,7 +1,7 @@ { "name": "MetaMask", "short_name": "Metamask", - "version": "2.12.1", + "version": "2.13.0", "manifest_version": 2, "author": "https://metamask.io", "description": "Ethereum Browser Extension",