From 1e681f991859f816a9d5a44997dfda7504e38da3 Mon Sep 17 00:00:00 2001 From: Jyoti Puri Date: Fri, 4 Nov 2022 23:17:53 +0530 Subject: [PATCH 1/3] Fix approve transaction call in _onBootCleanUp (#16382) --- app/scripts/controllers/transactions/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/scripts/controllers/transactions/index.js b/app/scripts/controllers/transactions/index.js index c6cf3a061..cd4c8c1a0 100644 --- a/app/scripts/controllers/transactions/index.js +++ b/app/scripts/controllers/transactions/index.js @@ -1844,7 +1844,7 @@ export default class TransactionController extends EventEmitter { .forEach((txMeta) => { // Line below will try to publish transaction which is in // APPROVED state at the time of controller bootup - this.approveTransaction(txMeta); + this.approveTransaction(txMeta.id); }); } From 925253bc9fec3c6e9ea6da441db4548859eca054 Mon Sep 17 00:00:00 2001 From: seaona Date: Mon, 7 Nov 2022 12:19:15 +0100 Subject: [PATCH 2/3] Changelog updated --- CHANGELOG.md | 6 +++++- package.json | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 035fa837e..450325476 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +## [10.21.2] +### Fixed +- Fix undefined txParams when calling approveTransaction, by adding the id on the txMeta argument ([#16382](https://github.com/MetaMask/metamask-extension/pull/16382)) ## [10.21.1] ### Changed @@ -3253,7 +3256,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Uncategorized - Added the ability to restore accounts from seed words. -[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v10.21.1...HEAD +[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v10.21.2...HEAD +[10.21.2]: https://github.com/MetaMask/metamask-extension/compare/v10.21.1...v10.21.2 [10.21.1]: https://github.com/MetaMask/metamask-extension/compare/v10.21.0...v10.21.1 [10.21.0]: https://github.com/MetaMask/metamask-extension/compare/v10.20.0...v10.21.0 [10.20.0]: https://github.com/MetaMask/metamask-extension/compare/v10.19.0...v10.20.0 diff --git a/package.json b/package.json index dcc6805e3..058d84cd3 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "metamask-crx", - "version": "10.21.1", + "version": "10.21.2", "private": true, "repository": { "type": "git", From a970ac7901672227251392096373a189986f2c61 Mon Sep 17 00:00:00 2001 From: seaona Date: Mon, 7 Nov 2022 12:38:47 +0100 Subject: [PATCH 3/3] Fix lint --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 450325476..f24a4c728 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] + ## [10.21.2] ### Fixed - Fix undefined txParams when calling approveTransaction, by adding the id on the txMeta argument ([#16382](https://github.com/MetaMask/metamask-extension/pull/16382))