From e197e3808ff70058ccf3eca0d11255e61180373a Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Mon, 19 Sep 2016 10:15:19 +0800 Subject: [PATCH] Drop origin key from requests for Parity compatibility --- CHANGELOG.md | 1 + app/scripts/metamask-controller.js | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c1483b7cc..a66389213 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Add a link to the transaction in history that goes to https://metamask.github.io/eth-tx-viz too help visualize transactions and to where they are going. - Show "Buy Ether" button and warning on tx confirmation when sender balance is insufficient +- Change behavior that prevented Parity client compatibility, where we included a request site origin on rpc calls. ## 2.12.1 2016-09-14 diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index 06337be1c..2b10c8c35 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -75,6 +75,10 @@ module.exports = class MetamaskController { } onRpcRequest (stream, originDomain, request) { + + /* Commented out for Parity compliance + * Parity does not permit additional keys, like `origin`, + * and Infura is not currently filtering this key out. var payloads = Array.isArray(request) ? request : [request] payloads.forEach(function (payload) { // Append origin to rpc payload @@ -86,6 +90,7 @@ module.exports = class MetamaskController { payload.params.push({ origin: originDomain }) } }) + */ // handle rpc request this.provider.sendAsync(request, function onPayloadHandled (err, response) {