From f49b6ca1dc6b71a3280135a0a901311b289c26ed Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Thu, 30 Jun 2016 11:30:46 -0700 Subject: [PATCH] Replicated really strange bug with test --- app/scripts/lib/config-manager.js | 2 +- test/unit/config-manager-test.js | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/app/scripts/lib/config-manager.js b/app/scripts/lib/config-manager.js index 0af82c89c..337671c42 100644 --- a/app/scripts/lib/config-manager.js +++ b/app/scripts/lib/config-manager.js @@ -152,7 +152,7 @@ ConfigManager.prototype.getCurrentRpcAddress = function () { ConfigManager.prototype.clearWallet = function () { var data = this.getConfig() delete data.wallet - this.setData(data) + this.setConfig(data) } ConfigManager.prototype.setData = function (data) { diff --git a/test/unit/config-manager-test.js b/test/unit/config-manager-test.js index 7891c5c9e..69c462286 100644 --- a/test/unit/config-manager-test.js +++ b/test/unit/config-manager-test.js @@ -22,6 +22,7 @@ describe('config-manager', function() { describe('#setConfirmed', function() { it('should make getConfirmed return true once set', function() { + assert.equal(configManager.getConfirmed(), false) configManager.setConfirmed(true) var result = configManager.getConfirmed() assert.equal(result, true) @@ -41,6 +42,17 @@ describe('config-manager', function() { }) }) + describe('#clearWallet', function() { + it('should not erase confirmation', function() { + configManager.setConfirmed(true) + assert.equal(configManager.getConfirmed(), true) + + configManager.clearWallet() + + assert.equal(configManager.getConfirmed(), true) + }) + }) + describe('#setConfig', function() { window.localStorage = {} // Hacking localStorage support into JSDom @@ -63,8 +75,9 @@ describe('config-manager', function() { provider: { type: 'rpc', rpcTarget: 'foobar' - } + }, } + configManager.setConfirmed(true) configManager.setConfig(testConfig) var testWallet = { @@ -75,6 +88,7 @@ describe('config-manager', function() { var result = configManager.getData() assert.equal(result.wallet.name, testWallet.name, 'wallet name is set') assert.equal(result.config.provider.rpcTarget, testConfig.provider.rpcTarget) + assert.equal(configManager.getConfirmed(), true) testConfig.provider.type = 'something else!' configManager.setConfig(testConfig) @@ -83,6 +97,7 @@ describe('config-manager', function() { assert.equal(result.wallet.name, testWallet.name, 'wallet name is set') assert.equal(result.config.provider.rpcTarget, testConfig.provider.rpcTarget) assert.equal(result.config.provider.type, testConfig.provider.type) + assert.equal(configManager.getConfirmed(), true) }) })