Mark Stacey
c30a42ab8e
Fix token validation in Send flow ( #10045 )
...
Additional validation was added in #9907 to ensure that the "Known
contract address" warning was shown when sending tokens to another
token address after switching assets on the Send screen. Unfortunately
this change had the unintended side-effect of preventing _all_ token
sends after switching assets, so long as the recipient was not an
internal address.
The problem is that the `validate` function expects to be passed the
address of the token send recipient in the case where a token is
selected. Instead the token address was being passed to the validate
function.
The `query` state is now used, which should always contain the
recipient address. This is the same state used in the only other place
the `validate` function is called.
4 years ago
David Walsh
42fd8b0ff0
Use strict equality in unit tests ( #9966 )
4 years ago
Erik Marks
9d4b8a4903
@metamask/contract-metadata ( #9968 )
4 years ago
Brad Decker
3ebba0d411
validate addresses in qr codes ( #9916 )
4 years ago
Thomas Huang
44448465ed
Validate sendToken address when component updates ( #9907 )
...
* Validate sendToken address when component updates
On a reproduction of trying to get the error message it seems that if an token address is provided in the address form with ETH selected then changing to a token address, the error message won't show.
This will validate the sendtoken address on prop change to properly update the warning message.
* Update test to include second doesAmountErrorRequireUpdate call when state is updated and component is updated
4 years ago
David Walsh
67303b7865
Fix BigNumber issues ( #9860 )
...
* Document where we need BigNumber-related changes
* Fix 1 unit test
* Debug progress
* Add required values for each upstream usage of getBigNumber
* Switch to base 10
* Address feedback
4 years ago
Erik Marks
8c6c944d14
Fix unit tests
4 years ago
Erik Marks
bb81ac7cd6
Fix setGasPrice dispatch function params
4 years ago
David Walsh
c4fad4b87f
Make QR code button focusable ( #9822 )
4 years ago
Patryk Łucka
128efc5b52
Add sort and search to AddRecipient accounts list ( #9257 )
...
* sort and search accounts in AddRecipient component
* Update AddRecipient unit test
Co-authored-by: Erik Marks <rekmarks@protonmail.com>
4 years ago
Patryk Łucka
ee205b893f
Create custom addHexPrefix function ( #9306 )
...
* create custom addHexPrefix function
* switch to custom addHexPrefix
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Erik Marks <rekmarks@protonmail.com>
4 years ago
Erik Marks
bff982017b
Fix send header cancel button alignment ( #9812 )
4 years ago
David Walsh
8a3dabb230
Use optional chaining for functions
4 years ago
Brad Decker
2ebf8756a4
[RFC] add prettier to eslint ( #8595 )
4 years ago
David Walsh
907e8d6a77
Remove border radius from transfer button ( #9767 )
4 years ago
Brad Decker
14161e37da
normalize page font styles ( #9697 )
4 years ago
David Walsh
9c25775b69
Prevent conflicting values when network change and QR code in same render
4 years ago
David Walsh
cdef338c85
Prevent multiple state changes
4 years ago
David Walsh
6704aab16c
Lint
4 years ago
David Walsh
21875d1dd3
Fix for tests
4 years ago
David Walsh
4892a3e0e1
Fix 9649 - Ensure QR codes work properly when adding contact
4 years ago
Erik Marks
59212f7a2b
Remove dead gas estimation functions, rename function ( #9579 )
4 years ago
Mark Stacey
ded43cbcdf
Remove unused code ( #9564 )
...
A number of unused parameters and `propTypes` have been merged, along
with an unused function.
4 years ago
Dan J Miller
30d13422b5
Add MetaMask Swaps ( #9482 )
4 years ago
Patryk Łucka
cd86d00cb7
Fix send warning dialog ( #9321 )
...
This change moves warning message from `add-recipient` component to `send-content`. Currently
whenever provided address is a valid eth address `send-content` is rendered instead of `add-recipient`
this is why warnings never popped up.
4 years ago
Patryk Łucka
20b0e66cc9
fix ens error text on mainnet ( #9314 )
4 years ago
Mark Stacey
b9f5f1c2c2
Hide ETH Gas Station stimates on non-main network ( #9277 )
...
* Hide gas estimate on non-main network (#9189 )
* Update v8.0.9 changelog
4 years ago
Brad Decker
c04cb63c63
Standardize scss import practices ( #9183 )
4 years ago
Whymarrh Whitby
b6ccd22d6c
Update ESLint shared config to v3 ( #9274 )
...
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
4 years ago
Patryk Łucka
9a3c559b3d
Hide gas estimate on non-main network ( #9189 )
...
* hide advance gas on non mainnet
* hide edit gas button on non mainnet
4 years ago
Whymarrh Whitby
6ab12001e3
Fix prefer-destructuring issues ( #9263 )
...
See [`prefer-destructuring`](https://eslint.org/docs/rules/prefer-destructuring ) for more information.
This change enables `prefer-destructuring` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
c1e3c229bc
Fix import/order issues ( #9239 )
...
See [`import/order`](https://eslint.org/docs/rules/import/order ) for more information.
This change enables `import/order` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
b7259e5d6a
Fix radix issues ( #9247 )
...
See [`radix`](https://eslint.org/docs/rules/radix ) for more information.
This change enables `radix` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
4357cda7b8
Fix no-shadow issues ( #9246 )
...
See [`no-shadow`](https://eslint.org/docs/rules/no-shadow ) for more information.
This change enables `no-shadow` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
e803807dd9
Fix no-param-reassign issues ( #9235 )
...
See [`no-param-reassign`](https://eslint.org/docs/rules/no-param-reassign ) for more information.
This change enables `no-param-reassign` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
5d42a9b773
Fix require-unicode-regexp issues ( #9212 )
...
* Fix require-unicode-regexp issues
See [`require-unicode-regexp`](https://eslint.org/docs/rules/require-unicode-regexp ) for more information.
This change enables `require-unicode-regexp` and fixes the issues raised by the rule.
* Remove case-insensitive flag from regexps
4 years ago
Whymarrh Whitby
884775cf71
Fix no-negated-condition issues ( #9222 )
...
See [`no-negated-condition`](https://eslint.org/docs/rules/no-negated-condition ) for more information.
This change enables `no-negated-condition` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
c11888f287
Fix no-empty-function issues ( #9216 )
...
See [`no-empty-function`](https://eslint.org/docs/rules/no-empty-function ) for more information.
This change enables `no-empty-function` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
9b78d3ab07
Fix import/extensions issues ( #9217 )
...
See [`import/extensions`](https://eslint.org/docs/rules/import/extensions ) for more information.
This change enables `import/extensions` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
b91cf74d14
Fix no-nested-ternary issues ( #9214 )
...
See [`no-nested-ternary`](https://eslint.org/docs/rules/no-nested-ternary ) for more information.
This change enables `no-nested-ternary` and fixes the issues raised by the rule.
4 years ago
Whymarrh Whitby
a8863a3446
Fix consistent-return issues ( #9192 )
...
See [`consistent-return`](https://eslint.org/docs/rules/consistent-return ) for more information.
This change enables `consistent-return` and fixes the issues raised by the rule.
4 years ago
Brad Decker
ecaa6c55dd
trim unused account-list-item code and co-locate styles ( #9116 )
4 years ago
Brad Decker
723e478689
move currency-display styles to where they are used ( #9119 )
4 years ago
Brad Decker
1582855e28
Use mixins for typography instead of placeholder selectors ( #9072 )
...
Using extend would not work inside of some css, namely
inside of media queries. This made it a clear choice to
use mixins for these styles.
4 years ago
Brad Decker
df8eb494fe
Updates Typography Variables and styles. ( #9017 )
...
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
4 years ago
Whymarrh Whitby
2ae4720443
Fix words ( #9038 )
4 years ago
Whymarrh Whitby
983e32274c
Fix array-callback-return issues
...
See [`array-callback-return`](https://eslint.org/docs/rules/array-callback-return ) for more information.
This change enables `array-callback-return` and fixes the issues raised by the
rule.
4 years ago
Mark Stacey
f46dda0195
Uncomment and fix all auto-fixable stylelint rules ( #8989 )
...
All stylelint rules that can be automatically fixed have been uncommented. The rules are:
* `at-rule-empty-line-before`
* `block-closing-brace-empty-line-before`
* `block-closing-brace-newline-before`
* `block-opening-brace-space-before`
* `color-hex-case`
* `color-hex-length`
* `comment-empty-line-before`
* `declaration-block-semicolon-newline-after`
* `declaration-block-semicolon-space-after`
* `declaration-block-trailing-semicolon`
* `declaration-colon-space-after`
* `declaration-empty-line-before`
* `function-comma-space-after`
* `function-comma-space-before`
* `indentation`
* `length-zero-no-unit`
* `no-eol-whitespace`
* `no-missing-end-of-source-newline`
* `number-leading-zero`
* `number-no-trailing-zeros`
* `rule-empty-line-before`
* `selector-list-comma-newline-after`
* `selector-pseudo-element-colon-notation`
4 years ago
Whymarrh Whitby
4f0a205369
Use eslint@6.8.0 ( #8978 )
...
* Use eslint@6.8.0
* yarn lint:fix
4 years ago
Dan J Miller
ac525572eb
Move checkExistingAddresses to helpers/utils/util and stop its use of ramda ( #8868 )
4 years ago