f4094925f0
Ensure ledger keyring message event listener are removed on metamask lock ( #14691 )
...
* Ensure ledger keyring message event listener are removed on metamask lock
* Clean up
3 years ago
ae4efef43e
add networks without ticker trait ( #14607 )
...
* add networks without ticker trait
3 years ago
eee4cc3100
Add Coinbase Pay as fiat onramp option ( #14648 )
3 years ago
a3917763d4
Removed onExecutionEnvironmentError ( #14698 )
...
* used correct method to stop snap
* removed dead code, snap controller already subscribes to execution environment errors
* fixed linting error
3 years ago
8948018e5a
Ensure ledger keyring message event listener are removed on metamask lock ( #14691 )
...
* Ensure ledger keyring message event listener are removed on metamask lock
* Clean up
3 years ago
c0957866a9
metametrics: deprecate flatMap ( #14608 )
3 years ago
6c757ab5e0
Event tracking for Token Detection V2 ( #14441 )
3 years ago
9a153d2388
Remove gas editing in Swaps ( #14673 )
...
* Remove gas editing in Swaps
* Remove "extraApprovalGas"
3 years ago
b258cbafe7
Remove confirmation for terminated snaps ( #14566 )
3 years ago
2dac88cbf4
snaps-skunkworks@0.12.0 ( #14670 )
...
* snaps-skunkworks@0.12.0
* Bump iframe execution environment
* Remove policy override
* Rerun LavaMoat
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
3 years ago
0a10b425ea
Add New Tokens Found page ( #14366 )
3 years ago
2bd7127433
Swaps / STX improvements ( #14622 )
3 years ago
9e401b14bf
Simplify removeSnap functionality after snaps-skunkworks update ( #14646 )
3 years ago
4550a10d32
fix incorrect casing of includeUsdRate option passed to CurrencyRateController ( #14615 )
3 years ago
564ad2f81b
Track send flow history on txMeta ( #14510 )
3 years ago
f926925b3f
metametrics: deprecate flatMap ( #14608 )
3 years ago
23e3f52a04
Update version parsing to allow rollback release ( #14288 )
...
* Update version parsing to allow rollback release
When we want to rollback a release on Chrome, sometimes we use the
fourth part of the version for the rollback release. This is because
the Chrome web stores does not directly allow rolling back, but instead
requires us to re-submit the release we want to roll back to with a
higher version number.
The manifest version parsing now allows for a fourth version part.
The comments have also been updated to be more descriptive, and to fix
a minor inaccuracy.
* Fix typo in comment
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
3 years ago
0110bd9571
Fix lint errors
3 years ago
c1ca70d732
phishing-detect - validate redirect url protocol
3 years ago
73a7ce9e39
Add applyLavaMoat build flag ( #14583 )
...
Adds a new flag, `--apply-lavamoat`, to the main build script. The flag controls whether LavaMoat is actually applied to the output of the build process. The flag defaults to `true`, but we explicitly set it to `false` in the `start` package script. Meanwhile, the `start:lavamoat` script is modified such that it applies LavaMoat to the build output in development mode, but it no longer runs the build process itself under LavaMoat as there aren't very compelling reasons to do so.
This change is motivated by the fact that development builds do not have their own dedicated LavaMoat policies, which causes development builds to fail since #14537 . The downside of this change is that LavaMoat-related failures will not be detected when running `yarn start`. @kumavis has plans for fixing this problem in a future major version of the `@lavamoat` suite.
3 years ago
7da6c66ea2
Added getAccounts suppressUnauthorized param ( #14126 )
...
* Added getAccounts suppressUnauthorized param
* Changed getAccounts supresss unauth param name
* Changed getAccounts param to object
* Fixed default empty obj for getAccounts getPermittedAccounts param
* Bump eth-json-rpc-middleware version to 8.0.2
* Fixed lavamoat policy
* Fixed lavamoat policies
* Fixed dedupe issues
* Fixed lavamoat allowscripts
* yarn deduplicate
* Fixed lavamoat policies
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
3 years ago
fd3eabf327
Revert "Revert "Dark Mode: What's New Announcement ( #14346 )""
...
This reverts commit 9cea6f57ef
3 years ago
1624af2364
snaps-skunkworks@0.11.1 ( #14531 )
...
* snaps-skunkworks@0.11.0
* Update LavaMoat policies
* Fix breaking changes
* Use SnapController:clearSnapState
* Fix fetch properly
* Bump iframe execution environment
* snaps-skunkworks@0.11.1
* Run allow-scripts auto
3 years ago
6309d53650
Dark Mode : Add OS option in theme selection dropdown ( #14379 )
3 years ago
b29b48836e
Update Dark Mode What's New message ( #14535 )
3 years ago
72d2977e72
Warn about multiple MetaMask instances running ( #13836 )
...
* Add text warning on startup page
* Try to detect extensions with browser API
* Setup messaging between different versions of extension
* Cleanup
* Cleanup
* Simplify check for multiple instances running
* Fix a doc string + use webextension-polyfill
* Fix test
* Mock webextension-polyfill
* Mock correctly
* Catch error and show warning in both extensions
* Mock as promise
* Address comments
* Rename build ids
* Run detection code only if Chrome
* Add Firefox warnings
* Cleanup imports
* Update connection ids
* Run detection code for Firefox
* Add test
* Add missing await
* Update tests
* Cleanup
* Cleanup
* Improve testing
* Improve tests
* Log errors from sendMessage
* Cleanup
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
3 years ago
74b5401302
Fixed API for watchAsset ( #14545 )
...
* Fixed API for watchAsset
* Fixed boolean return value for watchAsset
3 years ago
27ad7279cd
Rename NotificationController to AnnouncementController ( #14389 )
...
* Rename NotificationController to AnnouncementController
* Fix test
* Add test for missing NotificationController state
* Bump controllers
* Move test to correct file
* Rename config key
* Add migration 71 to list of migrations
* Fix selector after migration
3 years ago
193c22588e
call controller methods directly in send duck ( #14465 )
3 years ago
9cea6f57ef
Revert "Dark Mode: What's New Announcement ( #14346 )"
...
This reverts commit af963d7f7b
3 years ago
cf2c6a3164
show token approval details on confirm approve screen by default ( #14523 )
3 years ago
37272ad923
i18n - remove unused locale strings ( #14527 )
3 years ago
f567a3fe86
Do not show failed off-chain transactions details when grouped with another valid transaction of same nonce ( #14497 )
...
* fix failed off chain tx mismatch with next confirmed transaction
* dont drop failed txs when tx in confirmed
* add comment for reassigning logic
* resolve change requests
3 years ago
ef6fb86f50
Update for a new Add network page ( #13866 )
3 years ago
f8e850bbfa
New Crowdin translations by Github Action ( #13556 )
...
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: ricky <ricky.miller@gmail.com>
3 years ago
78f4684b2a
MetaMetrics: Add EVENT.CATEGORIES const ( #14474 )
...
* MetaMetrics: add EVENT.CATEGORIES const
* MetaMetrics: add EVENT.CATEGORIES.INPAGE_PROVIDER
* MetaMetrics: add EVENT.CATEGORIES.AUTH
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 1
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 2
confirm we want to use 'Accounts' instead of 'Account'
* MetaMetrics: add EVENT.CATEGORIES.MESSAGES
* MetaMetrics: add EVENT.CATEGORIES.RETENTION const
* MetaMetrics: add EVENT.CATEGORIES.SETTINGS
* MetaMask: add missing EVENT.CATEGORIES.SNAPS
* MetaMetrics: add EVENT.CATEGORIES.WALLET const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING
& EVENT.CATEGORIES.TRANSACTIONS consts
* MetaMetrics: use EVENT.CATEGORIES
* ducks/swaps: revert slice name
* MetaMetrics: add missing EVENT.CATEGORIES.NETWORK
3 years ago
d0ed2c1afc
MetaMetrics: add 'number_of_nfts' user trait ( #14495 )
...
* MetaMetrics: add number_of_nfts trait
* MetaMetrics: memoize _getAllNFTAddresses
* MetaMetrics: fix lint / update JSDoc comments
* MetaMetrics: update nft trait logic
- https://github.com/MetaMask/metamask-extension/pull/14495#discussion_r855450898
* MetaMetrics: rn _getAllNFTs > _getAllNFTsFlattened
3 years ago
fbeae57247
Add testnet name as prefix for native currency of preloaded testnets ( #14454 )
...
* add testnet name as prefix for native currency of preloaded testnets
3 years ago
cef95f8733
Stop storing request and response objects in the permission activity log ( #14485 )
...
We currently store the JSON-RPC request and response objects in the permission activity log. The utility of doing this was always rather dubious, but never problematic. Until now.
In Flask, as the restricted methods have expanded in number, user secrets may be included on JSON-RPC message objects. This PR removes these properties from the permission activity log, and adds a migration which does the same to existing log objects. We don't interact with the log objects anywhere in our codebase, but we don't want unexpected properties to cause errors in the future should any log objects be retained.
This PR also updates relevant tests and test data. It makes a minor functional change to how a request is designated as a success or failure, but this should not change any behavior in practice.
3 years ago
6a06374784
Dark Mode: Implement Metrics ( #14455 )
3 years ago
e702da2194
Modify import SRP page ( #14425 )
...
* Modify Import SRP page
3 years ago
bcdd52f55a
Dark Mode: Implement Metrics ( #14455 )
3 years ago
52b043c4f2
HoldToRevealButton component ( #13785 )
...
* Created 'HoldToRevealButton' component
* Added new line within the .svg files
* Lint fix
* CSS fix according to BEM
* Modified unit test
3 years ago
21e54f4717
MetaMetrics: Identify 'number_of_tokens' user trait ( #14427 )
...
* MetaMetrics: identify number_of_tokens
* MetaMetrics: update number_of_tokens
do not filter by unique addresses.
Each token contract x chain id combo is a unique contract
* MetaMetrics: update MetaMetricsTraits @typedef
- add number_of_tokens
* MetaMetrics: clean up number_of_tokens
* MetaMetrics: alphabetize in test
3 years ago
e7bb8e2663
MetaMetrics: Identify 'nft_autodetection_enabled' & 'opensea_api_enabled' ( #14367 )
...
* MetaMetrics: alphabetize traits
* MetaMetrics: identify nft_autodetection_enabled
* MetaMetrics: identify opensea_api_enabled
* metametrics.test: alphabetize traits
* metametrics.test: add new traits
- nft_autodetection_enabled
- opensea_api_enabled
* MetaMetrics: @property use string literals
* MetaMetrics.test: update with openSeaEnabled & useCollectibleDetection
* MetaMetrics: alphabetize
* MetaMetrics: update MetaMetricsTraits @typedef
- add nft_autodetection_enabled
- add opensea_api_enabled
3 years ago
0c52723885
Update segment instantiation check. Only check if SEGMENT_WRITE_KEY exists ( #14407 )
...
* segment: instantiate w/out SEGMENT_HOST check
If SEGMENT_HOST is null, then the analytics-node library will usea defaulted host
* Segment: rm IN_TEST check for instantiation
3 years ago
54ac00027b
unblock ci: update vuln deps + fix npm registry for snaps firefox ( #14437 )
...
* dep-audit-fix for async@2.6.3
* deps - update async for vuln fix and remove patch
* deps/ci-yarn-audit - remove outdated ignored vulns
* deps/lock - deduplicate async@2
* deps/lock - deduplicate async@2 + remove indirectly used dep
* Use regular NPM registry for snaps on Firefox (#14439 )
* Use regular NPM registry for snaps on FF
* Fix linting
* Update app/scripts/metamask-controller.js
Co-authored-by: Shane <jonas.shane@gmail.com>
Co-authored-by: kumavis <kumavis@users.noreply.github.com>
Co-authored-by: Shane <jonas.shane@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Shane <jonas.shane@gmail.com>
3 years ago
0f4417684b
unblock ci: update vuln deps + fix npm registry for snaps firefox ( #14437 )
...
* dep-audit-fix for async@2.6.3
* deps - update async for vuln fix and remove patch
* deps/ci-yarn-audit - remove outdated ignored vulns
* deps/lock - deduplicate async@2
* deps/lock - deduplicate async@2 + remove indirectly used dep
* Use regular NPM registry for snaps on Firefox (#14439 )
* Use regular NPM registry for snaps on FF
* Fix linting
* Update app/scripts/metamask-controller.js
Co-authored-by: Shane <jonas.shane@gmail.com>
Co-authored-by: kumavis <kumavis@users.noreply.github.com>
Co-authored-by: Shane <jonas.shane@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Shane <jonas.shane@gmail.com>
3 years ago
922ebd57cb
track address book usage ( #14382 )
...
* track address book usage
* Update app/scripts/controllers/metametrics.js
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
* Update shared/constants/metametrics.js
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
3 years ago
455d4a9825
Update DetectTokenController for token detection V2 ( #14216 )
3 years ago
Dan J Miller
Brad Decker
Lachlan Tweedie
Hassan Malik
Ariella Vu
Niranjana Binoy
Daniel
Frederik Bolding
Alex Donesky
Mark Stacey
kumavis
Erik Marks
Shane
ryanml
Guillaume Roux
David Walsh
Hennadii Ivtushok
kumavis
amerkadicE
MetaMask Bot
VSaric
filipsekulic