b0890b6b32
Enforce a single boolean attr notation in JSX ( #7465 )
...
This changeset enables the ESLint rule enforcing a single notation for boolean
attributes in JSX—explictly setting the value to `true` is no longer allowed
(as it was never needed).[1]
From the docs for JSX:[2]
> If you pass no value for a prop, it defaults to `true`.
[1]:https://github.com/yannickcr/eslint-plugin-react/blob/80935658/docs/rules/jsx-boolean-value.md
[2]:https://reactjs.org/docs/jsx-in-depth.html#props-default-to-true
I have chosen to use this default as it the most consistent with HTML (a la
`checked` and `disabled`).
5 years ago
2673eef3c4
Redesign approve screen ( #7271 )
...
* Redesign approve screen
* Add translations to approve screen components
* Show account in header of approve screen
* Use state prop bool for unlimited vs custom check in edit-approval-permission
* Set option to custom on input change in edit-approval-permission
* Allow setting of approval amount to unlimited in edit-approval-permission
* Fix height of confirm-approval popup
* Ensure decimals prop passted to confirm-approve.component is correct type
* Ensure first param passed to calcTokenValue in confirm-approve.util is the correct type
* Fix e2e test of permission editing
* Remove unused code from edit-approval-permission.container
5 years ago
31175625b4
Folder restructure ( #6304 )
...
* Remove ui/app/keychains/
* Remove ui/app/img/ (unused images)
* Move conversion-util to helpers/utils/
* Move token-util to helpers/utils/
* Move /helpers/*.js inside /helpers/utils/
* Move util tests inside /helpers/utils/
* Renameand move confirm-transaction/util.js to helpers/utils/
* Move higher-order-components to helpers/higher-order-components/
* Move infura-conversion.json to helpers/constants/
* Move all utility functions to helpers/utils/
* Move pages directory to top-level
* Move all constants to helpers/constants/
* Move metametrics inside helpers/
* Move app and root inside pages/
* Move routes inside helpers/
* Re-organize ducks/
* Move reducers to ducks/
* Move selectors inside selectors/
* Move test out of test folder
* Move action, reducer, store inside store/
* Move ui components inside ui/
* Move UI components inside ui/
* Move connected components inside components/app/
* Move i18n-helper inside helpers/
* Fix unit tests
* Fix unit test
* Move pages components
* Rename routes component
* Move reducers to ducks/index
* Fix bad path in unit test
6 years ago
e16f5ab54d
Fix tests
6 years ago
d19c42fcae
Add fallback when no function found, fix network colors, add fiat values for tokens with contract exchange rates
6 years ago
ea9d51e427
Refactor and redesign confirm transaction views
7 years ago
Whymarrh Whitby
Dan J Miller
Chi Kei Chan
Alexander Tseung