ciphermask

Commit Graph

Author	SHA1	Message	Date
Mark Stacey	3620146e63	Remove unused `transForward` state and actions (#8401 ) The `transForward` app state is no longer used, so it has been removed. Associated actions have been removed as well. This state dates back a few years, so I was unable to determine when it was made obsolete.	5 years ago
Mark Stacey	5fe25e41b7	Remove unused network nonce state (#8395 ) This state hasn't been used since #5886. The nonce we display in our UI is now from the background, rather than queried directly from the front-end. This also means we save making this network call each time a pending transaction is added, and each time the transaction list is mounted.	5 years ago
Mark Stacey	b0b99fa748	Move action constants to separate module (#8308 ) The "global" action constants (the ones previously in `actions.js`) have been moved to a separate module. This was necessary to avoid a circular dependency in an upcoming change that was causing problems. In general the "ducks" pattern of organizing Redux stores does result in circular dependency problems. This is because reuse of actions between reducers is encouraged, so it's not uncommon for two reducers to want to reference an action from the other. Going forward we can avoid this problem by moving action constants that are shared between reducers into this shared module.	5 years ago

Author

SHA1

Message

Date

Mark Stacey

3620146e63

Remove unused `transForward` state and actions (#8401 )

The `transForward` app state is no longer used, so it has been removed.
Associated actions have been removed as well.

This state dates back a few years, so I was unable to determine when it
was made obsolete.

5 years ago

Mark Stacey

5fe25e41b7

Remove unused network nonce state (#8395 )

This state hasn't been used since #5886. The nonce we display in our UI
is now from the background, rather than queried directly from the
front-end.

This also means we save making this network call each time a pending
transaction is added, and each time the transaction list is mounted.

5 years ago

Mark Stacey

b0b99fa748

Move action constants to separate module (#8308 )

The "global" action constants (the ones previously in `actions.js`)
have been moved to a separate module. This was necessary to avoid a
circular dependency in an upcoming change that was causing problems.

In general the "ducks" pattern of organizing Redux stores does result
in circular dependency problems. This is because reuse of actions
between reducers is encouraged, so it's not uncommon for two reducers
to want to reference an action from the other. Going forward we can
avoid this problem by moving action constants that are shared between
reducers into this shared module.

5 years ago

3 Commits (3620146e63dea84783c25724767994377a829d7f)