hilvmason
8223aecabf
Update PULL_REQUEST_TEMPLATE.md ( #14547 )
3 years ago
kumavis
a7469979b4
Patch gridplus-sdk for perf fix ( #14582 )
...
short-term fix for https://github.com/GridPlus/gridplus-sdk/pull/367
3 years ago
Erik Marks
73a7ce9e39
Add applyLavaMoat build flag ( #14583 )
...
Adds a new flag, `--apply-lavamoat`, to the main build script. The flag controls whether LavaMoat is actually applied to the output of the build process. The flag defaults to `true`, but we explicitly set it to `false` in the `start` package script. Meanwhile, the `start:lavamoat` script is modified such that it applies LavaMoat to the build output in development mode, but it no longer runs the build process itself under LavaMoat as there aren't very compelling reasons to do so.
This change is motivated by the fact that development builds do not have their own dedicated LavaMoat policies, which causes development builds to fail since #14537 . The downside of this change is that LavaMoat-related failures will not be detected when running `yarn start`. @kumavis has plans for fixing this problem in a future major version of the `@lavamoat` suite.
3 years ago
Brad Decker
54a89f029e
fix cross-fetch moderate vulnerability alert ( #14570 )
3 years ago
Alex Donesky
12a088e638
Fix browser.tab.get call ( #14550 )
...
* update to expect promise from browser api polyfill rather than pass callback
3 years ago
Shane
7da6c66ea2
Added getAccounts suppressUnauthorized param ( #14126 )
...
* Added getAccounts suppressUnauthorized param
* Changed getAccounts supresss unauth param name
* Changed getAccounts param to object
* Fixed default empty obj for getAccounts getPermittedAccounts param
* Bump eth-json-rpc-middleware version to 8.0.2
* Fixed lavamoat policy
* Fixed lavamoat policies
* Fixed dedupe issues
* Fixed lavamoat allowscripts
* yarn deduplicate
* Fixed lavamoat policies
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
3 years ago
Thomas Huang
d139e69545
Unit test proptype ( #14509 )
...
* Confirm page container content currentTransaction proptype change string to object
* Add title prop
3 years ago
ryanml
16bfd2f334
Merge pull request #14562 from MetaMask/master-sync
...
Sync `master` with `develop`
3 years ago
ryanml
fd3eabf327
Revert "Revert "Dark Mode: What's New Announcement ( #14346 )""
...
This reverts commit 9cea6f57ef
.
3 years ago
ryanml
f19173b0f2
Merge remote-tracking branch 'origin/develop' into master-sync
3 years ago
kumavis
66bd172980
Lavamoat - protect all UI contexts ( #14537 )
...
* lavamoat - apply lavamoat protections to popup and notification
* build - enable lavamoat for home
* lavamoat - add missing ui overrides for react family
* deps/patches - patch zxcvbn for ses compat
3 years ago
ryanml
7a627680a8
Merge pull request #14478 from MetaMask/Version-v10.14.0
...
Version v10.14.0 RC
3 years ago
Frederik Bolding
1624af2364
snaps-skunkworks@0.11.1 ( #14531 )
...
* snaps-skunkworks@0.11.0
* Update LavaMoat policies
* Fix breaking changes
* Use SnapController:clearSnapState
* Fix fetch properly
* Bump iframe execution environment
* snaps-skunkworks@0.11.1
* Run allow-scripts auto
3 years ago
George Marshall
ad1abaaef4
Updating text/muted to text/alternative for select text on home screen ( #14553 )
3 years ago
Guillaume Roux
6309d53650
Dark Mode : Add OS option in theme selection dropdown ( #14379 )
3 years ago
David Walsh
b29b48836e
Update Dark Mode What's New message ( #14535 )
3 years ago
ryanml
022c141ee8
Adding 'Swaps' to metametrics event categories ( #14538 )
3 years ago
Bowen Sanders
c1e53b3330
Create new e2e test for bip-44 snap in test-snaps ( #14440 )
...
* created new test for bip-44 snap test
* added driver.Key.SPACE to allow sending spacebar
* made changes to final result check
* fixed expected pk result to proper value
* fixed to use npm package instead of local
* removed comment
* removed const delay - not needed (lint error)
3 years ago
Hennadii Ivtushok
72d2977e72
Warn about multiple MetaMask instances running ( #13836 )
...
* Add text warning on startup page
* Try to detect extensions with browser API
* Setup messaging between different versions of extension
* Cleanup
* Cleanup
* Simplify check for multiple instances running
* Fix a doc string + use webextension-polyfill
* Fix test
* Mock webextension-polyfill
* Mock correctly
* Catch error and show warning in both extensions
* Mock as promise
* Address comments
* Rename build ids
* Run detection code only if Chrome
* Add Firefox warnings
* Cleanup imports
* Update connection ids
* Run detection code for Firefox
* Add test
* Add missing await
* Update tests
* Cleanup
* Cleanup
* Improve testing
* Improve tests
* Log errors from sendMessage
* Cleanup
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
3 years ago
Shane
74b5401302
Fixed API for watchAsset ( #14545 )
...
* Fixed API for watchAsset
* Fixed boolean return value for watchAsset
3 years ago
Frederik Bolding
27ad7279cd
Rename NotificationController to AnnouncementController ( #14389 )
...
* Rename NotificationController to AnnouncementController
* Fix test
* Add test for missing NotificationController state
* Bump controllers
* Move test to correct file
* Rename config key
* Add migration 71 to list of migrations
* Fix selector after migration
3 years ago
ryanml
5568558554
Adjust package version to 10.13.0 ( #14540 )
3 years ago
ryanml
22df2afcb2
Updating changelog
3 years ago
Guillaume Roux
71d0873ded
Add token standard to custom token details ( #14506 )
...
* use getTokenStandardAndDetails to get token standard
* remove console.log and fix test
* remove console.log
3 years ago
Guillaume Roux
7a9662b88e
Add token standard to custom token details ( #14506 )
...
* use getTokenStandardAndDetails to get token standard
* remove console.log and fix test
* remove console.log
3 years ago
kumavis
223124a561
lavamoat@6 - update to secure package naming ( #14488 )
3 years ago
ryanml
0c49bc14d4
Fixing 'Learn more' casing on import token screen ( #14529 )
3 years ago
Brad Decker
193c22588e
call controller methods directly in send duck ( #14465 )
3 years ago
ryanml
9cea6f57ef
Revert "Dark Mode: What's New Announcement ( #14346 )"
...
This reverts commit af963d7f7b
.
3 years ago
Alex Donesky
cf2c6a3164
show token approval details on confirm approve screen by default ( #14523 )
3 years ago
kumavis
37272ad923
i18n - remove unused locale strings ( #14527 )
3 years ago
Brad Decker
f567a3fe86
Do not show failed off-chain transactions details when grouped with another valid transaction of same nonce ( #14497 )
...
* fix failed off chain tx mismatch with next confirmed transaction
* dont drop failed txs when tx in confirmed
* add comment for reassigning logic
* resolve change requests
3 years ago
amerkadicE
ef6fb86f50
Update for a new Add network page ( #13866 )
3 years ago
amerkadicE
8fef9fd8df
Update display of switching current network ( #13450 )
...
Co-authored-by: Amer Kadic <amerkadic@Amers-MacBook-Pro.local>
Co-authored-by: George Marshall <george.marshall@consensys.net>
3 years ago
Dan J Miller
16fe8744a6
Ensure network name in confirm page container is defined ( #14520 )
3 years ago
Dan J Miller
284bab1cbc
Ensure network name in confirm page container is defined ( #14520 )
3 years ago
MetaMask Bot
f8e850bbfa
New Crowdin translations by Github Action ( #13556 )
...
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: ricky <ricky.miller@gmail.com>
3 years ago
Ariella Vu
78f4684b2a
MetaMetrics: Add EVENT.CATEGORIES const ( #14474 )
...
* MetaMetrics: add EVENT.CATEGORIES const
* MetaMetrics: add EVENT.CATEGORIES.INPAGE_PROVIDER
* MetaMetrics: add EVENT.CATEGORIES.AUTH
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 1
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 2
confirm we want to use 'Accounts' instead of 'Account'
* MetaMetrics: add EVENT.CATEGORIES.MESSAGES
* MetaMetrics: add EVENT.CATEGORIES.RETENTION const
* MetaMetrics: add EVENT.CATEGORIES.SETTINGS
* MetaMask: add missing EVENT.CATEGORIES.SNAPS
* MetaMetrics: add EVENT.CATEGORIES.WALLET const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING
& EVENT.CATEGORIES.TRANSACTIONS consts
* MetaMetrics: use EVENT.CATEGORIES
* ducks/swaps: revert slice name
* MetaMetrics: add missing EVENT.CATEGORIES.NETWORK
3 years ago
Thomas Huang
34d43e66ca
Update tx data for simpleSends and add isBestQuote to swaps data ( #14496 )
3 years ago
ricky
0fd1cea1fe
Feature/remove bitmask ( #14489 )
...
* remove bitmask
* add --fail-on-missing-exclusions
* add .iyarc
3 years ago
Ariella Vu
d0ed2c1afc
MetaMetrics: add 'number_of_nfts' user trait ( #14495 )
...
* MetaMetrics: add number_of_nfts trait
* MetaMetrics: memoize _getAllNFTAddresses
* MetaMetrics: fix lint / update JSDoc comments
* MetaMetrics: update nft trait logic
- https://github.com/MetaMask/metamask-extension/pull/14495#discussion_r855450898
* MetaMetrics: rn _getAllNFTs > _getAllNFTsFlattened
3 years ago
ryanml
c9b00541cd
Updating lavamoat policies
3 years ago
Alex Donesky
fbeae57247
Add testnet name as prefix for native currency of preloaded testnets ( #14454 )
...
* add testnet name as prefix for native currency of preloaded testnets
3 years ago
Elliot Winkler
c25c0432ed
Fix ESLint config around files w/ CommonJS imports ( #14380 )
...
The `parserOptions.sourceType` config option in `.eslintrc.js` is used
to distinguish files that use ESM imports vs. files that do not.
The `import` plugin, specifically the `import/ambiguous` rule behaves
differently depending on this value. If a file is marked with
`sourceType` of `"module"`, then this rule will attempt to ensure that
the file does indeed have ESM imports and/or exports; otherwise it does
nothing.
In other words, files that use CJS imports are *not* "modules" according
to this setting, and therefore should not be marked with a `sourceType`
of `"module"`. This means we do not have to turn off the
`import/ambiguous` rule, as it will no longer trip up on these types of
files.
3 years ago
Olusegun Akintayo
095cc94ed0
Add new token added event (duplicating the existing event structure) when collectible is manually added ( #14279 )
...
* Add new token added event (duplicating the existing event structure) when auto detection occurs for NFTs
Set source property to detected on the new token added event,
3 years ago
Brad Decker
8f47c19b9d
increase test coverage of nonce sorted transaction selector ( #14486 )
3 years ago
Dan J Miller
5b0d465d30
Fix the alerts toggles in settings ( #14498 )
3 years ago
Dan J Miller
617b7828a5
Disable swaps whenever the environment is not development or testing, so that behaviour follows production for QA purposes ( #14499 )
3 years ago
Dan J Miller
3ecc04e42d
Fix the alerts toggles in settings ( #14498 )
3 years ago
Dan J Miller
b1df04c253
Disable swaps whenever the environment is not development or testing, so that behaviour follows production for QA purposes ( #14499 )
3 years ago