ciphermask

Commit Graph

Author	SHA1	Message	Date
Dan Finlay	95bcc21a06	Add useful nodeify error message If a nodified method does not return a Promise, it will throw an error, like this: ``` Error in event handler for (unknown): Error: The function setSelectedAccount did not return a Promise, but was nodeified. ```	8 years ago
Dan Finlay	9e764b1935	Fix nodeify	8 years ago
Dan Finlay	80e76b45ee	Denodeify most of KeyringController Mostly Fixes #893 A couple methods cache callbacks, and will require a larger refactor to fully denodeify. Specifically, our methods involving web3 requests to sign a tx, sign a message, and approve or cancel either of those. I think we should postpone those until the TxManager refactor, since it will likely handle this response caching itself.	8 years ago

Author

SHA1

Message

Date

Dan Finlay

95bcc21a06

Add useful nodeify error message

If a nodified method does not return a Promise, it will throw an error, like this:
```
Error in event handler for (unknown): Error: The function setSelectedAccount did not return a Promise, but was nodeified.
```

8 years ago

Dan Finlay

9e764b1935

Fix nodeify

8 years ago

Dan Finlay

80e76b45ee

Denodeify most of KeyringController

Mostly Fixes #893

A couple methods cache callbacks, and will require a larger refactor to fully denodeify.

Specifically, our methods involving web3 requests to sign a tx, sign a message, and approve or cancel either of those.

I think we should postpone those until the TxManager refactor, since it will likely handle this response caching itself.

8 years ago

3 Commits (a20a237282c38da86b03625d08b48c2e58e83523)