c4a3d4ea82
Remove unneeded array cloning in getSendToAccounts selector
...
The use of `Object.entries` here to map the accounts into a new array effectively
produces a shallow clone of the array without guaranteeing the order of the original
array (as object iteration order is implementation-specific and variable). From MDN [1]:
> The **`Object.entries()`** method returns an array of a given object's own enumerable
> string-keyed property `[key, value]` pairs, in the same order as that provided by a
> `for...in` loop
And also:
> The ordering of the properties is the same as that given by looping over the
> property values of the object manually.
Both of which suggest that the iteration order is the same as `for...in`, which is to
say that it's not specified. [2] [3]
This changeset removes the cloning, keeping the shallow clone created the line before
which preserves the order of the items in the array.
[1]:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
[2]:https://stackoverflow.com/a/5525820/1267663
[3]:https://stackoverflow.com/a/30919039/1267663
6 years ago
2786932576
repeated getSelectedAddress() func send.selectors.js removed ( #6056 )
6 years ago
d7a2ea9a2b
Add Localhost 8545 for network dropdown names
6 years ago
c80b295ccc
Only pass english function names to functionType metric
6 years ago
5d948360c0
Distinguish between token and eth selected in home screen send button metrics event.
6 years ago
5454266d7c
Metrics tracking gas changed - slow, average, fast, custom - on edit screen.-
6 years ago
4963ed65c0
Track seed phrase validation errors with MetaMetrics
6 years ago
6a80ff2718
Change coinbase to wyre
6 years ago
95a2480074
Fix display of gas chart on Ethereum networks ( #6389 )
6 years ago
a46ec83c9b
Remove NoticeController ( #6382 )
6 years ago
4055dc3475
Remove unused account-dropdowns components ( #6363 )
6 years ago
05fd704fef
Check token name constants against the lower case methodData name in conf tx switch container.
6 years ago
8458873a20
Ensure correct confirm screen in case of smartcontract check fail
6 years ago
adcf03eacc
About tab copy changes; Update route for Info & Help in account menu ( #6356 )
6 years ago
1d14646a4c
Revert to providing inline defaults in getHexGasTotal and increaseLastGasPrice ( #6361 )
6 years ago
19c2b298f1
Further e2e fixes in wake of #6364 and #6367 ( #6374 )
...
* getMethodData() default to abi decoded method if registry lookup errors
* Update e2e tests to work with getMethodData() fallback changes
* Remove indeterminency in gas input key entering in send token e2e test.
6 years ago
0961449ca0
send-footer.utils.js - addressIsNew - improve readability
6 years ago
02585c0bd0
lint fix
6 years ago
edec6cb81d
actions - setCompletedOnboarding - make async with pify
6 years ago
356ef794f2
prevent add duplicates when address is not new
6 years ago
b004b182bf
depoit-ether-modal - make buyEth args more explicit
6 years ago
31d8b279e4
Defaults to the args list in increaseLastGasPrice and getHexGasTotal
6 years ago
0346089caa
getHexGasTotal and increaseLastGasPrice now gracefully handle null and undefined values
6 years ago
8108eac705
Open retore-vault route from popup ( #6353 )
6 years ago
ef4894b9a0
Don't include tx value in calculation of balance sufficiency for cancel button disabling. ( #6346 )
6 years ago
2f13a97d00
Cancel error rebased ( #6341 )
...
* Check balance before showing cancel
* Fix linter
* Use existing helper methods for calculating increased cancel price
* Add tooltip for disabled button
* Lint fix for cancelError branch.
* Disabling of cancel button should account for value of tx.
6 years ago
69f7968c70
Close transaction on close of notification window ( #6340 )
6 years ago
961ad267df
New settings page rebased ( #6333 )
...
* New setting tab
* Add InfoTab
* Add Advanced tab
* Add Security Tab
* Finish mobile view
* Make new setting page responsive
* Fix linter
* Fix y scrolling
* Update link in network dropdown
* Fix e2e tests
* Remove duplicate translation key
* Resolve merge conflict
* Only change settings header in popup view.
* Place mobile-sync button in advanced-tab of settings
6 years ago
4ff9126ff2
Replaces the coinbase link in the deposit modal with one for wyre ( #6302 )
6 years ago
174ec2d596
Fix oversized loading overlay on gas customization modal. ( #6326 )
6 years ago
2b992d2946
Fix gas fee in the submitted step of the transaction details activity log. ( #6301 )
6 years ago
468bc96bdf
Hide gas price chart and prevent api call when not on ethereum networks. ( #6300 )
...
Add missing translations in gas customization modal
6 years ago
31175625b4
Folder restructure ( #6304 )
...
* Remove ui/app/keychains/
* Remove ui/app/img/ (unused images)
* Move conversion-util to helpers/utils/
* Move token-util to helpers/utils/
* Move /helpers/*.js inside /helpers/utils/
* Move util tests inside /helpers/utils/
* Renameand move confirm-transaction/util.js to helpers/utils/
* Move higher-order-components to helpers/higher-order-components/
* Move infura-conversion.json to helpers/constants/
* Move all utility functions to helpers/utils/
* Move pages directory to top-level
* Move all constants to helpers/constants/
* Move metametrics inside helpers/
* Move app and root inside pages/
* Move routes inside helpers/
* Re-organize ducks/
* Move reducers to ducks/
* Move selectors inside selectors/
* Move test out of test folder
* Move action, reducer, store inside store/
* Move ui components inside ui/
* Move UI components inside ui/
* Move connected components inside components/app/
* Move i18n-helper inside helpers/
* Fix unit tests
* Fix unit test
* Move pages components
* Rename routes component
* Move reducers to ducks/index
* Fix bad path in unit test
6 years ago
7287133e15
Enable mobile sync ( #6332 )
...
* enable mobile sync
* remove mobile sync as a preference
* Fix typo
6 years ago
e1af6312ce
Fixing spelling of Ethereum in MetaMetrics copy ( #6329 )
6 years ago
c43374a553
Clear notices when setCompletedOnboarding is called
6 years ago
29a0b34786
Allow seed phrases with a trailing newline
6 years ago
d288e59a9b
ui - add missing PropTypes ( #6287 )
6 years ago
48047f8194
mascara - remove from project ( #6283 )
6 years ago
17911dddff
Fixes the use of the browser back button on the reveal seed screen
6 years ago
ef7ac90bca
Remove line rather than comment out
6 years ago
22c4fe0469
No longer check network when validating checksum addresses
6 years ago
b8f143f1c3
Handle undefined gas limits and prices in transaction-breakdown.component ( #6246 )
6 years ago
be2d2bad4b
Add privacy policy link to modal metrics opt-in ( #6250 )
6 years ago
f74cd1aa3f
Prevent advanced gas input arrows from setting value to < 0 ( #6248 )
6 years ago
d547e0b80b
Only call onRecipient and onSender methods if defined in sender-to-recipient ( #6247 )
6 years ago
7160cef4c7
Fix missing this reference in addtoken button onclick method ( #6245 )
6 years ago
df0c7be808
Fixes the 'Percentages row tracks and gutters' decpracation warning. ( #6244 )
6 years ago
f334f4da15
Metametrics fixes ( #6238 )
...
* Improve opt-in opt-out event tracking after going 'back' in onboarding.
* Fix 'Switched Networks' metrics event.
* Fix custom variables ids (can only use ids 1-5)
* Fix tracking of function type custom variable for metametrics in confirm-transaction-base
* Add missing metametrics events
6 years ago
434e1aa04a
Wrap in span
6 years ago
Whymarrh Whitby
Sneh Koul
Thomas Huang
Dan Miller
Thomas Huang
Chi Kei Chan
kumavis
Jenny Pollack
kumavis
Bruno Barbieri
fixanoid