c4a3d4ea82
Remove unneeded array cloning in getSendToAccounts selector
...
The use of `Object.entries` here to map the accounts into a new array effectively
produces a shallow clone of the array without guaranteeing the order of the original
array (as object iteration order is implementation-specific and variable). From MDN [1]:
> The **`Object.entries()`** method returns an array of a given object's own enumerable
> string-keyed property `[key, value]` pairs, in the same order as that provided by a
> `for...in` loop
And also:
> The ordering of the properties is the same as that given by looping over the
> property values of the object manually.
Both of which suggest that the iteration order is the same as `for...in`, which is to
say that it's not specified. [2] [3]
This changeset removes the cloning, keeping the shallow clone created the line before
which preserves the order of the items in the array.
[1]:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
[2]:https://stackoverflow.com/a/5525820/1267663
[3]:https://stackoverflow.com/a/30919039/1267663
6 years ago
2786932576
repeated getSelectedAddress() func send.selectors.js removed ( #6056 )
6 years ago
0c5d9fc58d
fix npm ci bug (version mismatch)
6 years ago
7ceb1c63cc
Added Chrome limited site access solution doc ( #6422 )
6 years ago
a973a7420a
feature: switch token pricing to CoinGecko API ( #6424 )
6 years ago
d7a2ea9a2b
Add Localhost 8545 for network dropdown names
6 years ago
7e0006a7fd
Merge pull request #6428 from MetaMask/sharefile.com
...
Don't inject web3 on sharefile.com
6 years ago
24761326de
Don't inject web3 on sharefile.com
6 years ago
f3f6f8ca68
Merge pull request #6417 from MetaMask/metrics-updates
...
Metrics updates
6 years ago
9bd719d33a
Merge pull request #6420 from bbondy/patch-2
...
Fix links to MetamaskInpageProvider in porting_to_new_environment.md
6 years ago
7b13e9ae2e
Update porting_to_new_environment.md
...
This MetamaskInpageProvider file was moved out into its own repo, this updates the link to point to that repo.
6 years ago
79804ec79b
Version 6.3.2 ( #6418 )
6 years ago
c80b295ccc
Only pass english function names to functionType metric
6 years ago
5d948360c0
Distinguish between token and eth selected in home screen send button metrics event.
6 years ago
5454266d7c
Metrics tracking gas changed - slow, average, fast, custom - on edit screen.-
6 years ago
ac39a9b378
Merge pull request #6362 from MetaMask/metamaskbot-comment-content
...
Remove broken image walkthrough from metamaskbot comment
6 years ago
4963ed65c0
Track seed phrase validation errors with MetaMetrics
6 years ago
d610dfa870
Merge pull request #6401 from MetaMask/provider-error-fix
...
metamask-controller - use improved provider-as-middleware utility
6 years ago
98a2fb43fb
Merge pull request #6406 from MetaMask/remove-user-actions-controller
...
remove user actions controller
6 years ago
12cca73000
doc - publishing - typo fix ( #6399 )
6 years ago
55cb4bf907
pin eth-contract-metadata to last commit hash ( #6396 )
6 years ago
dc4c40414e
issue#5742
6 years ago
89693a2315
metamask-controller - use improved provider-as-middleware utility
6 years ago
b26a59dbbe
renaming registrar into registry
6 years ago
cf4eac3f2c
Merge pull request #6397 from MetaMask/wyre-deposit-modal
...
Change coinbase to wyre
6 years ago
6a80ff2718
Change coinbase to wyre
6 years ago
fee0da1ca3
bump ledger and trezor keyring ( #6395 )
6 years ago
95a2480074
Fix display of gas chart on Ethereum networks ( #6389 )
6 years ago
a46ec83c9b
Remove NoticeController ( #6382 )
6 years ago
4055dc3475
Remove unused account-dropdowns components ( #6363 )
6 years ago
259aa36941
Remove unused mascara directory ( #6360 )
6 years ago
87f393eb31
Merge pull request #6375 from MetaMask/Version-6.3.1
...
Version 6.3.1
6 years ago
57bcf1449c
Version 6.3.1
6 years ago
05fd704fef
Check token name constants against the lower case methodData name in conf tx switch container.
6 years ago
8458873a20
Ensure correct confirm screen in case of smartcontract check fail
6 years ago
adcf03eacc
About tab copy changes; Update route for Info & Help in account menu ( #6356 )
6 years ago
1d14646a4c
Revert to providing inline defaults in getHexGasTotal and increaseLastGasPrice ( #6361 )
6 years ago
0762aaa5da
Remove broken image walkthrough from metamaskbot comment
6 years ago
19c2b298f1
Further e2e fixes in wake of #6364 and #6367 ( #6374 )
...
* getMethodData() default to abi decoded method if registry lookup errors
* Update e2e tests to work with getMethodData() fallback changes
* Remove indeterminency in gas input key entering in send token e2e test.
6 years ago
125a95ba71
Merge pull request #6364 from MetaMask/prevent-infura-requests-e2e-tests
...
Prevent infura requests in e2e tests
6 years ago
3113114d51
Split e2e run-all commands onto multiple lines
6 years ago
5a1545b3e4
Run from-import e2e tests with additional account, to avoid conflict with accounts in earlier test runs
6 years ago
d927a3c20a
Use localhost instead of mainnent/infura for custom rpc tests in e2e tests.
6 years ago
7fc84f3cc0
ci: Add build:test Gulp task for e2e build
6 years ago
99f53f5827
e2e: Update Contract Interaction wording
6 years ago
643ddcb7d7
e2e: Skip approving token test
6 years ago
c3a605f27a
Merge pull request #6328 from MetaMask/clearNotices
...
Clear notices
6 years ago
133ed80aee
Merge pull request #6372 from MetaMask/addAddressIfNew
...
prevent add duplicates when address is not new
6 years ago
0961449ca0
send-footer.utils.js - addressIsNew - improve readability
6 years ago
ed381f5b2a
test - unit - ui - actions - setCompletedOnboarding - fix stub to call callback
6 years ago
Whymarrh Whitby
Sneh Koul
pldespaigne
Etienne Dusseault
Paul Bouchon
Thomas Huang
Thomas Huang
Brian R. Bondy
Dan J Miller
kumavis
Jenny Pollack
Esteban Miño
kumavis
Bruno Barbieri
Chi Kei Chan