- Now striping hex prefixed gas values, which may have been causing mis-estimation.
- Unified calculation logic to be entirely functional.
- Greatly simplified how the pending-tx form keeps updated form state.
Still needs a commit from @kumavis to ensure the background passes in a txMeta.txParams.gasPrice value.
Sorry apparently the gas fixes weren't in the last commit, but are in this one.
As reported in previous commit, fixes a bug where initial estimate is not derived from the network.
Also fixes a bug where clicking "reset" does not clear our custom validation warnings.
These were only separated originally so we could make the notification-based TX approval work, which provided its own buttons.
This two templates are logically highly coupled, and keeping them working while separate has been difficult at times, and has even required resorting to dubious practices, like using React's `refs` pattern.
This combines them into one fairly large component, but I think it's ok, we can still break this up into components, just not the separation that it had previously.
Calls to `personal_sign` are now:
- When hex encoded, preserved as hex encoded, but displayed as utf-8 text.
- When not hex encoded, decoded as utf-8 text as hex for signing.
- The messages proposed for signing are displayed as UTF-8 text.
- When the message cannot be rendered as UTF-8 text, it is displayed as hexadecimal.
Fixes#1173
Kevin Serrano
Nickyg
frankiebee
Jared Pereira
kumavis
Dan Finlay
Kevin Serrano