ciphermask

Commit Graph

Author	SHA1	Message	Date
Alex Donesky	fc304680d4	Fix error that occurs when attempting to display transaction value for an approval transaction with no value argument in the transaction data (#15398 )	2 years ago
Brad Decker	c72199a1a6	update prettier (#15360 )	2 years ago
Daniel	f31bac9fbf	Performance improvements for Swaps (#15359 )	2 years ago
Brad Decker	652d631cda	remove exclusions for mismatched object jsdoc type casing (#15351 )	2 years ago
Brad Decker	1db0ee87ec	Update Eslint and deps (#15293 )	2 years ago
Alex Donesky	8536c86ed5	Improve `tokenId` parsing and clean up `useAssetDetails` hook (#15304 )	2 years ago
Filip Sekulic	7d321c48e0	Removed ui related code from shared directory (#15252 )	2 years ago
Alex Donesky	8d20c2834f	Add setApprovalForAll confirmation view (#15010 ) * enhance setApprovalForAll confirmation flow * cleanup * address feedback	2 years ago
Alex Donesky	4f0115fcdc	Add setApprovalForAll confirmation view (#15010 ) * enhance setApprovalForAll confirmation flow * cleanup * address feedback	2 years ago
Dan Miller	bc6c60cde1	Revert "Merge pull request #15063 from MetaMask/revert-v10.16.0" This reverts commit `4d42715220`, reversing changes made to `f09ab88891`.	2 years ago
Dan Miller	24662963c5	Revert "Merge pull request #15063 from MetaMask/revert-v10.16.0" This reverts commit `4d42715220`, reversing changes made to `f09ab88891`.	2 years ago
Mark Stacey	925a19fa4a	Revert "Merge pull request #14912 from MetaMask/Version-v10.16.0" This reverts commit `f09ab88891`, reversing changes made to `effc761e0e`. This is being temporarily reverted to make it easier to release an urgent fix for v10.15.1.	2 years ago
Alex Donesky	f561aeeef6	Fix to infinite loading on approve screen (#14756 )	2 years ago
Alex Donesky	b170211700	Fix to infinite loading on approve screen (#14756 )	2 years ago
Ariella Vu	b6ade44bc9	Slight cleanup of constants/transactions, useTransactionDisplayData, and TransactionIcon (#14784 ) * TransactionIcon: alphabetize categories * useTransactionDisplayData: rm repetitive comment * useTransactionDisplayData: mv signatureTypes * useTxDisplayData: import transactionGroup @typedef * userTxDisplayData: just vertical line spacing	3 years ago
Ariella Vu	70bdd9729f	Enables the "Safe Transaction From" copy for safeTransferFrom transactions (#14769 ) * useTransactionDisplayData:support safetransferfrom * useTransactionDisplayData: update test	3 years ago
Alex Donesky	5e55cf2cf2	add case in useTransactionDisplayData to handle transaction type safeTransferFrom (#14678 ) * add case in useTransactionDisplayData to handle transaction type safeTransferFrom * add test	3 years ago
Frederik Bolding	a96d40957b	Stop using 4bytes for contract deployment (#14598 )	3 years ago
Frederik Bolding	3b3a680682	Stop using 4bytes for contract deployment (#14598 )	3 years ago
Alex Donesky	fbeae57247	Add testnet name as prefix for native currency of preloaded testnets (#14454 ) * add testnet name as prefix for native currency of preloaded testnets	3 years ago
Daniel	eed6ae2b8c	Swaps: Sort "token_from" dropdown tokens by their fiat value first and "token_to" by top tokens (#14436 )	3 years ago
Dan J Miller	78f68b3dab	Fix speed-up/cancel: don't update existing transaction data (#14355 ) * Fix speed-up/cancel: don't update existing transaction data * Move retryTxMeta state management to useGasFeeInputs.js * Handle initial retryTxMeta set if no transaction is passed to useGasFeeInputs * Ensure previousGas is use on retry transaction if it is available in useGasFeeInputs * Remove update transaction mock and correctly test gas fee increase scenarios now that updateTransaction used in cancel-speedup is defined on the front end	3 years ago
Dan J Miller	b7b041c43b	Fix speed-up/cancel: don't update existing transaction data (#14355 ) * Fix speed-up/cancel: don't update existing transaction data * Move retryTxMeta state management to useGasFeeInputs.js * Handle initial retryTxMeta set if no transaction is passed to useGasFeeInputs * Ensure previousGas is use on retry transaction if it is available in useGasFeeInputs * Remove update transaction mock and correctly test gas fee increase scenarios now that updateTransaction used in cancel-speedup is defined on the front end	3 years ago
Guillaume Roux	4b3977044f	Swap : Fix undefined icon url (#14411 )	3 years ago
Niranjana Binoy	07231e42b2	Update token detection logic to only control auto-detection (#14251 )	3 years ago
Dan J Miller	09512c7148	Improvements for multi-layer fee UX (#13547 ) * Show fiat on confirm screen on multilayer-fee network * Disable gas editing on optimism * Fix send max mode on optimism * Represent layer 2 gas fee as a single value * Hide gas fee edit UI on optimism * Improvement multilayer-fee-message styling * Lint fix * Fix locales * Remove unnecessary code change Co-authored-by: David Walsh <davidwalsh83@gmail.com>	3 years ago
Olusegun Akintayo	c54f9b3097	update gas fees (#13646 ) * Draft methods to brak updateTransaction into smaller more targeted methods. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * This is a combination of 76 commits. normalize and validate tx params. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Method to normalize tx and check if it's unapproved. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Move the methods to controllers/transactions/index.js Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Flesh out the methods to update transaction with custom notes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> enforce that only the properties for the specific methid can be updated via the method. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Test update gas fees Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update swap approval transaction Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> use lodash to remove undefined properties update swap transaction tests Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Updates transaction user settings. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Add more parameters to updateSwapTransaction approvalTxId estimatedBaseFee Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Add Update Transaction Metrics Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update transaction gas fees actions.js Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update EIP 1559 Params. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint Fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Documentations. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Remove metrics from this PR Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes: Removed unused variables Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Add more params to updateTransactionGasFees. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update eip1559 method to editableParams. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Fix Mocha tests Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> add gasPrice to updateEditableParams Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Remove duplicated Params in notes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> A few more tests to cover if transaction status is not unapproved transaction is passed more parameters than it requires. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update Transaction Gas Fees. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update gas fees in edit-gas-popover. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Remove metrics. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update gas settings and user settings. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Fix unit tests. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Draft methods to brak updateTransaction into smaller more targeted methods. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> normalize and validate tx params. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Method to normalize tx and check if it's unapproved. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Move the methods to controllers/transactions/index.js Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Flesh out the methods to update transaction with custom notes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Test update gas fees Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update swap approval transaction Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> use lodash to remove undefined properties update swap transaction tests Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Updates transaction user settings. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Add Update Transaction Metrics Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update transaction gas fees actions.js Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update EIP 1559 Params. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint Fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Documentations. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Remove metrics from this PR Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes: Removed unused variables Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Add more params to updateTransactionGasFees. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update eip1559 method to editableParams. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Fix Mocha tests Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> add gasPrice to updateEditableParams Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Remove duplicated Params in notes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> A few more tests to cover if transaction status is not unapproved transaction is passed more parameters than it requires. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update Transaction Gas Fees. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Remove metrics. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Update gas settings and user settings. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Fix unit tests. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Remove dup;icated method from rebase. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> unrelated change Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Force re-run workflow Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fix Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Do not hideLoading since we're not showing it. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> UpdateTransaction should be renamed to updateGasFees Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> updateGasFees in gas-modal-page-container. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> fix: update previous gas params update method add types to the jsdoc comments. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> updateTransactionGasFees should have been updatePreviousGasParams Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Previous gas fees can be updated for confirmed transactions. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> add updatePreviousGasParams to mocked functions. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Lint fixes Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * we need to await the first dispatch before we call the second Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * update values to make tests pass Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * More changes to make e2e pass Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Need to wait a bit after save for changes to take effect. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Remove merge comments. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Await one dispatch before calling another Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * We don't need goHome anymore. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Tests must use async...await syntax too since we have await in the useTranasctionFunction Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Add delay after button click for values to update Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Wait a moment after clicking save for values to update Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Wait after clicking save... Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Merge update transaction gas fees and transaction user settings Show loading indicator on edit gas popover Fix tests. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Lint fixes Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * Fix JSDoc Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> * updatePreviousGasParams should also return updated transaction meta. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>	3 years ago
VSaric	30ef26101a	Remove the useSegmentContext function from metametrics.new.js (#14013 )	3 years ago
VSaric	5564176d72	Remove usages of useNewMetricEvent hook (#13955 )	3 years ago
Alex Donesky	e3ea4f2cd0	Fix issue where we show contract address as recipient when calling safe transfer method on erc721 or erc1155 contracts (#13535 ) * fix issue where we show contract address as recipient when calling safe transfer method on erc721 or erc1155 contracts * updates function name getTransactionData -> parseStandardTokenTransactionData, and adds documentation	3 years ago
Ariella Vu	69c2cd3a94	Permissions: convert hook to util (#13906 ) * Permissions: convert hook into helper util - instantiate once - freeze - alphabetize - add additional comments to @param https://github.com/MetaMask/metamask-extension/pull/13906#pullrequestreview-906554847	3 years ago
VSaric	060c6d651c	Remove usages of useMetricEvent hook (#13930 )	3 years ago
Alex Donesky	3747ace06b	Refactor token send/method confirmation flow (trimmed down) (#13788 ) * make use of getTokenStandardAndDetails method exposed on assetsContractController to determine how to represent the contract being interacted with in token contract method calls	3 years ago
Brad Decker	9cea401022	extract determineTransactionType from tx controller (#13737 )	3 years ago
Ariella Vu	34bf555e50	Fix v10.11: Unable to find value of key "eth_accounts" for locale "en" in Permissions Modal (#13833 ) * ConnectedAccountsPermissions: convert to FC * permissions: add usePermissionsDescriptions - fix ConnectedAccountsPermissions eth_accounts i18n * ConnectedAccountsPermissions: rm .component from path * ConnectedAccountsPermissions: fix toggleExpanded ensure we change previous state value Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>	3 years ago
Ariella Vu	aa89bb189b	Fix v10.11: Unable to find value of key "eth_accounts" for locale "en" in Permissions Modal (#13833 ) * ConnectedAccountsPermissions: convert to FC * permissions: add usePermissionsDescriptions - fix ConnectedAccountsPermissions eth_accounts i18n * ConnectedAccountsPermissions: rm .component from path * ConnectedAccountsPermissions: fix toggleExpanded ensure we change previous state value Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>	3 years ago
Jyoti Puri	6e8f4a6a76	gas fee details displayed on UI should be used gas estimates if available (#13809 )	3 years ago
Jyoti Puri	137b47370e	Confirm transaction page: show contract address details in title (#13683 )	3 years ago
Erik Marks	35ac762e10	Add Snaps via Flask (#13462 ) This PR adds `snaps` under Flask build flags to the extension. This branch is mostly equivalent to the current production version of Flask, excepting some bug fixes and tweaks. Closes #11626	3 years ago
Jyoti Puri	95eefc9630	Adding check for transaction.id in useTransactionEventFragment hook (#13587 )	3 years ago
Jyoti Puri	a06a0d21e0	Adding check for transaction.id in useTransactionEventFragment hook (#13587 )	3 years ago
Daniel	0dcc8d050f	Resolve a BigNumber issue (#13555 ) * Do not call `decimalToHex` for `minimumGasLimit`, which is already in hex * Add `0x` prefix when returning a gas estimate * Fix UTs Co-authored-by: Dan J Miller <danjm.com@gmail.com>	3 years ago
Daniel	8166d50578	Resolve a BigNumber issue (#13555 ) * Do not call `decimalToHex` for `minimumGasLimit`, which is already in hex * Add `0x` prefix when returning a gas estimate * Fix UTs Co-authored-by: Dan J Miller <danjm.com@gmail.com>	3 years ago
Jyoti Puri	760ed3457d	Removing EIP_1559_V2 feature flag (#13481 )	3 years ago
Jyoti Puri	cc1861a34e	Adding metrics events for EIP-1559 V2 flow (#13329 )	3 years ago
Alex Donesky	dc217dd536	Yet more NFT UX cleanups (#13435 ) * yet more nft ux cleanups	3 years ago
VSaric	5579061cfa	Proper calculation of the gas limit (#12784 )	3 years ago
dragana8	a67a5efca3	Incorrect Rounding Down of Balance #10167 (#13337 )	3 years ago
Alex Donesky	f087e501a1	Add modal with directions to re-add token as NFT (#13291 ) * Add modal pop for NFTs previously added as tokens - with directions to re-add as NFTs	3 years ago
Matthew Epps	a8ec876031	Fix token ordering: prioritize top before owned (#13270 )	3 years ago

1 2 3

144 Commits (f425e482e44814620d18058c4278df9e9ddfc9f1)