f77151003e
Send web3 usage metrics once per origin/property ( #9237 )
...
The usage metrics for the injected web3 instance were being sent upon
each use, which exceeded the limits of our Matomo plan. These metrics
are now only being sent upon the first usage, for each origin and
property.
4 years ago
aaacf66c6e
Fix import/no-extraneous-dependencies issues ( #9232 )
...
See [`import/no-extraneous-dependencies`](https://eslint.org/docs/rules/import/no-extraneous-dependencies ) for more information.
This change enables `import/no-extraneous-dependencies` and fixes the issues raised by the rule.
4 years ago
c2edc342fb
Remove unused buyEth fn from bg ( #9236 )
4 years ago
e021acdc0a
Fix max-statements-per-line issues ( #9218 )
...
See [`max-statements-per-line`](https://eslint.org/docs/rules/max-statements-per-line ) for more information.
This change enables `max-statements-per-line` and fixes the issues raised by the rule.
4 years ago
9e7841fa91
Consolidate ESLint config files ( #9231 )
4 years ago
04bfe3772c
Delete page-container.component.test.js ( #9229 )
4 years ago
2aa4b6bbee
Tidy up getAccountLink ( #9223 )
4 years ago
937616565d
Tidy ConnectHardwareForm#checkIfUnlocked ( #9224 )
...
This change tidies up the implementation of `ConnectHardwareForm#checkIfUnlocked`—passing
an `async` function to `forEach` doesn't ensure that the one is run before the other.
4 years ago
5d42a9b773
Fix require-unicode-regexp issues ( #9212 )
...
* Fix require-unicode-regexp issues
See [`require-unicode-regexp`](https://eslint.org/docs/rules/require-unicode-regexp ) for more information.
This change enables `require-unicode-regexp` and fixes the issues raised by the rule.
* Remove case-insensitive flag from regexps
4 years ago
884775cf71
Fix no-negated-condition issues ( #9222 )
...
See [`no-negated-condition`](https://eslint.org/docs/rules/no-negated-condition ) for more information.
This change enables `no-negated-condition` and fixes the issues raised by the rule.
4 years ago
c11888f287
Fix no-empty-function issues ( #9216 )
...
See [`no-empty-function`](https://eslint.org/docs/rules/no-empty-function ) for more information.
This change enables `no-empty-function` and fixes the issues raised by the rule.
4 years ago
9b78d3ab07
Fix import/extensions issues ( #9217 )
...
See [`import/extensions`](https://eslint.org/docs/rules/import/extensions ) for more information.
This change enables `import/extensions` and fixes the issues raised by the rule.
4 years ago
c188121c3d
Dedupe glob-parent versions ( #9220 )
4 years ago
3bd22a2058
Fix no-template-curly-in-string issues ( #9221 )
...
See [`no-template-curly-in-string`](https://eslint.org/docs/rules/no-template-curly-in-string ) for more information.
This change enables `no-template-curly-in-string` and fixes the issues raised by the rule.
4 years ago
944f6d4880
Fix no-process-exit issues ( #9219 )
...
See [`no-process-exit`](https://eslint.org/docs/rules/no-process-exit ) for more information.
This change enables `no-process-exit` and fixes the issues raised by the rule.
4 years ago
82a0ee27f3
Fix prefer-rest-params issues ( #9215 )
...
See [`prefer-rest-params`](https://eslint.org/docs/rules/prefer-rest-params ) for more information.
This change enables `prefer-rest-params` and fixes the issues raised by the rule.
4 years ago
146127c474
Fix no-prototype-builtins issues ( #9213 )
...
See [`no-prototype-builtins`](https://eslint.org/docs/rules/no-prototype-builtins ) for more information.
This change enables `no-prototype-builtins` and fixes the issues raised by the rule.
4 years ago
b91cf74d14
Fix no-nested-ternary issues ( #9214 )
...
See [`no-nested-ternary`](https://eslint.org/docs/rules/no-nested-ternary ) for more information.
This change enables `no-nested-ternary` and fixes the issues raised by the rule.
4 years ago
5991043cd7
Fix Etherscan redirect on notification click ( #9211 )
4 years ago
954df6e482
Fix no-constant-condition issues ( #9210 )
...
See [`no-constant-condition`](https://eslint.org/docs/rules/no-constant-condition ) for more information.
This change enables `no-constant-condition` and fixes the issues raised by the rule.
4 years ago
e8b31a77b9
Use copy-webpack-plugin@6.0.3 ( #9197 )
...
This updates the `copy-webpack-plugin` to the latest published version, 6.0.3,
resolving [a high-severity security advisory][1] with its `serialize-javascript`
dependency.
[1]: https://www.npmjs.com/advisories/1548
See https://www.npmjs.com/advisories/1548 for more information.
The `yarn audit` output:
```
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ high │ Remote Code Execution │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ serialize-javascript │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=3.1.0 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ copy-webpack-plugin │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ copy-webpack-plugin > serialize-javascript │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1548 │
└───────────────┴──────────────────────────────────────────────────────────────┘
```
The relevant [`v6.0.0`][2] breaking changes:
- minimum supported Node.js version is 10.13
- ✅ We use 10.18.1 locally and on CI
- the plugin now accepts an object, you should change `new CopyPlugin(patterns, options)` to `new CopyPlugin({ patterns, options })`
- ✅ Updated `.storybook/webpack.config.js`
[2]:https://github.com/webpack-contrib/copy-webpack-plugin/releases/tag/v6.0.0
4 years ago
42e7d205b2
Fix no-dupe-else-if issues ( #9208 )
...
See [`no-dupe-else-if`](https://eslint.org/docs/rules/no-dupe-else-if ) for more information.
This change enables `no-dupe-else-if` and fixes the issues raised by the rule.
4 years ago
853b89e314
Fix no-global-assign issues ( #9209 )
...
See [`no-global-assign`](https://eslint.org/docs/rules/no-global-assign ) for more information.
This change enables `no-global-assign` and fixes the issues raised by the rule.
4 years ago
438bb954ef
Merge pull request #9193
...
Update webpack Terser Plugin
4 years ago
cd370be728
Fix no-invalid-this issues ( #9207 )
...
See [`no-invalid-this`](https://eslint.org/docs/rules/no-invalid-this ) for more information.
This change enables `no-invalid-this` and fixes the issues raised by the rule.
4 years ago
c0f05ccae6
Fix implicit-arrow-linebreak issues ( #9201 )
...
See [`implicit-arrow-linebreak`](https://eslint.org/docs/rules/implicit-arrow-linebreak ) for more information.
This change enables `implicit-arrow-linebreak` and fixes the issues raised by the rule.
4 years ago
76bd7f98b6
Fix prefer-spread issues ( #9203 )
...
See [`prefer-spread`](https://eslint.org/docs/rules/prefer-spread ) for more information.
This change enables `prefer-spread` and fixes the issues raised by the rule.
4 years ago
310b15ba4a
Fix no-plusplus issues ( #9206 )
...
See [`no-plusplus`](https://eslint.org/docs/rules/no-plusplus ) for more information.
This change enables `no-plusplus` and fixes the issues raised by the rule.
4 years ago
548b0bbbd5
Fix no-eq-null issues ( #9205 )
...
See [`no-eq-null`](https://eslint.org/docs/rules/no-eq-null ) for more information.
This change enables `no-eq-null` and fixes the issues raised by the rule.
4 years ago
f8ebfc2f63
Update PreferencesController#_validateERC20AssetParams tests ( #9204 )
...
This change fixes the `_validateERC20AssetParams` tests, ensuring that the given
options are all valid except those that are being tested. Previously the `symbol`
property was invalid _in addition to_ the `decimals` property.
4 years ago
88f54e29fb
Fix no-empty issues ( #9202 )
...
See [`no-empty`](https://eslint.org/docs/rules/no-empty ) for more information.
This change enables `no-empty` and fixes the issues raised by the rule.
4 years ago
3346c2fc07
Fix no-loop-func issues ( #9199 )
...
See [`no-loop-func`](https://eslint.org/docs/rules/no-loop-func ) for more information.
This change enables `no-loop-func` and fixes the issues raised by the rule.
4 years ago
ef88d79fac
Fix no-useless-concat issues ( #9200 )
...
See [`no-useless-concat`](https://eslint.org/docs/rules/no-useless-concat ) for more information.
This change enables `no-useless-concat` and fixes the issues raised by the rule.
4 years ago
9842b2f1ce
Fix no-useless-catch issues ( #9198 )
...
See [`no-useless-catch`](https://eslint.org/docs/rules/no-useless-catch ) for more information.
This change enables `no-useless-catch` and fixes the issues raised by the rule.
4 years ago
a8863a3446
Fix consistent-return issues ( #9192 )
...
See [`consistent-return`](https://eslint.org/docs/rules/consistent-return ) for more information.
This change enables `consistent-return` and fixes the issues raised by the rule.
4 years ago
d4f65e16b4
Use terser-webpack-plugin@2.3.8
4 years ago
ca544a65ae
Use terser-webpack-plugin@1.4.5
4 years ago
885125ad03
Fix no-case-declarations issues ( #9191 )
...
See [`no-case-declarations`](https://eslint.org/docs/rules/no-case-declarations ) for more information.
This change enables `no-case-declarations` and fixes the issues raised by the rule.
4 years ago
b2813f0b54
colocate the base modal styles with the modal component ( #9151 )
...
finalizes the colocation of styles with the consuming components.
4 years ago
163f45beed
Fix account modal back button styling ( #9184 )
4 years ago
42be0645da
colocate original request-signature component styles ( #9182 )
...
Moves the styles out of the itcss folder and colocates them with the component, as per the pattern set elsewhere.
4 years ago
5370b39963
Update eslintignore ( #9178 )
4 years ago
ef68a7963c
fix account modal back styling
4 years ago
01f69d7e7a
colocate account modal styles with their components ( #9150 )
...
This one gets a bit more complicated because the styles were interwoven and needed to be untangled to be moved. Essentially, though, the goal is to put the styles where they make the most sense and colocate them with their components.
4 years ago
6ba9e65712
colocate tab-bar styles with the tab-bar component ( #9176 )
...
Moves styles out of the itcss components folder and places them alongside the component.
4 years ago
b8edc32f48
Fee card component ( #9169 )
...
* Fee card component
* Clean up
* Style lint fixes
4 years ago
08be3dc046
Merge pull request #9173 from MetaMask/sync-master
...
Sync `master` with `develop`
4 years ago
3d9b545771
Merge remote-tracking branch 'origin/master' into sync-master
...
* origin/master: (44 commits)
Add category in eventOpts (#9164 )
Update changelog for v8.0.7 (#9161 )
Version v8.0.7
Remove web3 e2e tests (#9159 )
Add web3 usage metrics, prepare for web3 removal (#9144 )
Use `pathname` instead of URL for `currentPath` metrics parameter (#9158 )
Remove `url` parameter from `metricsEvent` (#9157 )
Change MetaMetrics category for background events (#9155 )
remove .network-name height
Use luxon@1.24.1 (#9154 )
Update 'react-devtools' to ^4.8.0 (#9140 )
Fix connection removal bug (#9137 )
Add source map validator to CI (#9135 )
Update source map validator target files (#9133 )
Improve sourcemap validator console report (#9131 )
Add `validate-source-maps` npm script (#9134 )
Non-zero exit code upon failure to validate source maps (#9132 )
Update `brfs` from v1.6.1 to v2.0.2 (#9115 )
Factor out `getEnvironment` function in build script (#9114 )
Update `browserify` from v16.2.3 to v16.5.1 (#9113 )
...
4 years ago
1a5218ce8e
Merge pull request #9160 from MetaMask/Version-v8.0.7
...
Version v8.0.7 RC
4 years ago
4922b1b9b5
Check if getCleanAppState is defined before calling ( #9170 )
4 years ago
Mark Stacey
Whymarrh Whitby
Patryk Łucka
Brad Decker
Erik Marks
Erik Marks
Dan J Miller