David Walsh
f17514489f
EIP-1559 - Remove unncessary props from AdvancedFormControls ( #11757 )
3 years ago
Dan J Miller
b9d5c431c1
Ensure gas fees update in popover on poll for new values ( #11760 )
3 years ago
Dan J Miller
9fcd93191b
Ensure that gas fee minimum errors show when api is down ( #11767 )
...
* Fix legacy unapproved tx handling
* clean up
3 years ago
Dan J Miller
818dc13019
Fix legacy unapproved tx handling ( #11766 )
3 years ago
Alex Donesky
4245dac8d9
tiny lost code change from 9.8.4 RC ( #11764 )
3 years ago
David Walsh
e1de6e19af
EIP-1559 - Fix mislabeled MaxPriority fee key ( #11758 )
3 years ago
Alex Donesky
d359429f04
Stop GasFeeController polling when pop closes ( #11746 )
...
* Stop GasFeeController polling when pop closes
* Stop estimate gas polling on window unload
* lint + comments
* Improve client closed logic
* lint
* Add back _beforeUnload on unmount in gas-modal-page-container
* Add full check and call onClientClosed method for notifcation environment
* Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type
* remove unused method
* move controller manipulation logic from background.js to metamask-controller, disaggregate methods
* add beforeunload handling to reset gas polling tokens from root of send page
* cleanup, lint and address feedback
* clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller
* mock new methods to fix tests
* final bit of cleanup + comments
Co-authored-by: Dan Miller <danjm.com@gmail.com>
3 years ago
David Walsh
96a13dddb5
Provide pointer cursor for radio group buttons ( #11763 )
3 years ago
Dan J Miller
a950111a19
Show advanced options, and hide radio buttons, for advanced gas settings users ( #11751 )
...
* Show advanced options, and hide radio buttons, for users with advanced gas settings turned on
* Improve naming and copy
* lint fix
* Lint fix
3 years ago
David Walsh
aa3d1f2341
EIP-1559 - Prevent uncaught exception when passing fees to getGasFeeTimeEstimate ( #11759 )
3 years ago
David Walsh
f0daa28fac
EIP-1559 - Temporarily remove the loading heartbeat from the transaction detail ( #11762 )
3 years ago
David Walsh
a3c7bae345
EIP-1559 - Remove unncessary props from AdvancedFormControls ( #11757 )
3 years ago
Dan J Miller
3f4c988018
Ensure gas fees update in popover on poll for new values ( #11760 )
3 years ago
Alex Donesky
0dcdbdd99e
remove unnecessary conversion call ( #11742 )
...
* remove unnecessary conversion call
* Pass args to GasTiming as decGwei
* lint
3 years ago
ryanml
0eef0d424d
Fixing errors in EditGasDisplay ( #11748 )
3 years ago
Dan J Miller
8f50afb0dc
Allow max priority fee to be below 1, and only require it to be greater than 0 ( #11749 )
3 years ago
Dan J Miller
8a31aaadcb
Allows users to set a max priority fee below suggested, just showing a warning in that case ( #11750 )
3 years ago
Dan J Miller
17a4b5224a
Rename effective gas price field to total gas fee ( #11754 )
3 years ago
Alex Donesky
4552a53724
remove unnecessary conversion call ( #11742 )
...
* remove unnecessary conversion call
* Pass args to GasTiming as decGwei
* lint
3 years ago
ryanml
7902e62d8f
Fixing errors in EditGasDisplay ( #11748 )
3 years ago
Dan J Miller
b9fb495c7b
Allow max priority fee to be below 1, and only require it to be greater than 0 ( #11749 )
3 years ago
Dan J Miller
61b965a8a2
Allows users to set a max priority fee below suggested, just showing a warning in that case ( #11750 )
3 years ago
Dan J Miller
1acbb39dff
Rename effective gas price field to total gas fee ( #11754 )
3 years ago
Alex Donesky
ce88b87860
Remove estimate detail above advanced gas controls in non-1559 network ( #11744 )
...
* Remove estimate detail above advanced gas controls in non-1559 network
* lint
* remove gasEstimate localization text
3 years ago
ryanml
3c0846df84
Fall back to aggregator name when icon is unavailable (Swaps Load View) ( #11718 )
3 years ago
David Walsh
c4c1504e09
EIP-1559 - Show minium native currency in banner when on testnets ( #11743 )
3 years ago
Alex Donesky
615380b76d
Remove estimate detail above advanced gas controls in non-1559 network ( #11744 )
...
* Remove estimate detail above advanced gas controls in non-1559 network
* lint
* remove gasEstimate localization text
3 years ago
ryanml
7f0b2a81ce
Fall back to aggregator name when icon is unavailable (Swaps Load View) ( #11718 )
3 years ago
David Walsh
24d563fc2c
EIP-1559 - Show minium native currency in banner when on testnets ( #11743 )
3 years ago
Daniel
474d7571b6
Fix a position of a tooltip icon ( #11739 )
3 years ago
Alex Donesky
340c3d2876
Add gasPrice to be used on non-1559 networks for transaction details on confirm screen ( #11741 )
3 years ago
David Walsh
29072a0cf0
EIP-1559 - Provide better validation for gas price and gas limit ( #11736 )
3 years ago
Dan J Miller
ac32efd814
Ensure that gas price in popover updates when api provided estimate updates ( #11727 )
3 years ago
David Walsh
ce61eaacdf
EIP-1559 - Ensure transaction detail font-size and icon colors are consistent with Figma design ( #11735 )
3 years ago
David Walsh
3b2b5c018f
EIP-1559 - Return null from GasTiming if on non-1559 network ( #11733 )
3 years ago
Daniel
deae2d47bf
Fix a position of a tooltip icon ( #11739 )
3 years ago
Alex Donesky
a4927a30ac
Add gasPrice to be used on non-1559 networks for transaction details on confirm screen ( #11741 )
3 years ago
David Walsh
fba662ca2b
EIP-1559 - Provide better validation for gas price and gas limit ( #11736 )
3 years ago
Dan J Miller
7ac1972371
Ensure that gas price in popover updates when api provided estimate updates ( #11727 )
3 years ago
David Walsh
cdbfe0f132
EIP-1559 - Ensure transaction detail font-size and icon colors are consistent with Figma design ( #11735 )
3 years ago
David Walsh
aa08171c72
EIP-1559 - Return null from GasTiming if on non-1559 network ( #11733 )
3 years ago
David Walsh
e2fbc7ce8e
Remove button group for non-EIP-1559 networks ( #11712 )
...
* Remove button group for non-EIP-1559 networks
* Fix tests...maybe
* Remove unnecessary props, as well as gas display
* Remove unused string
* test progress
* fix test
* fix test
* add customizes gas block to improve e2e pass rate
Co-authored-by: Alex <adonesky@gmail.com>
3 years ago
David Walsh
c8b3dfe4e9
EIP-1559 - Fall back to gasLimit and gasPrice for hardware wallets ( #11716 )
3 years ago
Dan J Miller
8481c4b6be
Show warning when network request for fee market estimates fails ( #11724 )
3 years ago
David Walsh
d34bf92fd0
Fix 11705 - Reset gas limit when radio button clicked ( #11710 )
...
* Fix 11705 - Reset gas limit when radio button clicked
* Trigger manual change when gasLimit is changed
* Coordinate gas limit with radio buttons
* Revert "Coordinate gas limit with radio buttons"
This reverts commit 910327a408e32ae989c5565a107db24ac24f2a98.
* Cleanup default gas limit
* setEstimateToUse only update gasLimit on error, add default minimum gasLimit
* add minimum gasLimit fallback
Co-authored-by: Alex <adonesky@gmail.com>
3 years ago
Alex Donesky
c43f6cab63
remove estimate detail in advanced gas controls ( #11728 )
3 years ago
kumavis
7018b43898
improve password-manager metadata attributes ( #11690 )
3 years ago
Dan J Miller
668fd2db66
Ensure that gas fee/prices params are not updated while in send edit stage/mode ( #11620 )
...
* Ensure that gas fee/prices params are not updated while in send edit stage/mode
* Allow editing of txparams gas price when not on eip1559 network, in send flow
3 years ago
David Walsh
4ce6994a6c
Fix #11695 - Prevent maxFee and maxPriorityFee imbalance ( #11700 )
3 years ago
David Walsh
38ff2c937f
Fix #11703 - Provide wiring for approval modal ( #11711 )
3 years ago