Merge branch 'develop' into bugfix/661

mythril/ethereum/util.py

@@ -78,9 +78,11 @@ def solc_exists(version):
             os.environ.get("HOME", str(Path.home())),
             ".py-solc/solc-v" + version,
             "bin/solc",
-        ),  # py-solc setup
-        "/usr/bin/solc",  # Ubuntu PPA setup
+        )  # py-solc setup
     ]
+    if version.startswith("0.5"):
+        # Temporary fix to support v0.5.x with Ubuntu PPA setup
+        solc_binaries.append("/usr/bin/solc")
     for solc_path in solc_binaries:
         if os.path.exists(solc_path):
             return solc_path

mythril/laser/ethereum/instructions.py

@@ -131,7 +131,7 @@ class Instruction:
     def evaluate(self, global_state: GlobalState, post=False) -> List[GlobalState]:
         """ Performs the mutation for this instruction """
         # Generalize some ops
-        # logging.debug("Evaluating {}".format(self.op_code))
+        logging.debug("Evaluating {}".format(self.op_code))
         op = self.op_code.lower()
         if self.op_code.startswith("PUSH"):
             op = "push"
@@ -773,6 +773,14 @@ class Instruction:
 
         return [global_state]
 
+    @StateTransition()
+    def returndatacopy_(self, global_state: GlobalState) -> List[GlobalState]:
+        # FIXME: not implemented
+        state = global_state.mstate
+        start, s2, size = state.stack.pop(), state.stack.pop(), state.stack.pop()
+
+        return [global_state]
+
     @StateTransition()
     def returndatasize_(self, global_state: GlobalState) -> List[GlobalState]:
         global_state.mstate.stack.append(global_state.new_bitvec("returndatasize", 256))

mythril/mythril.py

@@ -227,6 +227,9 @@ class Mythril(object):
             else:
                 try:
                     solc.install_solc("v" + version)
+                    solc_binary = util.solc_exists(version)
+                    if not solc_binary:
+                        raise SolcError()
                 except SolcError:
                     raise CriticalError(
                         "There was an error when trying to install the specified solc version"