From 708bb9c8232dafda600403a37d1a3e46d88d78ce Mon Sep 17 00:00:00 2001 From: freewind Date: Sun, 1 Apr 2018 14:17:55 +0800 Subject: [PATCH 1/2] Ignore leading and ending spaces before checking json in report_test --- tests/report_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/report_test.py b/tests/report_test.py index 7f8afd86..71da79fe 100644 --- a/tests/report_test.py +++ b/tests/report_test.py @@ -43,4 +43,4 @@ class AnalysisReportTest(TestCase): self.assertEqual(_fix_path(report.as_text()), text, "{}: text report is changed".format(str(input_file))) self.assertEqual(_fix_path(report.as_markdown()), markdown, "{}: markdown report is changed".format(str(input_file))) - self.assertEqual(_fix_path(_fix_debug_data(report.as_json())), json_report, "{}: json report is changed".format(str(input_file))) + self.assertEqual(_fix_path(_fix_debug_data(report.as_json())).strip(), json_report.strip(), "{}: json report is changed".format(str(input_file))) From 0566d575945eef5ff4671ed5c85013c26edddfb6 Mon Sep 17 00:00:00 2001 From: freewind Date: Sun, 1 Apr 2018 14:18:34 +0800 Subject: [PATCH 2/2] Add validation commands in README --- README_DEV.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README_DEV.md b/README_DEV.md index 9ceb6736..bd507ab3 100644 --- a/README_DEV.md +++ b/README_DEV.md @@ -35,6 +35,14 @@ We use `--syncmode full` here because the `eth.blockNumber` will get increased s If there is no error thrown, you can wait 1 or 2 minutes before running tests. +And you need to check `eth.coinbase` has no error thrown and `eth.blockNumber` should greater than `0`: + +``` +$ geth attach +> eth.coinbase +> eth.blockNumber +``` + ### Run the tests ```bash