From eaec4906bc3bdbbfb0cb484eed06f5854614a208 Mon Sep 17 00:00:00 2001
From: Bernhard Mueller <bernhard.mueller11@gmail.com>
Date: Fri, 7 Jun 2019 14:35:25 +0200
Subject: [PATCH] Re-add the cache

---
 mythril/analysis/modules/integer.py | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/mythril/analysis/modules/integer.py b/mythril/analysis/modules/integer.py
index 0bc58ecb..3bac3efb 100644
--- a/mythril/analysis/modules/integer.py
+++ b/mythril/analysis/modules/integer.py
@@ -80,12 +80,15 @@ class IntegerOverflowUnderflowModule(DetectionModule):
             pre_hooks=["ADD", "MUL", "EXP", "SUB", "SSTORE", "JUMPI", "STOP", "RETURN"],
         )
 
+        self._overflow_cache = {}  # type: Dict[int, bool]
+
     def reset_module(self):
         """
         Resets the module
         :return:
         """
         super().reset_module()
+        self._overflow_cache = {}
 
     def _execute(self, state: GlobalState) -> None:
         """Executes analysis module for integer underflow and integer overflow.
@@ -94,6 +97,10 @@ class IntegerOverflowUnderflowModule(DetectionModule):
         :return: Found issues
         """
 
+        address = _get_address_from_state(state)
+        if self._overflow_cache.get(address, False):
+            return
+
         opcode = state.get_current_instruction()["opcode"]
 
         funcs = {
@@ -327,6 +334,8 @@ class IntegerOverflowUnderflowModule(DetectionModule):
 
             issue.debug = json.dumps(transaction_sequence, indent=4)
 
+            address = _get_address_from_state(ostate)
+            self._overflow_cache[address] = True
             self._issues.append(issue)
 
     @staticmethod
@@ -341,3 +350,7 @@ class IntegerOverflowUnderflowModule(DetectionModule):
 
 
 detector = IntegerOverflowUnderflowModule()
+
+
+def _get_address_from_state(state):
+    return state.get_current_instruction()["address"]