Merge branch 'develop' into add_solver_timeout

all_tests.sh

@@ -7,22 +7,6 @@ assert sys.version_info[0:2] >= (3,5), \
 """Please make sure you are using Python 3.5 or later.
 You ran with {}""".format(sys.version)' || exit $?
 
-echo "Checking solc version..."
-out=$(solc --version) || {
-    echo 2>&1 "Please make sure you have solc installed, version 0.4.21 or greater"
-
-    }
-case $out in
-    *Version:\ 0.4.2[1-9]* )
-	echo $out
-	;;
-    * )
-	echo $out
-	echo "Please make sure your solc version is at least 0.4.21"
-	exit 1
-	;;
-esac
-
 echo "Checking that truffle is installed..."
 if ! which truffle ; then
     echo "Please make sure you have etherum truffle installed (npm install -g truffle)"

mythril/interfaces/cli.py

@@ -356,7 +356,7 @@ def create_analyzer_parser(analyzer_parser: ArgumentParser):
         "--create-timeout",
         type=int,
         default=10,
-        help="The amount of seconds to spend on " "the initial contract creation",
+        help="The amount of seconds to spend on the initial contract creation",
     )
     options.add_argument(
         "-l",
@@ -366,8 +366,9 @@ def create_analyzer_parser(analyzer_parser: ArgumentParser):
     )
     options.add_argument(
         "--no-onchain-storage-access",
+        "--no-onchain-access",
         action="store_true",
-        help="turns off getting the data from onchain contracts",
+        help="turns off getting the data from onchain contracts (both loading storage and contract code)",
     )
 
     options.add_argument(
@@ -559,6 +560,7 @@ def execute_command(
             disable_dependency_pruning=args.disable_dependency_pruning,
             onchain_storage_access=not args.no_onchain_storage_access,
             solver_timeout=args.solver_timeout,
+            requires_dynld=not args.no_onchain_storage_access,
         )
 
         if not disassembler.contracts: