OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/spec/features/wysiwyg/custom_css_classes_spec.rb

172 lines
5.9 KiB

Fix/update wysiwyg styles (#8844) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit 0d27d281378b324330ea2f25632de898269e2122. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>
4 years ago
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2020 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2017 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
require 'spec_helper'
describe 'Wysiwyg paragraphs in lists behavior (Regression #28765)',
type: :feature, js: true do
let(:user) { FactoryBot.create :admin }
let(:project) { FactoryBot.create(:project, enabled_module_names: %w[wiki]) }
let(:editor) { ::Components::WysiwygEditor.new }
let(:wiki_page) {
page = FactoryBot.build :wiki_page_with_content
page.content.text = <<~MARKDOWN
paragraph
# h1
## h2
### h3
#### h4
##### h5
`code`
```text
code snippet
```
[link](http://link.com/)
* ul
1. ol
* [ ] task list
<figure><img src="/api/v3/attachments/44/content"><figcaption>Image</figcaption></figure>
> Quote
<figure>
<table>
<thead>
<tr>
<th>
<br data-cke-filler="true">
</th>
<th>row header</th>
<th>
<br data-cke-filler="true">
</th>
</tr>
</thead>
<tbody>
<tr>
<th>column header</th>
<td></td>
<td></td>
</tr>
</tbody>
</table>
</figure>
<macro class="toc"></macro>
<macro class="embedded-table"></macro>
<macro class="create_work_package_link" data-type="Milestone"></macro>
<macro class="child_pages"></macro>
MARKDOWN
page
}
before do
login_as(user)
project.wiki.pages << wiki_page
project.wiki.save!
visit edit_project_wiki_path(project, wiki_page.slug)
end
it 'custom classes are placed correctly' do
editor.in_editor do |container, editable|
expect(editable).to have_css('p.op-uc-p', count: 5)
expect(editable).to have_css('h1.op-uc-h1', count: 1)
expect(editable).to have_css('h2.op-uc-h2', count: 1)
expect(editable).to have_css('h3.op-uc-h3', count: 1)
expect(editable).to have_css('h4.op-uc-h4', count: 1)
expect(editable).to have_css('h5.op-uc-h5', count: 1)
expect(editable).to have_css('blockquote.op-uc-blockquote', count: 1)
expect(editable).to have_css('figure.op-uc-figure', count: 2)
expect(editable).to have_css('figure.op-uc-figure div.op-uc-figure--content img.op-uc-image', count: 1)
expect(editable).to have_css('figure.op-uc-figure.op-uc-figure_align-center table.op-uc-table', count: 1)
expect(editable).to have_css('table.op-uc-table thead.op-uc-table--head', count: 1)
expect(editable).to have_css('table.op-uc-table tr.op-uc-table--row', count: 2)
expect(editable).to have_css('table.op-uc-table td.op-uc-table--cell', count: 2)
expect(editable).to have_css('table.op-uc-table th.op-uc-table--cell.op-uc-table--cell_head', count: 4)
expect(editable).to have_css('ul.op-uc-list', count: 2)
expect(editable).to have_css('ol.op-uc-list', count: 1)
expect(editable).to have_css('ul.op-uc-list_task-list', count: 1)
expect(editable).to have_css('ul.op-uc-list li.op-uc-list--item', count: 2)
expect(editable).to have_css('ol.op-uc-list li.op-uc-list--item', count: 1)
expect(editable).to have_css('ul.op-uc-list.op-uc-list_task-list li.op-uc-list--item', count: 1)
expect(editable).to have_css('pre.op-uc-code-block', count: 1)
expect(editable).to have_css('code.op-uc-code', count: 1)
expect(editable).to have_css('a.op-uc-link', count: 1)
expect(editable).to have_css('div.op-uc-placeholder', count: 3)
expect(editable).to have_css('span.op-uc-placeholder', count: 1)
end
end
it 'custom align classes are placed correctly' do
editor.in_editor do |container, editable|
# strangely, we need visible: :all here
editor.click_toolbar_button 'Insert table'
# 2x2
container.find('.ck-insert-table-dropdown-grid-box:nth-of-type(12)').click
sleep(0.1)
# There are already multiple tables on the page.
# To avoid mixing them up, we need to select the appropriate one
table = container.find('.op-uc-figure:first-of-type .op-uc-table')
editor.align_table_by_label(editor, table, 'Align table to the left')
# Table figure should now has the proper alignment class
expect(editable).to have_selector('figure.op-uc-figure_align-start')
editor.align_table_by_label(editor, table, 'Align table to the right')
# Table figure should now has the proper alignment class
expect(editable).to have_selector('figure.op-uc-figure_align-end')
editor.align_table_by_label(editor, table, 'Center table')
# Table figure should now has the proper alignment class
expect(editable).to have_selector('figure.op-uc-figure_align-center')
end
end
end