OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/spec/models/queries/placeholder_users/placeholder_user_query_spec.rb

197 lines
5.4 KiB

Placeholder user services and administration (#8944) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
Placeholder user services and administration (#8944) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
#++
require 'spec_helper'
describe Queries::PlaceholderUsers::PlaceholderUserQuery, type: :model do
let(:instance) { described_class.new }
let(:base_scope) { PlaceholderUser.order(id: :desc) }
context 'without a filter' do
describe '#results' do
it 'is the same as getting all the users' do
expect(instance.results.to_sql).to eql base_scope.to_sql
end
end
end
context 'with a name filter' do
before do
instance.where('name', '~', ['a user'])
end
describe '#results' do
it 'is the same as handwriting the query' do
expected = base_scope
.merge(PlaceholderUser
.where(["LOWER(CONCAT(users.firstname, CONCAT(' ', users.lastname))) LIKE ?",
"%a user%"]))
expect(instance.results.to_sql).to eql expected.to_sql
end
end
describe '#valid?' do
it 'is true' do
expect(instance).to be_valid
end
it 'is invalid if the filter is invalid' do
instance.where('name', '=', [''])
expect(instance).to be_invalid
end
end
end
context 'with a group filter' do
let(:group_1) { FactoryBot.build_stubbed(:group) }
before do
allow(Group)
.to receive(:exists?)
.and_return(true)
allow(Group)
.to receive(:all)
.and_return([group_1])
instance.where('group', '=', [group_1.id])
end
describe '#results' do
it 'is the same as handwriting the query' do
expected = base_scope
.merge(PlaceholderUser
.where(["users.id IN (#{PlaceholderUser.in_group([group_1.id.to_s]).select(:id).to_sql})"]))
expect(instance.results.to_sql).to eql expected.to_sql
end
end
describe '#valid?' do
it 'is true' do
expect(instance).to be_valid
end
it 'is invalid if the filter is invalid' do
instance.where('group', '=', [''])
expect(instance).to be_invalid
end
end
end
context 'with a non existent filter' do
before do
instance.where('not_supposed_to_exist', '=', ['bogus'])
end
describe '#results' do
it 'returns a query not returning anything' do
expected = PlaceholderUser.where(Arel::Nodes::Equality.new(1, 0))
expect(instance.results.to_sql).to eql expected.to_sql
end
end
describe 'valid?' do
it 'is false' do
expect(instance).to be_invalid
end
it 'returns the error on the filter' do
instance.valid?
expect(instance.errors[:filters]).to eql ["Not supposed to exist does not exist."]
end
end
end
context 'with an id sortation' do
before do
instance.order(id: :asc)
end
describe '#results' do
it 'is the same as handwriting the query' do
expected = PlaceholderUser.merge(PlaceholderUser.order(id: :asc))
expect(instance.results.to_sql).to eql expected.to_sql
end
end
end
context 'with a name sortation' do
before do
instance.order(name: :desc)
end
describe '#results' do
it 'is the same as handwriting the query' do
expected = "SELECT \"users\".* FROM \"users\" WHERE \"users\".\"type\" = 'PlaceholderUser' ORDER BY \"users\".\"lastname\" DESC, \"users\".\"id\" DESC"
expect(instance.results.to_sql).to eql expected
end
end
end
context 'with a group sortation' do
before do
instance.order(group: :desc)
end
describe '#results' do
it 'is the same as handwriting the query' do
expected = PlaceholderUser.merge(PlaceholderUser.joins(:groups).order("groups_users.lastname DESC")).order(id: :desc)
expect(instance.results.to_sql).to eql expected.to_sql
end
end
end
context 'with a non existing sortation' do
# this is a field protected from sortation
before do
instance.order(password: :desc)
end
describe '#results' do
it 'returns a query not returning anything' do
expected = PlaceholderUser.where(Arel::Nodes::Equality.new(1, 0))
expect(instance.results.to_sql).to eql expected.to_sql
end
end
describe 'valid?' do
it 'is false' do
expect(instance).to be_invalid
end
end
end
end