TheDude
/
openproject
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
58913 Commits
139 Branches
203 Tags
1.2 GiB
Tag: Branch: Tree: 2896afe6c4
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '2896afe6c4'
${ noResults }
openproject/.rubocop.yml

308 lines
4.5 KiB
Raw Normal View History Unescape

add rupocop-rails and rubocop-rspec (#8998)
4 years ago
require:
- rubocop-rails
- rubocop-rspec
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
AllCops:
bump rubocop
4 years ago
TargetRubyVersion: 2.7
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Exclude:
- db/schema.rb
[#36204] Add new GitHub plugin tab enabling users to copy git actions (#9027) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs
4 years ago
Gemspec/RequiredRubyVersion:
Exclude:
- modules/**/*.gemspec
update rubocop.yml
5 years ago
Layout/ConditionPosition:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Layout/DotPosition:
EnforcedStyle: leading
Layout/LineLength:
Max: 130
Layout/MultilineMethodCallIndentation:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/AmbiguousOperator:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/AmbiguousRegexpLiteral:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/AssignmentInCondition:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/DeprecatedClassMethods:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/ElseLayout:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/FlipFlop:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/LiteralInInterpolation:
disabling BlockLength rubocop rule - we use too much roar to do that
8 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/Loop:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/ParenthesesAsGroupedExpression:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/RequireParentheses:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/SuppressedException:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/UnderscorePrefixedVariableName:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Lint/Void:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Metrics/ClassLength:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Metrics/CyclomaticComplexity:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Metrics/BlockLength:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Metrics/BlockNesting:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Metrics/MethodLength:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Metrics/ModuleLength:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Metrics/ParameterLists:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Naming/AccessorMethodName:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Naming/AsciiIdentifiers:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Naming/FileName:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Naming/PredicateName:
ForbiddenPrefixes:
- is_
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Feature/member notifications (#8958) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
# There are valid cases in which to use methods like:
# * update_all
# * touch_all
Rails/SkipsModelValidations:
Enabled: false
update rubocop.yml
5 years ago
Style/Alias:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/AndOr:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/ArrayJoin:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/AsciiComments:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/Attr:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/CaseEquality:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/CharacterLiteral:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/ClassAndModuleChildren:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/ClassVars:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/CollectionMethods:
PreferredMethods:
find: detect
reduce: inject
collect: map
find_all: select
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
update rubocop.yml
5 years ago
Style/ColonMethodCall:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/CommentAnnotation:
don't nag about module length
8 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/PreferredHashMethods:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/Documentation:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/DoubleNegation:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/EachWithObject:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/EmptyLiteral:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/Encoding:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/EvenOdd:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/FormatString:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/GlobalVars:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/GuardClause:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/IfUnlessModifier:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/IfWithSemicolon:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/InlineComment:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/Lambda:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/LambdaCall:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/LineEndConcatenation:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/ModuleFunction:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/NegatedIf:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/NegatedWhile:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/Next:
disable rubocop's single quote grievance
8 years ago
Enabled: false
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
update rubocop.yml
5 years ago
Style/NilComparison:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/Not:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/OneLineConditional:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/PercentLiteralDelimiters:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/PerlBackrefs:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/Proc:
Tell Rubocop to ignore FrozenStringLiteralComment
6 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/RaiseArgs:
Add migration to clean invalid custom_values
5 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/RegexpLiteral:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/SelfAssignment:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/SingleLineBlockParams:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/SingleLineMethods:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/SignalException:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/SpecialGlobalVars:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
# Forcing single quotes doesn't give any reasonable advantages. To the contrary:
# it forces you to change the quotes every time you want to add interpolation,
# newlines or other escape sequences (\n), or quotes (') to a string. Rubbish.
# Don't even think about performance. That never was a valid argument to begin with.
#
# For the record: using single quotes does NOT have any performance advantages.
# Even if it did, this would be a silly argument.
#
# Ideally we would just use double quotes everywhere but since that would result
# in innumerable rubocop offenses we will just disable this. Quote away.
Style/StringLiterals:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/TrivialAccessors:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/VariableInterpolation:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/WhenThen:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/WhileUntilModifier:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/WordArray:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/FrozenStringLiteralComment:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
update rubocop.yml
5 years ago
Style/NumericLiterals:
Reference Rubocop config from Hound config rather than the inheriting the other way around (see b17d3faf). [ci config] Signed-off-by: Alex Coles <alex@alexbcoles.com>
10 years ago
Enabled: false
Replace jquery-autocomplete in wp-relations-autocomplete
6 years ago
Disable positive? check in rubocop [ci skip]
4 years ago
# Avoid enforcing "positive?"
Style/NumericPredicate:
Enabled: false
update rubocop.yml
5 years ago
Style/HashEachMethods:
Enabled: true
Style/HashTransformKeys:
Enabled: true
Replace jquery-autocomplete in wp-relations-autocomplete
6 years ago
update rubocop.yml
5 years ago
Style/HashTransformValues:
Enabled: true
increase limit on rspec memoized helpers
4 years ago
[#36204] Add new GitHub plugin tab enabling users to copy git actions (#9027) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs
4 years ago
RSpec/MultipleMemoizedHelpers:
Max: 15
[#36153] link manually created pull request to a work package using the GitHub integration plug-in (#9070) * Receiving and Parsing GitHub webhooks * added services for upserting PullRequests, GitHub users, and, checks. * added the datamodels for storing these entities * added logic to parse GitHub webhooks and save the entities above * fix some specs, added model specs * let UpsertPartialPullRequest return the upserted PR * added the last missing specs * avoid double-posts when editing pull requestsx * attempt to reduce flakiness * added pull requests API endpoint * handle edge case of converting partial PRs to full PRs * name raw input of an upsert service 'payload' to differentiate it from the prepared params * handle edge case: partial upsert after full PR creation * github_user does not reference users anymore * fixed a doc comment * use enums instead of custom validations * WIP * pairing with jens and some cleanup and test writing * better migration, clear up old PRs with a cron job * handle case of non-edit events which do not introduce new linked work packages, but still require a comment
4 years ago
AllowSubject: true
[#36204] Add new GitHub plugin tab enabling users to copy git actions (#9027) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs
4 years ago
RSpec/MultipleExpectations:
increase limit on rspec memoized helpers
4 years ago
Max: 15
[#36204] Add new GitHub plugin tab enabling users to copy git actions (#9027) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs
4 years ago
RSpec/ExampleLength:
Max: 25