OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/spec/contracts/attachments/create_contract_spec.rb

144 lines
4.2 KiB

[37868] Whitelist for attachment mime types and extensions on upload (#9431) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract
3 years ago
#-- encoding: UTF-8
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
require 'spec_helper'
require 'contracts/shared/model_contract_shared_context'
describe Attachments::CreateContract do
include_context 'ModelContract shared context'
let(:current_user) { FactoryBot.build_stubbed :user }
let(:model) do
FactoryBot.build :attachment,
container: container,
content_type: content_type,
file: file,
filename: filename,
author: current_user
end
let(:contract) { described_class.new model, user, options: contract_options }
let(:contract_options) { {} }
let(:user) { current_user }
let(:container) { nil }
let(:file) do
Rack::Test::UploadedFile.new(
Rails.root.join("spec/fixtures/files/image.png"),
'image/png',
true
)
end
let(:content_type) { 'image/png' }
let(:filename) { 'image.png' }
let(:can_attach_global) { true }
before do
allow(Redmine::Acts::Attachable.attachables)
.to receive(:none?).and_return(!can_attach_global)
end
context 'with user who has no permissions' do
let(:can_attach_global) { false }
it_behaves_like 'contract is invalid', base: :error_unauthorized
end
context 'with a user that is not the author' do
let(:user) { FactoryBot.build_stubbed :user }
it_behaves_like 'contract is invalid', author: :invalid
end
context 'with user who has permissions to add' do
it_behaves_like 'contract is valid'
end
context 'with a container' do
let(:container) { FactoryBot.build_stubbed :work_package }
before do
allow(container)
.to receive(:attachments_addable?)
.with(user)
.and_return(can_attach)
end
context 'with user who has no permissions' do
let(:can_attach) { false }
it_behaves_like 'contract is invalid', base: :error_unauthorized
end
context 'with user who has permissions to add' do
let(:can_attach) { true }
it_behaves_like 'contract is valid'
end
end
context 'with an empty whitelist',
with_settings: { attachment_whitelist: %w[] } do
it_behaves_like 'contract is valid'
end
context 'with a matching mime whitelist',
with_settings: { attachment_whitelist: %w[image/png] } do
it_behaves_like 'contract is valid'
end
context 'with a matching extension whitelist',
with_settings: { attachment_whitelist: %w[*.png] } do
it_behaves_like 'contract is valid'
end
context 'with a non-matching whitelist',
with_settings: { attachment_whitelist: %w[*.jpg image/jpeg] } do
it_behaves_like 'contract is invalid', content_type: :not_whitelisted
context 'when disabling the whitelist check' do
let(:contract_options) do
{ whitelist: [] }
end
it_behaves_like 'contract is valid'
end
context 'when overriding the whitelist' do
let(:contract_options) do
{ whitelist: %w[*.png] }
end
it_behaves_like 'contract is valid'
end
end
end