OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/app/controllers/placeholder_users_controlle...

163 lines
4.6 KiB

Placeholder user services and administration (#8944) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
#-- encoding: UTF-8
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2020 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2017 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
class PlaceholderUsersController < ApplicationController
layout 'admin'
helper_method :gon
before_action :require_admin, except: [:show]
before_action :find_placeholder_user, only: %i[show
edit
update
destroy]
before_action :check_if_deletion_allowed, only: [:destroy]
def index
@placeholder_users = PlaceholderUsers::PlaceholderUserFilterCell.filter params
respond_to do |format|
format.html do
render layout: !request.xhr?
end
end
end
def show
# show projects based on current user visibility
@memberships = @placeholder_user.memberships
.visible(current_user)
respond_to do |format|
format.html { render layout: 'no_menu' }
end
end
def new
@placeholder_user = PlaceholderUsers::SetAttributesService
.new(user: User.current,
model: PlaceholderUser.new,
contract_class: EmptyContract)
.call({})
.result
end
def create
service = PlaceholderUsers::CreateService.new(user: User.current)
service_result = service.call(permitted_params.placeholder_user)
@placeholder_user = service_result.result
if service_result.success?
respond_to do |format|
format.html do
flash[:notice] = I18n.t(:notice_successful_create)
redirect_to(params[:continue] ? new_placeholder_user_path : edit_placeholder_user_path(@placeholder_user))
end
end
else
respond_to do |format|
format.html do
render action: :new
end
end
end
end
def edit
@membership ||= Member.new
@individual_principal = @placeholder_user
end
def update
service_result = PlaceholderUsers::UpdateService
.new(user: User.current,
model: @placeholder_user)
.call(permitted_params.placeholder_user)
if service_result.success?
respond_to do |format|
format.html do
flash[:notice] = I18n.t(:notice_successful_update)
redirect_back(fallback_location: edit_placeholder_user_path(@placeholder_user))
end
end
else
@membership ||= Member.new
respond_to do |format|
format.html do
render action: :edit
end
end
end
end
def destroy
Users::DeleteService.new(user: User.current,
model: @placeholder_user)
.call
flash[:notice] = I18n.t('account.deleted')
respond_to do |format|
format.html do
redirect_to placeholder_users_path
end
end
end
private
def find_placeholder_user
@placeholder_user = PlaceholderUser.find(params[:id])
rescue ActiveRecord::RecordNotFound
render_404
end
def check_if_deletion_allowed
render_404 unless PlaceholderUsers::DeleteService.deletion_allowed? @placeholder_user, User.current
end
protected
def default_breadcrumb
if action_name == 'index'
t('label_placeholder_user_plural')
else
ActionController::Base.helpers.link_to(t('label_placeholder_user_plural'),
placeholder_users_path)
end
end
def show_local_breadcrumb
current_user.admin?
end
end