OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/spec/models/attachment_spec.rb

141 lines
4.5 KiB

#-- copyright
# OpenProject is a project management system.
# Copyright (C) 2012-2018 the OpenProject Foundation (OPF)
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2017 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
require 'spec_helper'
describe Attachment, type: :model do
let(:author) { FactoryGirl.create :user }
let(:long_description) { 'a' * 300 }
let(:work_package) { FactoryGirl.create :work_package, description: '' }
let(:file) { FactoryGirl.create :uploaded_jpg, name: 'test.jpg' }
let(:attachment) do
FactoryGirl.build(
:attachment,
author: author,
container: work_package,
content_type: nil, # so that it is detected
file: file)
end
let(:stubbed_attachment) do
FactoryGirl.build_stubbed(
:attachment,
author: author,
container: work_package,
content_type: nil, # so that it is detected
file: file)
end
describe 'create' do
context 'save' do
before do
attachment.description = long_description
attachment.valid?
end
it 'should validate description length' do
Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions
10 years ago
expect(attachment.errors[:description]).not_to be_empty
end
it 'should raise an error regarding description length' do
expect(attachment.errors.full_messages[0]).to include I18n.t('activerecord.errors.messages.too_long', count: 255)
end
end
it('should create a jpg file called test') do
expect(File.exists?(attachment.diskfile.path)).to eq true
end
it('have the content type "image/jpeg"') do
expect(attachment.content_type).to eq 'image/jpeg'
end
context 'with wrong content-type' do
let(:file) { FactoryGirl.create :uploaded_jpg, content_type: 'text/html' }
it 'should detect the correct content-type' do
expect(attachment.content_type).to eq 'image/jpeg'
end
end
end
describe 'update' do
before do
attachment.save!
end
context 'update' do
before do
attachment.description = long_description
attachment.valid?
end
it 'should validate description length' do
Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions
10 years ago
expect(attachment.errors[:description]).not_to be_empty
end
it 'should raise an error regarding description length' do
expect(attachment.errors.full_messages[0]).to include I18n.t('activerecord.errors.messages.too_long', count: 255)
end
end
end
##
# The tests assumes the default, file-based storage is configured and tests against that.
# I.e. it does not test fog attachments being deleted from the cloud storage (such as S3).
describe 'destroy' do
before do
attachment.save!
expect(File.exists?(attachment.file.path)).to eq true
attachment.destroy
attachment.run_callbacks(:commit)
# triggering after_commit callbacks manually as they are not triggered during rspec runs
# though in dev/production mode destroy does trigger these callbacks
end
it "deletes the attachment's file" do
expect(File.exists?(attachment.file.path)).to eq false
end
end
# Made necessary as attachments only have the created_on field which is not factored
# into the cache_key. While it shouldn't be a problem in production, as attachments cannot be
# altered, it is a problem in the tests.
describe '#cache_key' do
before do
stubbed_attachment.created_on = Time.now
end
it 'factors in id and created_on' do
expect(stubbed_attachment.cache_key)
.to eql("attachments/#{stubbed_attachment.id}-#{stubbed_attachment.created_on.to_i}")
end
end
end