TheDude
/
openproject
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
59889 Commits
139 Branches
203 Tags
1.2 GiB
Tag: Branch: Tree: b52a2d744b
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'b52a2d744b'
${ noResults }
openproject/spec/features/users/index_spec.rb

160 lines
5.9 KiB
Raw Normal View History Unescape

replace user index cuke
6 years ago
#-- copyright
Update copyright notice
5 years ago
# OpenProject is an open source project management software.
update copyright to 2021 (#8925) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
4 years ago
# Copyright (C) 2012-2021 the OpenProject GmbH
replace user index cuke
6 years ago
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
update copyright to 2021 (#8925) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
4 years ago
# Copyright (C) 2006-2013 Jean-Philippe Lang
replace user index cuke
6 years ago
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
require 'spec_helper'
Remove usages of AnyFixture (#8987) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.
4 years ago
describe 'index users', type: :feature do
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
shared_let(:current_user) { FactoryBot.create :admin, firstname: 'admin', lastname: 'admin', created_at: 1.hour.ago }
replace user index cuke
6 years ago
let(:index_page) { Pages::Admin::Users::Index.new }
before do
[35507] Allow global permission to add and edit users (#8937) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>
4 years ago
login_as(current_user)
replace user index cuke
6 years ago
end
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
describe 'with some sortable users' do
Placeholder user services and administration (#8944) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
let!(:a_user) { FactoryBot.create :user, login: 'aa_login', firstname: 'aa_first', lastname: 'xxx_a' }
let!(:b_user) { FactoryBot.create :user, login: 'bb_login', firstname: 'bb_first', lastname: 'nnn_b' }
let!(:z_user) { FactoryBot.create :user, login: 'zz_login', firstname: 'zz_first', lastname: 'ccc_z' }
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
it 'sorts them correctly (Regression #35012)' do
index_page.visit!
index_page.expect_listed(current_user, a_user, b_user, z_user)
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.order_by('First name')
index_page.expect_order(a_user, current_user, b_user, z_user)
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.order_by('First name')
index_page.expect_order(z_user, b_user, current_user, a_user)
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.order_by('Last name')
index_page.expect_order(current_user, z_user, b_user, a_user)
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.order_by('Last name')
index_page.expect_order(a_user, b_user, z_user, current_user)
end
end
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
describe 'with some more status users' do
shared_let(:anonymous) { FactoryBot.create :anonymous }
shared_let(:active_user) { FactoryBot.create :user, created_at: 1.minute.ago }
shared_let(:registered_user) { FactoryBot.create :user, status: User.statuses[:registered] }
shared_let(:invited_user) { FactoryBot.create :user, status: User.statuses[:invited] }
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
it 'shows the users by status and allows status manipulations',
with_settings: { brute_force_block_after_failed_logins: 5,
brute_force_block_minutes: 10 } do
index_page.visit!
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
# Order is by id, asc
# so first ones created are on top.
index_page.expect_listed(current_user, active_user, registered_user, invited_user)
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.order_by('Created on')
index_page.expect_order(invited_user, registered_user, active_user, current_user)
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.order_by('Created on')
index_page.expect_order(current_user, active_user, registered_user, invited_user)
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.lock_user(active_user)
index_page.expect_listed(current_user, active_user, registered_user, invited_user)
index_page.expect_user_locked(active_user)
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
expect(active_user.reload)
.to be_locked
replace user index cuke
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.filter_by_status('locked permanently')
index_page.expect_listed(active_user)
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.filter_by_status('active')
index_page.expect_listed(current_user)
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.filter_by_status('locked permanently')
index_page.unlock_user(active_user)
index_page.expect_non_listed
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.filter_by_status('active')
index_page.expect_listed(current_user, active_user)
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.filter_by_name(active_user.lastname[0..-3])
index_page.expect_listed(active_user)
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
# temporarily block user
active_user.update(failed_login_count: 6,
last_failed_login_on: 9.minutes.ago)
index_page.clear_filters
index_page.expect_listed(current_user, active_user, registered_user, invited_user)
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.filter_by_status('locked temporarily')
index_page.expect_listed(active_user)
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.reset_failed_logins(active_user)
index_page.expect_non_listed
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
# temporarily block user and lock permanently
active_user.reload
active_user.update(failed_login_count: 6,
last_failed_login_on: 9.minutes.ago)
index_page.clear_filters
replace more user status cukes
6 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.filter_by_status('locked temporarily')
index_page.expect_listed(active_user)
[35507] Allow global permission to add and edit users (#8937) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>
4 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.lock_user(active_user)
index_page.expect_listed(active_user)
[35507] Allow global permission to add and edit users (#8937) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>
4 years ago
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
index_page.filter_by_status('locked permanently')
index_page.expect_listed(active_user)
index_page.unlock_and_reset_user(active_user)
index_page.expect_non_listed
index_page.filter_by_status('active')
index_page.expect_listed(current_user, active_user)
# activate registered user
index_page.filter_by_status('registered')
index_page.expect_listed(registered_user)
index_page.activate_user(registered_user)
index_page.filter_by_status('active')
index_page.expect_listed(current_user, active_user, registered_user)
end
context 'as global user' do
Allow deletion of placeholder users when permission of :manage_placeholder_user give (#9018) * Refactoring: Rename permission :add_user and :add_placholder_user to :manage_user and :manage_placeholder_user * Add deletion to :manage_placeholder_user permission label * WIP: Check :manage_placeholder_user permission before deletion Specs still missing * In controller rely on authorize_global for deleting placeholder users * Add deletion_info for placeholder users * Extend specs * Set placeholder users to locked when deleting * Review feedback Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
shared_let(:global_manage_user) { FactoryBot.create :user, global_permission: :manage_user }
let(:current_user) { global_manage_user }
[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012
4 years ago
it 'can too visit the page' do
index_page.visit!
index_page.expect_listed(current_user, active_user, registered_user, invited_user)
end
[35507] Allow global permission to add and edit users (#8937) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>
4 years ago
end
replace user index cuke
6 years ago
end
end