OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/spec/features/users/invite_user_modal/custom_fields_spec.rb

142 lines
5.5 KiB

User custom fields in the invite user modal (#9220) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Removed projects routes and ruby template * Removed projects routes and dynamic forms from Projects * Revert "Provide DynamicFieldsService in root so it can be used independently" This reverts commit ab56f3c56f6c8c3c3b791c081c762aa713e83a41. * Provide DynamicFieldsService in root so it can be used independently * TODO: test ProjectsComponent * Code climate fixes (remove TODOs) * Default OpFormFieldComponent.inlineLabel to false * Dynamic components tests xkipped * Typing improvements * DynamicFormComponent working as a FormControl * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fixes * noWrapLabel default to false * Started adding user custom fields to the ium * Import the dynamic-forms module into the common module * Refactor edit fields to avoid circular dependencies in the dynamic forms * Using DynamicFormsModule in OpenprojectInviteUserModalModule * Add formly form * Update principal name filter * Dynamic form field is rendering * Handling multi-values (also as links) and passwords * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Moved to FormGroup input for dynamic form * Custom field happy path is done * Add explanatory comment to payload structure transformation * add op-form class to ium steps * Add shrinkwrap back in * Fix test, fix dynamic form resource path * gimme a shirnkwrap * Remove failing tests * Remove another failing test * Remove more failing specs * Fix double loading of principals * Add custom field spec * Fix spec * Reset shrinkwrap * Forbid Factory.build(:user, member_in_project) If you use the trait member_in_project(s), the user is implicitly saved to create the member. This is very confusing if trying to use required custom fields, as this will fail with the Member#user_id foreign key being nil, as the user cannot be saved. Instead, raise an error when trying to use this factory trait * Change additional spec factory Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
require 'spec_helper'
# rubocop:disable RSpec/MultipleMemoizedHelpers
feature 'Invite user modal custom fields', type: :feature, js: true do
shared_let(:project) { FactoryBot.create :project }
let(:permissions) { %i[view_project manage_members] }
let(:global_permissions) { %i[manage_user] }
let(:principal) { FactoryBot.build :invited_user }
let(:modal) do
::Components::Users::InviteUserModal.new project: project,
principal: principal,
role: role
end
let!(:role) do
FactoryBot.create :role,
name: 'Member',
permissions: permissions
end
let!(:boolean_cf) { FactoryBot.create :boolean_user_custom_field, name: 'bool', is_required: true }
let!(:integer_cf) { FactoryBot.create :integer_user_custom_field, name: 'int', is_required: true }
let!(:text_cf) { FactoryBot.create :text_user_custom_field, name: 'Text', is_required: true }
let!(:string_cf) { FactoryBot.create :string_user_custom_field, name: 'String', is_required: true }
# TODO float not supported yet
#let!(:float_cf) { FactoryBot.create :float_user_custom_field, name: 'Float', is_required: true }
let!(:list_cf) { FactoryBot.create :list_user_custom_field, name: 'List', is_required: true }
let!(:list_multi_cf) { FactoryBot.create :list_user_custom_field, name: 'Multi list', multi_value: true, is_required: true }
let!(:non_req_cf) { FactoryBot.create :string_user_custom_field, name: 'non req', is_required: false }
let(:boolean_field) { ::FormFields::InputFormField.new boolean_cf }
let(:integer_field) { ::FormFields::InputFormField.new integer_cf }
let(:text_field) { ::FormFields::EditorFormField.new text_cf }
let(:string_field) { ::FormFields::InputFormField.new string_cf }
# TODO float not supported yet
#let(:float_field) { ::FormFields::InputFormField.new float_cf }
let(:list_field) { ::FormFields::SelectFormField.new list_cf }
let(:list_multi_field) { ::FormFields::SelectFormField.new list_multi_cf }
let(:quick_add) { ::Components::QuickAddMenu.new }
current_user do
FactoryBot.create :user,
:skip_validations,
member_in_project: project,
member_through_role: role,
global_permissions: global_permissions
end
it 'shows the required fields during the principal step' do
visit home_path
quick_add.expect_visible
quick_add.toggle
quick_add.click_link 'Invite user'
modal.project_step
# Fill the principal and try to go to next
sleep 1
modal.principal_step
expect(page).to have_selector('form.ng-invalid', wait: 10)
modal.within_modal do
expect(page).to have_text "bool can't be blank."
expect(page).to have_text "int can't be blank."
expect(page).to have_text "Text can't be blank."
expect(page).to have_text "String can't be blank."
expect(page).to have_text "List can't be blank."
expect(page).to have_text "Multi list can't be blank."
# Does not show the non req field
expect(page).to have_no_text non_req_cf.name
end
# Fill all fields
boolean_field.input_element.check
integer_field.set_value '1234'
text_field.set_value 'A **markdown** value'
string_field.set_value 'String value'
list_field.select_option '1'
list_multi_field.select_option '1', '2'
modal.click_next
# Remaining steps
modal.role_step
modal.invitation_step
modal.confirmation_step
modal.click_modal_button 'Send invitation'
modal.expect_text "Invite #{principal.mail} to #{project.name}"
# Close
modal.click_modal_button 'Send invitation'
modal.expect_text "#{principal.mail} was invited!"
# Expect to be added to project
invited = project.users.last
expect(invited.mail).to eq principal.mail
expect(invited.custom_value_for(boolean_cf).typed_value).to eq true
expect(invited.custom_value_for(integer_cf).typed_value).to eq 1234
expect(invited.custom_value_for(text_cf).typed_value).to eq 'A **markdown** value'
expect(invited.custom_value_for(string_cf).typed_value).to eq 'String value'
expect(invited.custom_value_for(list_cf).typed_value).to eq '1'
expect(invited.custom_value_for(list_multi_cf).map(&:typed_value)).to eq %w[1 2]
end
end