OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/spec/features/users/user_memberships_spec.rb

121 lines
4.0 KiB

#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
require 'spec_helper'
feature 'user memberships through user page', type: :feature, js: true do
let!(:project) { FactoryBot.create :project, name: 'Project 1', identifier: 'project1' }
let!(:project2) { FactoryBot.create :project, name: 'Project 2', identifier: 'project2' }
let(:admin) { FactoryBot.create :admin, firstname: 'Foobar', lastname: 'Blabla' }
let!(:manager) { FactoryBot.create :role, name: 'Manager' }
let!(:developer) { FactoryBot.create :role, name: 'Developer' }
Placeholder user services and administration (#8944) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
let(:user_page) { Pages::Admin::IndividualPrincipals::Edit.new(admin) }
before do
login_as(admin)
user_page.visit!
user_page.open_projects_tab!
end
scenario 'handles role modification flow' do
SeleniumHubWaiter.wait
user_page.add_to_project! project.name, as: 'Manager'
member = admin.memberships.where(project_id: project.id).first
SeleniumHubWaiter.wait
user_page.edit_roles!(member, %w(Manager Developer))
# Modify roles
user_page.expect_project(project.name)
user_page.expect_roles(project.name, %w(Manager Developer))
user_page.expect_no_membership(project2.name)
# Remove all roles
user_page.expect_project(project.name)
SeleniumHubWaiter.wait
user_page.edit_roles!(member, %w())
expect(page).to have_selector('.flash.error', text: 'Roles need to be assigned.')
# Remove the user from the project
user_page.remove_from_project!(project.name)
user_page.expect_no_membership(project.name)
# Re-add the user
SeleniumHubWaiter.wait
user_page.add_to_project! project.name, as: %w(Manager Developer)
user_page.expect_project(project.name)
user_page.expect_roles(project.name, %w(Manager Developer))
end
7 years ago
context 'when user has an inherited role' do
let(:group) { FactoryBot.create :group, lastname: 'A-Team' }
let(:group_page) { Pages::Groups.new.group(group.id) }
7 years ago
before do
group.add_members! admin
7 years ago
end
scenario 'it can remove all other roles' do
user_page.expect_no_membership(project.name)
group_page.visit!
SeleniumHubWaiter.wait
7 years ago
group_page.add_to_project! project.name, as: 'Manager'
expect(page).to have_text 'Successful update'
user_page.visit!
user_page.open_projects_tab!
# Expect inherited membership
user_page.expect_project(project.name)
user_page.expect_roles(project.name, %w(Manager))
# Remove all roles
member = admin.memberships.where(project_id: project.id).first
SeleniumHubWaiter.wait
7 years ago
user_page.edit_roles!(member, %w())
# Keeps inherited role
user_page.expect_project(project.name)
user_page.expect_roles(project.name, %w(Manager))
# Extend roles
SeleniumHubWaiter.wait
7 years ago
user_page.edit_roles!(member, %w(Developer))
user_page.expect_project(project.name)
user_page.expect_roles(project.name, %w(Manager Developer))
end
end
end