OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/spec/models/work_packages/spent_time_spec.rb

164 lines
5.2 KiB

#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++
require 'spec_helper'
describe WorkPackage, 'spent_time', type: :model do
let(:project) do
work_package.project
end
let(:other_project) do
child_work_package_in_other_project.project
end
let(:work_package) do
FactoryBot.create(:work_package)
end
let(:child_work_package) do
FactoryBot.create(:work_package,
project: project,
parent: work_package)
end
let(:child_work_package_in_other_project) do
FactoryBot.create(:work_package,
parent: work_package)
end
let!(:time_entry) do
FactoryBot.create(:time_entry,
work_package: work_package,
project: project)
end
let(:time_entry2) do
FactoryBot.create(:time_entry,
work_package: work_package,
project: project)
end
let(:child_time_entry) do
FactoryBot.create(:time_entry,
work_package: child_work_package,
project: project)
end
let(:child_time_entry_in_other_project) do
FactoryBot.create(:time_entry,
work_package: child_work_package_in_other_project,
project: other_project)
end
let(:role) do
FactoryBot.build(:role,
permissions: %i[view_time_entries view_work_packages])
end
let(:role_without_view_time_entries) do
FactoryBot.build(:role,
permissions: [:view_work_packages])
end
let(:role_without_view_work_packages) do
FactoryBot.build(:role,
permissions: [:view_time_entries])
end
let(:user) do
User custom fields in the invite user modal (#9220) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Removed projects routes and ruby template * Removed projects routes and dynamic forms from Projects * Revert "Provide DynamicFieldsService in root so it can be used independently" This reverts commit ab56f3c56f6c8c3c3b791c081c762aa713e83a41. * Provide DynamicFieldsService in root so it can be used independently * TODO: test ProjectsComponent * Code climate fixes (remove TODOs) * Default OpFormFieldComponent.inlineLabel to false * Dynamic components tests xkipped * Typing improvements * DynamicFormComponent working as a FormControl * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fixes * noWrapLabel default to false * Started adding user custom fields to the ium * Import the dynamic-forms module into the common module * Refactor edit fields to avoid circular dependencies in the dynamic forms * Using DynamicFormsModule in OpenprojectInviteUserModalModule * Add formly form * Update principal name filter * Dynamic form field is rendering * Handling multi-values (also as links) and passwords * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Moved to FormGroup input for dynamic form * Custom field happy path is done * Add explanatory comment to payload structure transformation * add op-form class to ium steps * Add shrinkwrap back in * Fix test, fix dynamic form resource path * gimme a shirnkwrap * Remove failing tests * Remove another failing test * Remove more failing specs * Fix double loading of principals * Add custom field spec * Fix spec * Reset shrinkwrap * Forbid Factory.build(:user, member_in_project) If you use the trait member_in_project(s), the user is implicitly saved to create the member. This is very confusing if trying to use required custom fields, as this will fail with the Member#user_id foreign key being nil, as the user cannot be saved. Instead, raise an error when trying to use this factory trait * Change additional spec factory Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Oliver Günther <mail@oliverguenther.de>
4 years ago
FactoryBot.create(:user,
member_in_project: project,
member_through_role: role)
end
before do
allow(Setting).to receive(:cross_project_work_package_relations?).and_return(true)
login_as user
end
shared_examples_for 'spent hours' do
it 'has the spent time of the time entry' do
expect(subject).to eql time_entry.hours
end
it 'sums up the spent time of the time entries' do
sum = time_entry.hours + time_entry2.hours
expect(subject).to eql sum
end
it 'inherits the spent time of the descendants' do
sum = time_entry.hours + child_time_entry.hours
expect(subject).to eql sum
end
context 'permissions' do
it 'counts the child if that child is in a project in which the user ' +
'has the necessary permissions' do
FactoryBot.create(:member,
user: user,
project: other_project,
roles: [role])
sum = time_entry.hours + child_time_entry_in_other_project.hours
expect(subject).to eql sum
end
it 'does not count the child if that child is in a project in which the user ' +
'lacks the view_time_entries permission' do
FactoryBot.create(:member,
user: user,
project: other_project,
roles: [role_without_view_time_entries])
child_time_entry_in_other_project.save!
sum = time_entry.hours
expect(subject).to eql sum
end
it 'does not count the child if that child is in a project in which the user ' +
'lacks the view_work_packages permission' do
FactoryBot.create(:member,
user: user,
project: other_project,
roles: [role_without_view_work_packages])
child_time_entry_in_other_project.save!
sum = time_entry.hours
expect(subject).to eql sum
end
end
end
context 'for a work_package loaded individually' do
subject { work_package.spent_hours }
it_behaves_like 'spent hours'
end
context 'for a work package that had spent time eager loaded' do
subject { WorkPackage.include_spent_time(user).where(id: work_package.id).first.spent_hours }
it_behaves_like 'spent hours'
end
end