OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/spec/features/users/delete_spec.rb

141 lines
4.4 KiB

#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++
require 'spec_helper'
describe 'user deletion: ', type: :feature, js: true do
let(:dialog) { ::Components::PasswordConfirmationDialog.new }
before do
page.set_rack_session(user_id: current_user.id, updated_at: Time.now)
end
context 'regular user' do
let(:user_password) { 'bob!' * 4 }
let(:current_user) do
FactoryBot.create(:user,
password: user_password,
password_confirmation: user_password)
end
it 'can delete their own account', js: true do
Setting.users_deletable_by_self = 1
visit delete_my_account_info_path
fill_in 'login_verification', with: current_user.login
click_on 'Delete'
dialog.confirm_flow_with user_password
expect(page).to have_content 'Account successfully deleted'
expect(current_path).to eq '/login'
end
it 'cannot delete their own account if the settings forbid it' do
Setting.users_deletable_by_self = 0
visit my_account_path
within '#main-menu' do
expect(page).to_not have_content 'Delete account'
end
end
end
[35507] Allow global permission to add and edit users (#8937) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>
4 years ago
context 'user with global add role' do
let!(:user) { FactoryBot.create :user }
let(:current_user) { FactoryBot.create :user, global_permission: :manage_user }
[35507] Allow global permission to add and edit users (#8937) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>
4 years ago
it 'can not delete even if settings allow it', js: true do
Setting.users_deletable_by_admins = 1
visit edit_user_path(user)
expect(page).to have_content "#{user.firstname} #{user.lastname}"
expect(page).to_not have_content 'Delete account'
visit deletion_info_user_path(user)
expect(page).to have_text 'Error 404'
end
end
context 'admin user' do
let!(:user) { FactoryBot.create :user }
let(:user_password) { 'admin! * 4' }
let(:current_user) do
FactoryBot.create(:admin,
password: user_password,
password_confirmation: user_password)
end
it 'can delete other users if the setting permitts it', selenium: true do
Setting.users_deletable_by_admins = 1
visit edit_user_path(user)
expect(page).to have_content "#{user.firstname} #{user.lastname}"
click_on 'Delete'
SeleniumHubWaiter.wait
fill_in 'login_verification', with: user.login
click_on 'Delete'
dialog.confirm_flow_with 'wrong', should_fail: true
SeleniumHubWaiter.wait
fill_in 'login_verification', with: user.login
click_on 'Delete'
dialog.confirm_flow_with user_password, should_fail: false
expect(page).to have_content 'Account successfully deleted'
expect(current_path).to eq '/users'
end
it 'cannot delete other users if the settings forbid it' do
Setting.users_deletable_by_admins = 0
visit edit_user_path(user)
expect(page).to_not have_content 'Delete account'
end
it 'can change the deletablilty settings' do
Setting.users_deletable_by_admins = 0
Setting.users_deletable_by_self = 0
visit users_settings_path
find(:css, "#settings_users_deletable_by_admins").set(true)
find(:css, "#settings_users_deletable_by_self").set(true)
click_on 'Save'
expect(Setting.users_deletable_by_admins?).to eq true
expect(Setting.users_deletable_by_self?).to eq true
end
end
end