OpenProject is the leading open source project management software.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openproject/modules/bim/spec/features/model_management_spec.rb

145 lines
4.6 KiB

#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2021 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++
require 'spec_helper'
require_relative '../support/pages/ifc_models/index'
describe 'model management',
with_config: { edition: 'bim' },
type: :feature,
js: true do
let(:project) { FactoryBot.create :project, enabled_module_names: %i[bim work_package_tracking] }
let(:index_page) { Pages::IfcModels::Index.new(project) }
let(:role) { FactoryBot.create(:role, permissions: %i[view_ifc_models manage_bcf manage_ifc_models view_work_packages]) }
let(:user) do
FactoryBot.create :user,
member_in_project: project,
member_through_role: role
end
[37868] Whitelist for attachment mime types and extensions on upload (#9431) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract
3 years ago
let!(:model) do
FactoryBot.create(:ifc_model_minimal_converted,
project: project,
uploader: user,
is_default: true)
end
[37868] Whitelist for attachment mime types and extensions on upload (#9431) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract
3 years ago
let!(:model2) do
FactoryBot.create(:ifc_model_minimal_converted,
project: project,
uploader: user)
end
context 'with all permissions' do
before do
login_as(user)
model
model2
index_page.visit!
end
it 'I can perform all actions on the models' do
index_page.model_listed true, model.title
index_page.add_model_allowed true
index_page.edit_model_allowed model.title, true
index_page.delete_model_allowed model.title, true
index_page.edit_model model.title, 'My super cool new name'
index_page.delete_model 'My super cool new name'
end
it 'I can see single models and the defaults' do
index_page.model_listed true, model.title
index_page.show_model model
index_page.bcf_buttons true
index_page.visit!
index_page.model_listed true, model.title
index_page.show_defaults([model, model2])
index_page.bcf_buttons true
end
end
context 'with only viewing permissions' do
let(:view_role) { FactoryBot.create(:role, permissions: %i[view_ifc_models view_work_packages]) }
let(:view_user) do
FactoryBot.create :user,
member_in_project: project,
member_through_role: view_role
end
before do
login_as(view_user)
model
model2
index_page.visit!
end
it 'I can see, but not edit models' do
index_page.model_listed true, model.title
index_page.add_model_allowed false
index_page.edit_model_allowed model.title, false
index_page.delete_model_allowed model.title, false
end
it 'I can see single models and the defaults' do
index_page.model_listed true, model.title
index_page.show_model model
index_page.visit!
index_page.bcf_buttons false
index_page.model_listed true, model.title
index_page.show_defaults([model, model2])
end
end
context 'without any permissions' do
let(:no_permissions_role) { FactoryBot.create(:role, permissions: %i[]) }
let(:user_without_permissions) do
FactoryBot.create :user,
member_in_project: project,
member_through_role: no_permissions_role
end
before do
login_as(user_without_permissions)
model
index_page.visit!
end
it "I can't see any models and perform no actions" do
expected = '[Error 403] You are not authorized to access this page.'
expect(page).to have_selector('.op-toast.-error', text: expected)
index_page.add_model_allowed false
end
end
end