From 331da9469352b0a77b8fe703d428a43d32c3e264 Mon Sep 17 00:00:00 2001 From: Henriette Dinger Date: Fri, 29 Jul 2016 10:41:32 +0200 Subject: [PATCH 1/2] Show split icon on focus --- .../stylesheets/content/_work_packages_table.sass | 10 ++++++---- .../app/components/wp-table/wp-table.directive.html | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/app/assets/stylesheets/content/_work_packages_table.sass b/app/assets/stylesheets/content/_work_packages_table.sass index 7622a7f15e..730098565a 100644 --- a/app/assets/stylesheets/content/_work_packages_table.sass +++ b/app/assets/stylesheets/content/_work_packages_table.sass @@ -28,10 +28,12 @@ // Show details view button when hovering .wp-table--details-link - display: none - - .issue:hover & - display: inline-block + .issue:hover &, + &:focus + position: relative + left: 0 + width: 1.5rem + height: 1.5rem .icon position: relative diff --git a/frontend/app/components/wp-table/wp-table.directive.html b/frontend/app/components/wp-table/wp-table.directive.html index e8221a4e78..df6fdf57c6 100644 --- a/frontend/app/components/wp-table/wp-table.directive.html +++ b/frontend/app/components/wp-table/wp-table.directive.html @@ -132,7 +132,7 @@ model="row.checked"> - From d891a3606e5bb18b0bff8d0a56efd5909cf39fa0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20G=C3=BCnther?= Date: Tue, 2 Aug 2016 10:56:34 +0200 Subject: [PATCH 2/2] Fix selectors on query spec --- .../accessibility/work_packages/work_package_query_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/features/accessibility/work_packages/work_package_query_spec.rb b/spec/features/accessibility/work_packages/work_package_query_spec.rb index e1a429df76..6706e9db3e 100644 --- a/spec/features/accessibility/work_packages/work_package_query_spec.rb +++ b/spec/features/accessibility/work_packages/work_package_query_spec.rb @@ -206,10 +206,10 @@ describe 'Work package index accessibility', type: :feature, selenium: true do context 'focus' do let(:first_link_selector) do - 'table.keyboard-accessible-list tbody tr:first-child td.id a' + 'table.keyboard-accessible-list tbody tr:first-child .wp-table--details-link' end let(:second_link_selector) do - 'table.keyboard-accessible-list tbody tr:nth-child(2) td.id a' + 'table.keyboard-accessible-list tbody tr:nth-child(2) .wp-table--details-link' end it 'navigates with J' do