The MenuItems::QueryMenuItems class used to map the `starred` state is replaced by a simple boolean flag. The hidden flag is removed (but still readable) as the concept of `View`s completely replaces it.pull/9957/head
ulferts
3 years ago
parent
45704d1eba
commit
0fe90c21a7
@ -0,0 +1,88 @@ |
||||
class QueryViews < ActiveRecord::Migration[6.1] |
||||
def up |
||||
add_column :queries, |
||||
:starred, |
||||
:boolean, |
||||
default: false |
||||
|
||||
execute <<~SQL.squish |
||||
INSERT INTO |
||||
views ( |
||||
type, |
||||
query_id, |
||||
created_at, |
||||
updated_at |
||||
) |
||||
SELECT |
||||
'work_packages_table', |
||||
id, |
||||
created_at, |
||||
updated_at |
||||
FROM queries |
||||
WHERE |
||||
hidden = false |
||||
SQL |
||||
|
||||
execute <<~SQL.squish |
||||
UPDATE |
||||
queries |
||||
SET |
||||
starred = true |
||||
WHERE |
||||
id IN (SELECT navigatable_id FROM menu_items WHERE type = 'MenuItems::QueryMenuItem') |
||||
SQL |
||||
|
||||
execute <<~SQL.squish |
||||
DELETE FROM |
||||
menu_items |
||||
WHERE |
||||
type = 'MenuItems::QueryMenuItem' |
||||
SQL |
||||
|
||||
remove_column :queries, |
||||
:hidden |
||||
|
||||
rename_column :queries, |
||||
:is_public, |
||||
:public |
||||
end |
||||
|
||||
def down |
||||
rename_column :queries, |
||||
:public, |
||||
:is_public |
||||
|
||||
add_column :queries, |
||||
:hidden, |
||||
:boolean, |
||||
default: false |
||||
|
||||
# Consciously avoiding the use of a PostgreSQL 13.0 feature (gen_random_uuid()) |
||||
Query.where(starred: true).find_each do |query| |
||||
::MenuItem.create( |
||||
type: 'MenuItems::QueryMenuItem', |
||||
navigatable_id: query.id, |
||||
name: SecureRandom.uuid, |
||||
title: query.name |
||||
) |
||||
end |
||||
|
||||
execute <<~SQL.squish |
||||
UPDATE |
||||
queries |
||||
SET |
||||
hidden = true |
||||
WHERE |
||||
id NOT IN (SELECT query_id FROM views WHERE type = 'work_packages_table') |
||||
SQL |
||||
|
||||
execute <<~SQL.squish |
||||
DELETE FROM |
||||
views |
||||
WHERE type = 'work_packages_table' |
||||
SQL |
||||
|
||||
remove_column :queries, |
||||
:starred |
||||
end |
||||
end |
||||
@ -1,53 +0,0 @@ |
||||
#-- copyright |
||||
# OpenProject is an open source project management software. |
||||
# Copyright (C) 2012-2021 the OpenProject GmbH |
||||
# |
||||
# This program is free software; you can redistribute it and/or |
||||
# modify it under the terms of the GNU General Public License version 3. |
||||
# |
||||
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows: |
||||
# Copyright (C) 2006-2013 Jean-Philippe Lang |
||||
# Copyright (C) 2010-2013 the ChiliProject Team |
||||
# |
||||
# This program is free software; you can redistribute it and/or |
||||
# modify it under the terms of the GNU General Public License |
||||
# as published by the Free Software Foundation; either version 2 |
||||
# of the License, or (at your option) any later version. |
||||
# |
||||
# This program is distributed in the hope that it will be useful, |
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
||||
# GNU General Public License for more details. |
||||
# |
||||
# You should have received a copy of the GNU General Public License |
||||
# along with this program; if not, write to the Free Software |
||||
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
||||
# |
||||
# See COPYRIGHT and LICENSE files for more details. |
||||
#++ |
||||
|
||||
require 'spec_helper' |
||||
|
||||
describe MenuItems::QueryMenuItem, type: :model do |
||||
let(:project) { FactoryBot.create :project, enabled_module_names: %w[activity] } |
||||
let(:query) { FactoryBot.create :query, project: project } |
||||
let(:another_query) { FactoryBot.create :query, project: project } |
||||
|
||||
describe 'it should destroy all items when destroying' do |
||||
before(:each) do |
||||
query_item = FactoryBot.create(:query_menu_item, |
||||
query: query, |
||||
name: 'Query Item', |
||||
title: 'Query Item') |
||||
another_query_item = FactoryBot.create(:query_menu_item, |
||||
query: another_query, |
||||
name: 'Another Query Item', |
||||
title: 'Another Query Item') |
||||
end |
||||
|
||||
it 'the associated query' do |
||||
query.destroy |
||||
expect(MenuItems::QueryMenuItem.where(navigatable_id: query.id)).to be_empty |
||||
end |
||||
end |
||||
end |
||||
Loading…
Reference in new issue